All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Florent Revest <revest@chromium.org>, bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, kpsingh@kernel.org,
	jackmanb@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf v2] libbpf: Move BPF_SEQ_PRINTF and BPF_SNPRINTF to bpf_helpers.h
Date: Wed, 26 May 2021 08:35:19 +0200	[thread overview]
Message-ID: <f3e6c21e-8d6e-2665-770c-65f9b98ccf93@iogearbox.net> (raw)
In-Reply-To: <20210525201825.2729018-1-revest@chromium.org>

On 5/25/21 10:18 PM, Florent Revest wrote:
> These macros are convenient wrappers around the bpf_seq_printf and
> bpf_snprintf helpers. They are currently provided by bpf_tracing.h which
> targets low level tracing primitives. bpf_helpers.h is a better fit.
> 
> The __bpf_narg and __bpf_apply macros are needed in both files so
> provided twice and guarded by ifndefs.
> 
> Reported-by: Andrii Nakryiko <andrii@kernel.org>
> Signed-off-by: Florent Revest <revest@chromium.org>

Given v1/v2 both target bpf tree in the subject, do you really mean bpf or
rather bpf-next?

Thanks,
Daniel

  reply	other threads:[~2021-05-26  6:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 20:18 [PATCH bpf v2] libbpf: Move BPF_SEQ_PRINTF and BPF_SNPRINTF to bpf_helpers.h Florent Revest
2021-05-26  6:35 ` Daniel Borkmann [this message]
2021-05-26 15:01   ` Florent Revest
2021-05-26 16:35     ` Andrii Nakryiko
2021-05-26 16:37       ` Florent Revest
2021-05-26 16:34 ` Andrii Nakryiko
2021-05-26 16:36   ` Florent Revest
2021-05-26 17:01     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3e6c21e-8d6e-2665-770c-65f9b98ccf93@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jackmanb@google.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=revest@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.