From: Dario Faggioli <dfaggioli@suse.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Jeff Kubascik" <jeff.kubascik@dornerworks.com>,
xen-devel@lists.xenproject.org,
"George Dunlap" <george.dunlap@citrix.com>
Cc: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
Nathan Studer <Nathan.Studer@dornerworks.com>
Subject: Re: [Xen-devel] [PATCH] sched/core: Fix bug when moving a domain between cpupools
Date: Thu, 16 Apr 2020 18:09:07 +0200 [thread overview]
Message-ID: <f3e7c6bfc2203119b2dfc36bd1fb9167b4fbfb2c.camel@suse.com> (raw)
In-Reply-To: <9969e5ea-1378-3439-c9a5-19fb9b5c91ac@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Wed, 2020-04-15 at 11:08 +0200, Jürgen Groß wrote:
> On 27.03.20 20:30, Jeff Kubascik wrote:
> > For each UNIT, sched_set_affinity is called before unit->priv is
> > updated
> > to the new cpupool private UNIT data structure. The issue is
> > sched_set_affinity will call the adjust_affinity method of the
> > cpupool.
> > If defined, the new cpupool may use unit->priv (e.g. credit), which
> > at
> > this point still references the old cpupool private UNIT data
> > structure.
> >
> > This change fixes the bug by moving the switch of unit->priv earler
> > in
> > the function.
> >
> > Signed-off-by: Jeff Kubascik <jeff.kubascik@dornerworks.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
Sorry it took a while. And thanks Juergen for also having a look.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-16 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 19:30 [Xen-devel] [PATCH] sched/core: Fix bug when moving a domain between cpupools Jeff Kubascik
2020-04-14 20:52 ` Jeff Kubascik
2020-04-15 9:08 ` [Xen-devel] " Jürgen Groß
2020-04-16 16:09 ` Dario Faggioli [this message]
2020-04-20 13:42 ` Jeff Kubascik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e7c6bfc2203119b2dfc36bd1fb9167b4fbfb2c.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=Nathan.Studer@dornerworks.com \
--cc=Stewart.Hildebrand@dornerworks.com \
--cc=george.dunlap@citrix.com \
--cc=jeff.kubascik@dornerworks.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.