From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944AbeAaJOS (ORCPT ); Wed, 31 Jan 2018 04:14:18 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:31977 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbeAaJNq (ORCPT ); Wed, 31 Jan 2018 04:13:46 -0500 Subject: Re: [alsa-devel] [PATCH] sound/tlv320dac33: Add device tree support To: Ladislav Michl , Pavel Machek CC: , , , , , , , =?UTF-8?Q?Filip_Matijevi=c4=87?= , , , , , , , , , linux-arm-kernel , , , , , , , References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> From: Peter Ujfalusi Message-ID: Date: Wed, 31 Jan 2018 11:12:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180129232031.GA7695@lenoch> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-30 01:20, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote: >> >> This adds device tree support to tlv320dac33.c. >> >> Signed-off-by: Pavel Machek >> >> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt >> new file mode 100644 >> index 0000000..6cbd311 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt >> @@ -0,0 +1,32 @@ >> +Texas Instruments - tlv320dac33 Codec module >> + >> +The tlv320dac33 serial control bus communicates through I2C protocols. >> + >> +Required properties: >> + >> +- compatible - "ti,tlv320dac33" >> +- reg - I2C slave address >> + >> +Optional properties: >> + >> +- power-gpios - gpio pin to power the device, active high > > While driver used gpio in platform data, isn't it more likely > regulator which powers device? It is GPIO, and according to the non public TRM it is connected to the reset pin of the codec. So the correct name should be reset-gpios - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support Date: Wed, 31 Jan 2018 11:12:20 +0200 Message-ID: References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180129232031.GA7695@lenoch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ladislav Michl , Pavel Machek Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, tony@atomide.com, abcloriens@gmail.com, lgirdwood@gmail.com, martijn@brixit.nl, =?UTF-8?Q?Filip_Matijevi=c4=87?= , patrikbachan@gmail.com, ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, tiwai@suse.com, serge@hallyn.com, devicetree@vger.kernel.org, broonie@kernel.org, sre@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel , aaro.koskinen@iki.fi, linux-kernel@vger.kernel.org, robh+dt@kernel.org, clayton@craftyguy.net, sakari.ailus@linux.intel.com, pali.rohar@gmail.com, bhumirks@gmail.com List-Id: devicetree@vger.kernel.org CgpPbiAyMDE4LTAxLTMwIDAxOjIwLCBMYWRpc2xhdiBNaWNobCB3cm90ZToKPiBPbiBUdWUsIEph biAzMCwgMjAxOCBhdCAxMjowNTozOUFNICswMTAwLCBQYXZlbCBNYWNoZWsgd3JvdGU6Cj4+Cj4+ IFRoaXMgYWRkcyBkZXZpY2UgdHJlZSBzdXBwb3J0IHRvIHRsdjMyMGRhYzMzLmMuCj4+Cj4+IFNp Z25lZC1vZmYtYnk6IFBhdmVsIE1hY2hlayA8cGF2ZWxAdWN3LmN6Pgo+Pgo+PiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvdW5kL3RsdjMyMGRhYzMzLnR4 dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC90bHYzMjBkYWMzMy50 eHQKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4gaW5kZXggMDAwMDAwMC4uNmNiZDMxMQo+PiAt LS0gL2Rldi9udWxsCj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9z b3VuZC90bHYzMjBkYWMzMy50eHQKPj4gQEAgLTAsMCArMSwzMiBAQAo+PiArVGV4YXMgSW5zdHJ1 bWVudHMgLSB0bHYzMjBkYWMzMyBDb2RlYyBtb2R1bGUKPj4gKwo+PiArVGhlIHRsdjMyMGRhYzMz IHNlcmlhbCBjb250cm9sIGJ1cyBjb21tdW5pY2F0ZXMgdGhyb3VnaCBJMkMgcHJvdG9jb2xzLgo+ PiArCj4+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+PiArCj4+ICstIGNvbXBhdGlibGUgLSAidGks dGx2MzIwZGFjMzMiCj4+ICstIHJlZyAtIEkyQyBzbGF2ZSBhZGRyZXNzCj4+ICsKPj4gK09wdGlv bmFsIHByb3BlcnRpZXM6Cj4+ICsKPj4gKy0gcG93ZXItZ3Bpb3MgLSBncGlvIHBpbiB0byBwb3dl ciB0aGUgZGV2aWNlLCBhY3RpdmUgaGlnaAo+IAo+IFdoaWxlIGRyaXZlciB1c2VkIGdwaW8gaW4g cGxhdGZvcm0gZGF0YSwgaXNuJ3QgaXQgbW9yZSBsaWtlbHkKPiByZWd1bGF0b3Igd2hpY2ggcG93 ZXJzIGRldmljZT8KCkl0IGlzIEdQSU8sIGFuZCBhY2NvcmRpbmcgdG8gdGhlIG5vbiBwdWJsaWMg VFJNIGl0IGlzIGNvbm5lY3RlZCB0byB0aGUKcmVzZXQgcGluIG9mIHRoZSBjb2RlYy4KClNvIHRo ZSBjb3JyZWN0IG5hbWUgc2hvdWxkIGJlIHJlc2V0LWdwaW9zCgotIFDDqXRlcgoKVGV4YXMgSW5z dHJ1bWVudHMgRmlubGFuZCBPeSwgUG9ya2thbGFua2F0dSAyMiwgMDAxODAgSGVsc2lua2kuClkt dHVubnVzL0J1c2luZXNzIElEOiAwNjE1NTIxLTQuIEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNp bmtpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2Et ZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFp bG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Wed, 31 Jan 2018 11:12:20 +0200 Subject: [alsa-devel] [PATCH] sound/tlv320dac33: Add device tree support In-Reply-To: <20180129232031.GA7695@lenoch> References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018-01-30 01:20, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote: >> >> This adds device tree support to tlv320dac33.c. >> >> Signed-off-by: Pavel Machek >> >> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt >> new file mode 100644 >> index 0000000..6cbd311 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt >> @@ -0,0 +1,32 @@ >> +Texas Instruments - tlv320dac33 Codec module >> + >> +The tlv320dac33 serial control bus communicates through I2C protocols. >> + >> +Required properties: >> + >> +- compatible - "ti,tlv320dac33" >> +- reg - I2C slave address >> + >> +Optional properties: >> + >> +- power-gpios - gpio pin to power the device, active high > > While driver used gpio in platform data, isn't it more likely > regulator which powers device? It is GPIO, and according to the non public TRM it is connected to the reset pin of the codec. So the correct name should be reset-gpios - P?ter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki