All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrej Picej <andrej.picej@norik.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org
Cc: mchehab@kernel.org
Subject: Re: Problem with coda h264 decoder and different color formats
Date: Tue, 20 Jul 2021 08:33:43 +0200	[thread overview]
Message-ID: <f3f40e49-ba55-a6fe-5530-06a1fefe6295@norik.com> (raw)
In-Reply-To: <e134ee8dc40aa1acbce2fb86779cd1dab82357c1.camel@pengutronix.de>

Hi Philipp,

thanks for your answer.

> Can you confirm this works with 4.19.100 with exactly the same coda
> firmware that shows the broken behavior on 5.10.50?

Yes, exactly the same coda firmware (3.1.1) with 4.19.100 and 5.10.50:> 
[   10.461672] coda 2040000.vpu: Firmware version: 3.1.1

> 
> I think the culprit is commit 497e6b8559a6 ("media: coda: add sequence
> initialization work"), which moves some initialization earlier before
> userspace selects the final capture format.
> During __coda_decoder_seq_init() (which prints the "start decoding:
> 1920x960" line above), the ctx->frame_mem_ctrl is set for the default
> NV12/tiled output format. This is never corrected when streaming
> actually starts.
> 
> Could you check if this patch [1] helps?
> 
> [1] https://lore.kernel.org/linux-media/20210719145708.10643-1-p.zabel@pengutronix.de/T/#u
> 

Yes, this patch solves the problem. I can now successfully play videos 
with all supported decoder color formats (NV12, I420, YV12 and YUY2). 
This also works in Qt app.

I can't thank you enough for your fast response. Thank you so much.

Best regards,
Andrej

      reply	other threads:[~2021-07-20  6:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  9:07 Problem with coda h264 decoder and different color formats Andrej Picej
2021-07-19 14:59 ` Philipp Zabel
2021-07-20  6:33   ` Andrej Picej [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3f40e49-ba55-a6fe-5530-06a1fefe6295@norik.com \
    --to=andrej.picej@norik.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.