From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Date: Mon, 29 May 2017 14:18:48 +0200
Subject: [U-Boot] [PATCHv4 3/3] ARM64: poplar: hi3798cv200: u-boot
 support for Poplar 96Boards
In-Reply-To: <20170529115700.GJ10782@bill-the-cat>
References: <e1f3579e-91ed-98ca-1d8d-3ac6dec0e7ae@linaro.org>
 <21be0cad-5ac4-63c2-851a-fd28c4dc2a35@linaro.org>
 <20170525211205.GF10782@bill-the-cat>
 <f4a4f31b-544f-4785-bb28-4be865000cfd@linaro.org>
 <20170525220853.GG10782@bill-the-cat>
 <29be56cb-767b-2992-1d4a-9149ddac5092@linaro.org>
 <20170526124630.GM10782@bill-the-cat>
 <CAPPM39ZTbPL9g6334nrBKEv1e9mcVjgRE=LM3xvwoXPvJ4=bnQ@mail.gmail.com>
 <20170526160937.GP10782@bill-the-cat>
 <20507012-1989-607a-dcf1-ddfa5837f033@linaro.org>
 <20170529115700.GJ10782@bill-the-cat>
Message-ID: <f3fb6e64-52c2-ad3f-72ef-d25834d77a84@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/29/2017 01:57 PM, Tom Rini wrote:
>> The issue is actually with serial-uclass.c when the kernel dts
>> contains a chosen node that contains the stdout-path.
>>      chosen {
>>          stdout-path = "serial0:115200n8";
>>      };
>>
>> Disabling uart0 (ie serial0) in u-boot.dtsi loses the console
>> instead of probing the pl01x for the platform_data.
>>
>> is there a pre-defined way to work around this?
> Provide a new stdout-path in the -u-boot.dtsi too?  Any changes you

yes I obviously tried that but are you sure that that is allowed with 
"chosen" it being kind of a special type of node?
the compiler just cant find the label when added to u-boot.dtsi hence 
why I was asking (sorry, I should have raised it upfront)
ie:

/*
  * U-Boot addition to:
  *  1) use platform data for the console
  *  2) provide support for the generic-ehci USB driver currently not 
available
  *     in the linux kernel (8/May/2017).
  *
  * (C) Copyright 2017 Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
  *
  * SPDX-License-Identifier:     GPL-2.0+
  */

&soc {
     usb2: ehci at 9890000 {
         compatible = "generic-ehci";
         reg = <0x9890000 0x100>;
         status = "okay";
     };
};

&uart0 {
     status = "disabled";
};

&chosen {
     stdout-path = &uart0;

};


leads to

   LD      u-boot
   OBJCOPY u-boot.srec
   OBJCOPY u-boot-nodtb.bin
   SYM     u-boot.sym
start=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_start | cut -f 1 -d 
' '); end=$(aarch64-linux-gnu-nm u-boot | grep __rel_dyn_end | cut -f 1 
-d ' '); tools/relocate-rela u-boot-nodtb.bin 0x37000000 $start $end
   DTC     arch/arm/dts/hi3798cv200-poplar.dtb
Error: ./arch/arm/dts/hi3798cv200-u-boot.dtsi:27.2-3 label or path, 
'chosen', not found
FATAL ERROR: Syntax error parsing input tree
scripts/Makefile.lib:322: recipe for target 
'arch/arm/dts/hi3798cv200-poplar.dtb' failed
make[2]: *** [arch/arm/dts/hi3798cv200-poplar.dtb] Error 1
dts/Makefile:32: recipe for target 'arch/arm/dts/hi3798cv200-poplar.dtb' 
failed
make[1]: *** [arch/arm/dts/hi3798cv200-poplar.dtb] Error 2
Makefile:865: recipe for target 'dts/dt.dtb' failed
make: *** [dts/dt.dtb] Error 2

> could make to the main dts file so that this would work should be able
> to be done in the -u-boot.dtsi too.