All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address
@ 2021-07-13  4:11 Dylan MacKenzie
  2021-07-13 23:31 ` Dylan MacKenzie
  0 siblings, 1 reply; 4+ messages in thread
From: Dylan MacKenzie @ 2021-07-13  4:11 UTC (permalink / raw)
  To: jikos
  Cc: Basavaraj.Natikar, Nehal-Bakulchandra.shah, benjamin.tissoires,
	ecstaticmorse, linux-input, shyam-sundar.s-k

amd_stop_sensor_v2 accidentally used a different MMIO register than
amd_start_sensor_v2 for the DMA address.
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 96e2577fa37e..8d68796aa905 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	cmd_base.cmd_v2.sensor_id = sensor_idx;
 	cmd_base.cmd_v2.length  = 16;
 
-	writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+	writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address
  2021-07-13  4:11 [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address Dylan MacKenzie
@ 2021-07-13 23:31 ` Dylan MacKenzie
  2021-07-15  6:34   ` Basavaraj Natikar
  0 siblings, 1 reply; 4+ messages in thread
From: Dylan MacKenzie @ 2021-07-13 23:31 UTC (permalink / raw)
  To: ecstaticmorse
  Cc: Basavaraj.Natikar, Nehal-Bakulchandra.shah, benjamin.tissoires,
	jikos, linux-input, shyam-sundar.s-k

amd_stop_sensor_v2 accidentally used a different MMIO register than
amd_start_sensor_v2 for the DMA address.

Signed-off-by: Dylan MacKenzie <ecstaticmorse@gmail.com>
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 96e2577fa37e..8d68796aa905 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	cmd_base.cmd_v2.sensor_id = sensor_idx;
 	cmd_base.cmd_v2.length  = 16;
 
-	writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+	writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address
  2021-07-13 23:31 ` Dylan MacKenzie
@ 2021-07-15  6:34   ` Basavaraj Natikar
  2021-07-15 19:41     ` Jiri Kosina
  0 siblings, 1 reply; 4+ messages in thread
From: Basavaraj Natikar @ 2021-07-15  6:34 UTC (permalink / raw)
  To: Dylan MacKenzie
  Cc: Basavaraj.Natikar, Nehal-Bakulchandra.shah, benjamin.tissoires,
	jikos, linux-input, shyam-sundar.s-k

hi

On 7/14/2021 5:01 AM, Dylan MacKenzie wrote:
> [CAUTION: External Email]
>
> amd_stop_sensor_v2 accidentally used a different MMIO register than
> amd_start_sensor_v2 for the DMA address.
>
> Signed-off-by: Dylan MacKenzie <ecstaticmorse@gmail.com>

Looks good to me. Can you please add a "Fixes:" tag too?
With that addressed,

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

> ---
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> index 96e2577fa37e..8d68796aa905 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> @@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
>         cmd_base.cmd_v2.sensor_id = sensor_idx;
>         cmd_base.cmd_v2.length  = 16;
>
> -       writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
> +       writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
>         writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
>  }
>
> --
> 2.31.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address
  2021-07-15  6:34   ` Basavaraj Natikar
@ 2021-07-15 19:41     ` Jiri Kosina
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2021-07-15 19:41 UTC (permalink / raw)
  To: Basavaraj Natikar
  Cc: Dylan MacKenzie, Basavaraj.Natikar, Nehal-Bakulchandra.shah,
	benjamin.tissoires, linux-input, shyam-sundar.s-k

On Thu, 15 Jul 2021, Basavaraj Natikar wrote:

> > amd_stop_sensor_v2 accidentally used a different MMIO register than
> > amd_start_sensor_v2 for the DMA address.
> >
> > Signed-off-by: Dylan MacKenzie <ecstaticmorse@gmail.com>
> 
> Looks good to me. Can you please add a "Fixes:" tag too?
> With that addressed,
> 
> Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

I've added the proper Fixes: tag and applied, thanks.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-15 19:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13  4:11 [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address Dylan MacKenzie
2021-07-13 23:31 ` Dylan MacKenzie
2021-07-15  6:34   ` Basavaraj Natikar
2021-07-15 19:41     ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.