From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDzTE-0001Zr-Iw for qemu-devel@nongnu.org; Sat, 20 Dec 2008 05:54:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDzTC-0001Yc-L6 for qemu-devel@nongnu.org; Sat, 20 Dec 2008 05:54:07 -0500 Received: from [199.232.76.173] (port=46062 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDzTC-0001YT-E3 for qemu-devel@nongnu.org; Sat, 20 Dec 2008 05:54:06 -0500 Received: from mail-bw0-f12.google.com ([209.85.218.12]:36331) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LDzTB-0004O6-PM for qemu-devel@nongnu.org; Sat, 20 Dec 2008 05:54:06 -0500 Received: by bwz5 with SMTP id 5so876491bwz.10 for ; Sat, 20 Dec 2008 02:54:04 -0800 (PST) Message-ID: Date: Sat, 20 Dec 2008 12:54:03 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack In-Reply-To: <374626.12189.qm@web51107.mail.re2.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <374626.12189.qm@web51107.mail.re2.yahoo.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: theburner1@yahoo.com Cc: qemu-devel@nongnu.org On 12/19/08, Justin Chevrier wrote: > > > > --- On Fri, 12/19/08, Blue Swirl wrote: > > > From: Blue Swirl > > Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack > > To: theburner1@yahoo.com, qemu-devel@nongnu.org > > Date: Friday, December 19, 2008, 2:43 PM > > > On 12/18/08, Justin Chevrier > > wrote: > > > Hey guys, > > > > > > I'm tracking down the next issue(s) with the > > Openserver installation. The current issue is that during > > installation when the installer tries to link the BLTD (eg. > > SCSI drivers) drivers into the kernel it is unable to access > > the floppy drive. After reviewing the debug logs it turns > > out that the installer dosen't like the value being > > returned by Sense Interrupt. The cause of this is a hack in > > the Sense Interrupt code that always returns an OR'd > > value based on FD_SR0_SEEK instead of the actual Status0 > > regsiter. The hack identifies that the floppy code is broken > > with regard to Status0 and Read/Writes. Outside of setting > > particular values in case of CRC errors/etc I can't > > identify from datasheets what we should be doing. I've > > tracked down what I believe is the original mailing list > > post regarding this hack and it seems to be related to > > Windows 2000 and higher OS's recognizing the floppy > > drive. I applied the patch below and verified that > > > detection/read/writes/formatting still work in > > Windows XP SP2. > > > > > > Original post: > > > > > http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00076.html > > > > > > SVN change: > > > > > http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=1118 > > > > > > Having said the above does anyone know what the > > comment in the hack is referencing? Is it still needed? If > > so what needs to be done to eliminate it? > > > > > > If it's no longer needed I propose the patch > > below. > > > > > > Justin > > > > > > Changelog: > > > > > > Remove Sense Interrupt hack > > > > > > Signed-off-by: Justin Chevrier > > > > > > It may be a hack, but if we remove it, Sparc64 refuses to > > boot and > > prints endlessly: > > SENSEI c0 00 > > SENSEI c0 00 > > SENSEI c0 00 > > SENSEI c0 00 > > > Okay, thanks for the feedback! > > I'll start looking into what SPARC64 expects here. The message is printed here: http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/drivers/floppy.c#L359