From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqsSl-0002Lq-AX
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 13:50:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqsSg-0002Ir-M5
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 13:50:38 -0400
Received: from [199.232.76.173] (port=42192 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqsSg-0002Ik-H4
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 13:50:34 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:62203)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MqsSf-0004qq-Pz
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 13:50:34 -0400
Received: by fxm10 with SMTP id 10so1644605fxm.8
	for <qemu-devel@nongnu.org>; Thu, 24 Sep 2009 10:50:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090923200635.GA21246@redhat.com>
References: <20090923200635.GA21246@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 24 Sep 2009 20:50:11 +0300
Message-ID: <f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Sep 23, 2009 at 11:06 PM, Michael S. Tsirkin <mst@redhat.com> wrote=
:
> This creates target.c, which builds per-target, and makes it possible
> for devices to become target-independent. =C2=A0Use it in msix, reverting
> part of 5e520a7d500ec2569d22d80f9ef4272a34cb3c80, as we no longer have
> to pass target page around.

> +unsigned target_page_align(unsigned value)
> +{
> + =C2=A0 =C2=A0 =C2=A0 return TARGET_PAGE_ALIGN(value);
> +}

This must be:
target_phys_addr_t target_page_align(target_phys_addr_t value)

As this is not a clean revert anyway, please don't revert the part changing
if (x)
 y;
else
 z;

to

if (x) {
 y;
} else {
 z;
}