From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N6Uth-00062P-I5
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:55:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N6UtX-0005mP-Ug
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:55:00 -0500
Received: from [199.232.76.173] (port=54608 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N6UtX-0005mA-Q3
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:54:51 -0500
Received: from mail-gx0-f213.google.com ([209.85.217.213]:48925)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1N6UtX-00072l-5R
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:54:51 -0500
Received: by gxk5 with SMTP id 5so1270710gxk.17
	for <qemu-devel@nongnu.org>; Fri, 06 Nov 2009 11:54:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <761ea48b0911061150s74c9b145kaf7b25df973210c@mail.gmail.com>
References: <1257437115-22725-1-git-send-email-glommer@redhat.com>
	<f43fc5580911061005l3fa4b23i17b52f7b9fc0f7fe@mail.gmail.com>
	<20091106181153.GB12533@mothafucka.localdomain>
	<761ea48b0911061043i5dbaaab5td2e0d34cc4ed68a9@mail.gmail.com>
	<f43fc5580911061101w6334864exa57a81d182df7bdc@mail.gmail.com>
	<761ea48b0911061113n7f254ac4wd1d9f994abe0f53a@mail.gmail.com>
	<f43fc5580911061136u69c06151x58114bf106c8cae7@mail.gmail.com>
	<761ea48b0911061150s74c9b145kaf7b25df973210c@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Fri, 6 Nov 2009 21:54:26 +0200
Message-ID: <f43fc5580911061154m236a221x50ce393e7cddd576@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu
	initialization
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, Nov 6, 2009 at 9:50 PM, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> On Fri, Nov 6, 2009 at 8:36 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Fri, Nov 6, 2009 at 9:13 PM, Laurent Desnogues
>> <laurent.desnogues@gmail.com> wrote:
>>> On Fri, Nov 6, 2009 at 8:01 PM, Blue Swirl <blauwirbel@gmail.com> wrote=
:
>>>> On Fri, Nov 6, 2009 at 8:43 PM, Laurent Desnogues
>>>> <laurent.desnogues@gmail.com> wrote:
>>> [...]
>>>>> I honestly don't care that much as long as all targets still work
>>>>> in user mode :-)
>>>>>
>>>>> The aim was to make Glauber's patch less intrusive.
>>>>
>>>> Given that only the new calls to cpu_reset are important and the
>>>> removals are much less so (double reset shouldn't be a problem), the
>>>> least intrusive version would be to just add the new calls and do the
>>>> clean up later.
>>>
>>> Multiple resets would result in memory leaks for MIPS for instance.
>>> So I don't think they are that innocuous. =C2=A0Though that probably is
>>> more a problem of the MIPS reset than anything else :-)
>>
>> You are hinting at target-mips/translate_init.c: mmu_init()? Right, it
>> shouldn't do the allocation.
>
> No, I was talking about mvp_init.

Both are then buggy.

Why are these even allocated instead being members of CPUState?