From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N6nt9-0004cY-77
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 11:11:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N6nt2-0004Yz-KG
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 11:11:41 -0500
Received: from [199.232.76.173] (port=53863 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N6nt1-0004Yw-TL
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 11:11:35 -0500
Received: from mail-yw0-f176.google.com ([209.85.211.176]:33371)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1N6nt1-0008H9-LO
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 11:11:35 -0500
Received: by ywh6 with SMTP id 6so1635239ywh.4
	for <qemu-devel@nongnu.org>; Sat, 07 Nov 2009 08:11:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <761ea48b0911070802p3cb1d501te1f1718a1b0e5280@mail.gmail.com>
References: <1257437115-22725-1-git-send-email-glommer@redhat.com>
	<f43fc5580911061005l3fa4b23i17b52f7b9fc0f7fe@mail.gmail.com>
	<20091106181153.GB12533@mothafucka.localdomain>
	<761ea48b0911061043i5dbaaab5td2e0d34cc4ed68a9@mail.gmail.com>
	<f43fc5580911061101w6334864exa57a81d182df7bdc@mail.gmail.com>
	<20091106204115.GE12533@mothafucka.localdomain>
	<f43fc5580911070040v66fe17eev38f4cfafebd8bc3f@mail.gmail.com>
	<761ea48b0911070802p3cb1d501te1f1718a1b0e5280@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 7 Nov 2009 18:11:15 +0200
Message-ID: <f43fc5580911070811n1ea9eebai9f3a92cbcf1e57b2@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu
	initialization
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Sat, Nov 7, 2009 at 6:02 PM, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> On Sat, Nov 7, 2009 at 9:40 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
> [...]
>> Thanks, applied. While testing I noticed that the poor x86 emulator
>> does not survive even five system_resets until BIOS refuses to boot.
>> This happens without your patch. In comparison, I see no problems
>> resetting Sparc32, Sparc64 or PPC.
>
> Unless I missed something you didn't commit Glauber's patch.

What's c169998802505c244b8bcad562633f29de7d74a4 then?

> So now in user mode cpu_reset differs for i386, SPARC
> and PPC, and all other targets.

No, for example MIPS cpu_reset is still called only once from cpu_mips_init=
.

> On top of that you didn't add a call to cpu_reset from cpu_copy
> which also calls cpu_init. =C2=A0Are you sure it's OK?

It's not, I forgot to add that, sorry.