From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA48EC43215 for ; Mon, 2 Dec 2019 10:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8168B2084F for ; Mon, 2 Dec 2019 10:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575280814; bh=0tDFuUSEsHsi2HDxMKGgmxIpdwpgGoFiRUoublzRD0Y=; h=To:Subject:Date:From:Cc:In-Reply-To:References:List-ID:From; b=twH7YHWAF2ojzf3l+TjLSrg3lTx7JXGbz73dFVOJ8jp4w/YnlCOOA9Y7iXffG2qn/ xNDYy3rp8TjKbt4v1xeBFkVsHRwXJmbodZiX8J2wQLSZUG9S2vrP4tElUQU6+YzHMO wSgsadVt4LbvR5viQ+UaDSUXbdNsIsamukD4yGjw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727378AbfLBKAN (ORCPT ); Mon, 2 Dec 2019 05:00:13 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:56544 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfLBKAN (ORCPT ); Mon, 2 Dec 2019 05:00:13 -0500 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1ibiUy-0006FX-Mv; Mon, 02 Dec 2019 11:00:08 +0100 To: Zenghui Yu Subject: Re: [PATCH] irqchip/gic-v3-its: Reference to =?UTF-8?Q?its=5Finvall=5Fcmd=20descriptor=20when=20building=20INVALL?= X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 02 Dec 2019 10:00:08 +0000 From: Marc Zyngier Cc: , , , , In-Reply-To: <20191202071021.1251-1-yuzenghui@huawei.com> References: <20191202071021.1251-1-yuzenghui@huawei.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zenghui, On 2019-12-02 07:10, Zenghui Yu wrote: > It looks like an obvious mistake to use its_mapc_cmd descriptor when > building the INVALL command block. It so far worked by luck because > both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset > of > the ITS command descriptor, but we should not rely on it. > > Signed-off-by: Zenghui Yu > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c > b/drivers/irqchip/irq-gic-v3-its.c > index c52cc8d6d6b8..b3fec78b2226 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -598,7 +598,7 @@ static struct its_collection > *its_build_invall_cmd(struct its_node *its, > struct its_cmd_desc *desc) > { > its_encode_cmd(cmd, GITS_CMD_INVALL); > - its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id); > + its_encode_collection(cmd, desc->its_invall_cmd.col->col_id); > > its_fixup_cmd(cmd); Yup, well spotted. Thankfully, there is no impact due to the two structures having similar layouts, but that definitely needs fixing. I'll queue this for post -rc1. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549B6C432C0 for ; Mon, 2 Dec 2019 10:00:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24FD4215E5 for ; Mon, 2 Dec 2019 10:00:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lgch5B5A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24FD4215E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QYgaVbKNTnJDPdlIVQvIY+jEe7XjwLjrKpPzogmTdag=; b=lgch5B5AAUvW5lrPU80/yvqae ideMZ8ju1nQdhMIHjVt/NTwHmny2qmCfuoBJE1LQyfhgg4NqtzNk9ZtPsXNXYKB+JaO2/92j2lwhI blJSqpKCpUsiR3wFsqFo97IacAAW8sn4FyHL50qRpa3wbjD7K0Trzl5OaT/gs8pdRcXfmWvtBliu0 KSlhrcNUyi2Ru5BcvjTg6uIrQKzNUAVLOM4tlZ7maUyT8NmnGhAtedQefJlOY9u1J3GDQcwdaeFFG dLYnvXzBFmOX6RsoGoSjKdXyg3mHJMfhKYRjjll6jkuyZuj3SC8doUDkGpRFU5EJHEy1JciUqMzR/ 5kq+rG81A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibiV9-000376-AD; Mon, 02 Dec 2019 10:00:19 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibiV3-0002yE-3A for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2019 10:00:14 +0000 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1ibiUy-0006FX-Mv; Mon, 02 Dec 2019 11:00:08 +0100 To: Zenghui Yu Subject: Re: [PATCH] irqchip/gic-v3-its: Reference to =?UTF-8?Q?its=5Finvall=5Fcmd=20descriptor=20when=20building=20INVALL?= X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Date: Mon, 02 Dec 2019 10:00:08 +0000 From: Marc Zyngier In-Reply-To: <20191202071021.1251-1-yuzenghui@huawei.com> References: <20191202071021.1251-1-yuzenghui@huawei.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_020013_282686_CEA14153 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wanghaibin.wang@huawei.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Zenghui, On 2019-12-02 07:10, Zenghui Yu wrote: > It looks like an obvious mistake to use its_mapc_cmd descriptor when > building the INVALL command block. It so far worked by luck because > both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset > of > the ITS command descriptor, but we should not rely on it. > > Signed-off-by: Zenghui Yu > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c > b/drivers/irqchip/irq-gic-v3-its.c > index c52cc8d6d6b8..b3fec78b2226 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -598,7 +598,7 @@ static struct its_collection > *its_build_invall_cmd(struct its_node *its, > struct its_cmd_desc *desc) > { > its_encode_cmd(cmd, GITS_CMD_INVALL); > - its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id); > + its_encode_collection(cmd, desc->its_invall_cmd.col->col_id); > > its_fixup_cmd(cmd); Yup, well spotted. Thankfully, there is no impact due to the two structures having similar layouts, but that definitely needs fixing. I'll queue this for post -rc1. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel