From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCHv6 12/33] net/dpaa2: introducing NXP dpaa2 pmd
	driver
Date: Tue, 24 Jan 2017 14:08:00 +0530
Message-ID: <f452ba9b-f857-7cf3-868b-6ae32f117abb@nxp.com>
References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
 <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com>
 <1485172803-17288-13-git-send-email-hemant.agrawal@nxp.com>
 <50aa7e34-3510-425a-ff21-d3ac9abf986f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, <dev@dpdk.org>,
 <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <john.mcnamara@intel.com>, <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0060.outbound.protection.outlook.com [104.47.33.60])
 by dpdk.org (Postfix) with ESMTP id D43A5108F
 for <dev@dpdk.org>; Tue, 24 Jan 2017 09:33:25 +0100 (CET)
In-Reply-To: <50aa7e34-3510-425a-ff21-d3ac9abf986f@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 23 January 2017 11:02 PM, Ferruh Yigit wrote:
> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
>> add support for fsl-mc bus based dpaa2 pmd driver.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
> <...>
>
>> diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile
>> new file mode 100644
>> index 0000000..f85aa9f
>> --- /dev/null
>> +++ b/drivers/net/dpaa2/Makefile
> <...>
>> +
>> +# library dependencies
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_eal lib/librte_ether
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_bus_fslmc
>
> Is this dependency correct?

I think yes.
- Without Bus, dpaa2 PMD wouldn't work and being a configurable option,
   user can set CONFIG_RTE_LIBRTE_DPAA2_PMD=n and
   CONFIG_RTE_LIBRTE_DPAA2_PMD=y.

- If you referring to whether lib/librte_bus_fslmc is correct or not, I
   have replied to your response on 16/33 patch. In short, I think this
   is correct assuming that librte_bus_fslmc is valid LIB name and not
   expected to be a folder in lib/

>
>> +
>> +include $(RTE_SDK)/mk/rte.lib.mk
>
> <...>
>