From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e98OZ-0003Ts-Dd for qemu-devel@nongnu.org; Mon, 30 Oct 2017 07:38:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e98OY-00019X-Gr for qemu-devel@nongnu.org; Mon, 30 Oct 2017 07:38:19 -0400 Received: from mel.act-europe.fr ([2a02:2ab8:224:1::a0a:d2]:37124 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e98OY-000190-9O for qemu-devel@nongnu.org; Mon, 30 Oct 2017 07:38:18 -0400 References: <28f27d84714abd1e85144a5679eaa3147f4ca023.1508885974.git.pisa@cmp.felk.cvut.cz> <35454964-58da-e9d1-f960-c7cff8a9e054@adacore.com> <201710292343.11885.pisa@cmp.felk.cvut.cz> <5a436a93-9538-e61b-32ef-4e92b5aad499@adacore.com> <1d51d638-6046-2f7a-890d-a9d1fd0889a7@denx.de> From: KONRAD Frederic Message-ID: Date: Mon, 30 Oct 2017 12:38:12 +0100 MIME-Version: 1.0 In-Reply-To: <1d51d638-6046-2f7a-890d-a9d1fd0889a7@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marek Vasut Cc: Pavel Pisa , qemu-devel@nongnu.org, Stefan Hajnoczi , Deniz Eren , Jan Kiszka , Oliver Hartkopp On 10/30/2017 11:51 AM, Marek Vasut wrote: > On 10/30/2017 10:19 AM, KONRAD Frederic wrote: > > [...] > >>> CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added. >>> hw/can/can_mioe3680_pci.c >>> >>> If you think that this is more logical even that the first >>> commits introduce something which cannot be tested/compiles >>> only into library, then I rearrange patchyes this way. >> >> I don't know all those PCI cards. But if the simple SJA1000 >> doesn't exist in real life maybe better dropping it? > SJA1000 is the only sensible card to emulate IMO, at least initially, > it's the de-facto standard for CAN devices. > > [...] > I was talking of "CAN bus simple SJA1000 memory mapped PCI card example" which according to Pavel is an example device with custom vendor/device ids? Thanks, Fred