Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Eyal Birger <eyal.birger@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values
Date: Mon, 30 Jul 2018 10:03:50 -0400	[thread overview]
Message-ID: <f455f493-c106-aa93-b92a-2aa94c969d31@mojatatu.com> (raw)
In-Reply-To: <951ad078ad4d5ee108abcd85189460aed7948634.1532934532.git.pabeni@redhat.com>

On 30/07/18 08:30 AM, Paolo Abeni wrote:
>   	}
>   
> +	if (!tcf_action_valid(a->tcfa_action)) {
> +		NL_SET_ERR_MSG(extack, "invalid action value, using TC_ACT_UNSPEC instead");
> +		a->tcfa_action = TC_ACT_UNSPEC;
> +	}
> +
>   	return a;
>   

I think it would make a lot more sense to just reject the entry than
changing it underneath the user to a default value. Least element of
suprise.

cheers,
jamal