From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44FAAC4338F for ; Fri, 23 Jul 2021 18:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2878160ED7 for ; Fri, 23 Jul 2021 18:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbhGWRVD (ORCPT ); Fri, 23 Jul 2021 13:21:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:53276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbhGWRVA (ORCPT ); Fri, 23 Jul 2021 13:21:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDB5C60ED7; Fri, 23 Jul 2021 18:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627063293; bh=VHCSeZJjKJsnsMZa5G6+nO2ertF1iyega0AIgFlXcHw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=lexpHC2Xb8ad3XL+3ndSXyTqZCBNVOupFseIarel+Mmw5OcSv9az58MqEnExtejJS 3kaAnuIaM57aLk4BVPWKP3Nnc8/z0ZjNlvJnmDc+4h0GnHvAgCvY3Ukm9JO4jkwjQI WMTA2GZxlWSQk/Ti4Q8xoYLzQEpHDiCZFfXanHEQDMOrtDhO4Q9KAgSyyemguNQD3m LEtDcaOqlFGMOr6ayPdTfwFtRT/2SvVwd/nbQ7i6HNGnnny1hqpLV+ldD8YekCDsA/ fGQABKNeLLQjj9N8RSi8lbmw54ozHRvSp3dk2+pxKS7a9nV+2PSYgt1S1PpwhObLzs NkrLFmd/gCYVw== Message-ID: Subject: Re: [PATCH] fscrypt: align Base64 encoding with RFC 4648 base64url From: Jeff Layton To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Hannes Reinecke Date: Fri, 23 Jul 2021 14:01:31 -0400 In-Reply-To: References: <20210718000125.59701-1-ebiggers@kernel.org> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Fri, 2021-07-23 at 01:16 -0700, Eric Biggers wrote: > On Sat, Jul 17, 2021 at 07:01:25PM -0500, Eric Biggers wrote: > > > > There have been two attempts to copy the fscrypt Base64 code into lib/ > > (https://lkml.kernel.org/r/20200821182813.52570-6-jlayton@kernel.org and > > https://lkml.kernel.org/r/20210716110428.9727-5-hare@suse.de), and both > > have been caught up by the fscrypt Base64 variant being nonstandard and > > not properly documented. Also, the planned use of the fscrypt Base64 > > code in the CephFS storage back-end will prevent it from being changed > > later (whereas currently it can still be changed), so we need to choose > > an encoding that we're happy with before it's too late. > > Jeff, any thoughts on whether this is the variant of Base64 you want to use in > the CephFS fscrypt support? > I can't do a deep review today, but this looks fine at first glance. We're not too particular about what sort of encoding we use for ceph. We just need something that is consistent and results in valid POSIX filenames. Changing it to better adhere to the standard sounds like a good thing to do. Thanks, -- Jeff Layton