From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023C2C433E1 for ; Thu, 13 Aug 2020 17:35:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A41432078D for ; Thu, 13 Aug 2020 17:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="OwPFACB8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A41432078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6H8P-0006JF-3D; Thu, 13 Aug 2020 17:35:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6H8N-0006JA-Vb for xen-devel@lists.xenproject.org; Thu, 13 Aug 2020 17:35:24 +0000 X-Inumbo-ID: ee74fd6b-2ee9-4720-b55d-56bcd18ab007 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee74fd6b-2ee9-4720-b55d-56bcd18ab007; Thu, 13 Aug 2020 17:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Q9EPBMPpic/bSkkL9+3L70HRPIx2u2FUqgf9Dws360M=; b=OwPFACB8fQ4f+uHKY1PjCoUSMq 7symAX04j2oWu0SP1gHrj02ZzVMUIsB838dQN9UKzTeseCsziAlcA7L6LNqY6ptvseDgrIi6V22BW hgA4AcggkbbaZFwp3OnOj5lpcuDHDiHMQkxOPcBuaE+KpMh5Vn1wmBObj3lArFOrpQ6E=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6H8I-0007PS-7J; Thu, 13 Aug 2020 17:35:18 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k6H8H-0003Kk-SI; Thu, 13 Aug 2020 17:35:18 +0000 Subject: Re: [PATCH v3] xen/arm: Convert runstate address during hypcall To: Bertrand Marquis Cc: Xen-devel , nd , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <3911d221ce9ed73611b93aa437b9ca227d6aa201.1596099067.git.bertrand.marquis@arm.com> From: Julien Grall Message-ID: Date: Thu, 13 Aug 2020 18:35:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Bertrand, On 31/07/2020 14:26, Bertrand Marquis wrote: >>> + { >>> + gprintk(XENLOG_WARNING, "Cannot map runstate pointer at 0x%"PRIvaddr >>> + ": Invalid offset\n", vaddr); >> >> We usually enforce 80 character per lines except for format string. So it is easier to grep them in the code. > > Ok i will fix this one and the following ones. > But here PRIvaddr would break any attempt to grep something in fact. The idea is you can grep a few words on the message and then easily find the line. Cheers, -- Julien Grall