From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkYyk-00061R-Nl for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:53:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkYyf-0007FB-Hh for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:53:33 -0400 References: <1471625435-6190-1-git-send-email-kwolf@redhat.com> <1471625435-6190-6-git-send-email-kwolf@redhat.com> <0c1387e5-4228-da71-1cff-d715e2853006@redhat.com> <20160915083716.GB4726@noname.redhat.com> From: Eric Blake Message-ID: Date: Thu, 15 Sep 2016 10:53:18 -0500 MIME-Version: 1.0 In-Reply-To: <20160915083716.GB4726@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GJvmFJ1isKrcprWrEwT2oxH47bbTBICUJ" Subject: Re: [Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GJvmFJ1isKrcprWrEwT2oxH47bbTBICUJ From: Eric Blake To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium References: <1471625435-6190-1-git-send-email-kwolf@redhat.com> <1471625435-6190-6-git-send-email-kwolf@redhat.com> <0c1387e5-4228-da71-1cff-d715e2853006@redhat.com> <20160915083716.GB4726@noname.redhat.com> In-Reply-To: <20160915083716.GB4726@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/2016 03:37 AM, Kevin Wolf wrote: > Am 14.09.2016 um 22:57 hat Eric Blake geschrieben: >> On 08/19/2016 11:50 AM, Kevin Wolf wrote: >>> In order to remove the necessity to use BlockBackend names in the >>> external API, we want to allow qdev device names in all device relate= d >>> commands. >>> >>> This converts x-blockdev-insert-medium to accept a qdev device name. >> >> Since this command is experimental... >> >>> Signed-off-by: Kevin Wolf >>> --- >> >>> +++ b/qapi/block-core.json >>> @@ -2380,14 +2380,17 @@ >>> # This command is still a work in progress and is considered experim= ental. >>> # Stay away from it unless you want to help with its development. >>> # >>> -# @device: block device name >>> +# @device: block device name (deprecated, use @id instead) >>> +# >>> +# @id: the name or QOM path of the guest device (since: 2.8) >> >> ...why even bother to deprecate 'device'? Can't we just do a whole-sa= le >> switch to a required 'id' only? Or should such a wholesale switch be >> reserved for the day that we remove the x- prefix when promoting the >> command to stable? >=20 > I tried this for the experimental commands, but I think it required som= e > more test case rewrites, so I decided to leave it for later. Not > necessarily "when promoting to stable" later, but a separate series > anyway. Fair enough. Maybe mention it in the commit message, or even in a comment that part of promoting to stable may include removing the 'driver' parameter. That way, we won't forget the discussion. But in the meantime, the conversion looks sane, so I'm okay with adding: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GJvmFJ1isKrcprWrEwT2oxH47bbTBICUJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2sPuAAoJEKeha0olJ0NqT1cH/ivSNDQl3FpfjN7ad2KkOxm5 j07hn3sI4NOz0RXoLiPVBKRsAyAUn3Y6HNdRWHPOEuDzgzTotKcmL381qgW+EK4g GcvRo7+PBWd9yVXHXhkN9r7VXeLGZ7IopTkJBqAF6TDlTQXoeuRMuXhKzFIgQZ+D uz4ymLOXh2JDSz7hPl8WJGTmfG10ic42WuD5czGyoHz95sLJn+yMCdTSI7xj1vN7 Mclt8r6yFmZDyZW73D5VgXhCIHpSj44NVZJQqhUNNXhIOGHHZoepT/eVzutgXnGg RkV+cELqYpj9rXrM61zL0+kQy/MYU/ewkN2z7fIxA0pezfmIJXWIEQ7alXgfhEY= =I/OY -----END PGP SIGNATURE----- --GJvmFJ1isKrcprWrEwT2oxH47bbTBICUJ--