From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F4EC07E96 for ; Thu, 8 Jul 2021 11:44:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DA486161F for ; Thu, 8 Jul 2021 11:43:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DA486161F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eyet-services.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D35D583168; Thu, 8 Jul 2021 13:43:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=eyet-services.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 919318316B; Thu, 8 Jul 2021 13:43:55 +0200 (CEST) Received: from crocodile.elm.relay.mailchannels.net (crocodile.elm.relay.mailchannels.net [23.83.212.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5908683168 for ; Thu, 8 Jul 2021 13:43:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=eyet-services.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jaeckel-floss@eyet-services.de X-Sender-Id: instrampxe0y3a|x-authuser|jaeckel@eyet-services.de Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1B962540101; Thu, 8 Jul 2021 11:43:49 +0000 (UTC) Received: from cpanel-004-fra.hostingww.com (100-96-133-125.trex.outbound.svc.cluster.local [100.96.133.125]) (Authenticated sender: instrampxe0y3a) by relay.mailchannels.net (Postfix) with ESMTPA id E4C48541799; Thu, 8 Jul 2021 11:43:45 +0000 (UTC) X-Sender-Id: instrampxe0y3a|x-authuser|jaeckel@eyet-services.de Received: from cpanel-004-fra.hostingww.com (ec2-18-198-100-52.eu-central-1.compute.amazonaws.com [18.198.100.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.125 (trex/6.3.3); Thu, 08 Jul 2021 11:43:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: instrampxe0y3a|x-authuser|jaeckel@eyet-services.de X-MailChannels-Auth-Id: instrampxe0y3a X-Spicy-Spill: 087e4f5f36610c8f_1625744628756_219339752 X-MC-Loop-Signature: 1625744628756:2945596419 X-MC-Ingress-Time: 1625744628756 Received: from tmo-098-152.customers.d1-online.com ([80.187.98.152]:23791 helo=[192.168.43.23]) by cpanel-004-fra.hostingww.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1m1SRR-0005WA-RT; Thu, 08 Jul 2021 11:43:44 +0000 Subject: Re: [PATCH v4 1/8] lib: add crypt subsystem To: hs@denx.de, u-boot@lists.denx.de Cc: Simon Glass , Alexandru Gagniuc , Anastasiia Lukianenko , Andrii Anisov , Aswath Govindraju , Bin Meng , Christian Gmeiner , Heinrich Schuchardt , Joel Stanley , Marek Szyprowski , Masahisa Kojima , Patrick Delaunay , Sean Anderson , Tero Kristo References: <20210707230946.2497660-1-jaeckel-floss@eyet-services.de> <20210707230946.2497660-2-jaeckel-floss@eyet-services.de> <83de7556-8766-b320-b1d0-7f76f96201a4@denx.de> From: Steffen Jaeckel Message-ID: Date: Thu, 8 Jul 2021 13:43:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <83de7556-8766-b320-b1d0-7f76f96201a4@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.0 X-AuthUser: jaeckel@eyet-services.de X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heiko, thanks for the review! On 7/8/21 5:56 AM, Heiko Schocher wrote: > [...] > >> diff --git a/lib/crypt/Makefile b/lib/crypt/Makefile >> new file mode 100644 >> index 0000000000..290231064c >> --- /dev/null >> +++ b/lib/crypt/Makefile >> @@ -0,0 +1,10 @@ >> +# SPDX-License-Identifier: GPL-2.0+ >> +# >> +# Copyright (c) 2013, Google Inc. >> +# >> +# (C) Copyright 2000-2007 >> +# Wolfgang Denk, DENX Software Engineering, wd@denx.de. > > Hmm... this is a new file ... I think you should add > only your Copyright and drop the others... ? thx, done > [...] > > I miss here the SPDX license identifier... also some hint, from which > exact version this code is from ... I've added this info in the next commit, this contains the vanilla version. Is this ok? Cheers, Steffen