All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
	aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com,
	npiggin@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] powerpc/mm: page fault handler cleaning
Date: Thu, 2 Mar 2017 13:30:38 +0100	[thread overview]
Message-ID: <f4693d88-9142-dfd5-4182-9921e67c1c2c@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1487090656.git.ldufour@linux.vnet.ibm.com>

Kindly ping...

On 14/02/2017 17:45, Laurent Dufour wrote:
> This series attempts to clean the page fault handler in the way it has
> been done previously for the x86 architecture [1].
> 
> The goal is to manage the mmap_sem earlier and only in
> do_page_fault(). This done by handling the retry case earlier, before
> handling the error case.  This way the semaphore can be released
> earlier and the error path processed without holding it.
> 
> The first patch is just moving a unlock to the caller of the service,
> which as no functional impact.
> 
> The second patch is handling the retry case earlier in
> do_page_fault(). This is where most the change are done, but I was
> conservative here, not changing the use of mm_fault_error() in the
> case of the second retry. It may be smarter to handle that case
> separately but this may create duplicate code.
> 
> The last patch is moving up semaphore releasing from mm_fault_error()
> to do_page_fault().
> 
> [1] see commits from Linus Torvalds
>  26178ec11ef3 ("x86: mm: consolidate VM_FAULT_RETRY handling")
>  7fb08eca4527 ("x86: mm: move mmap_sem unlock from mm_fault_error() to
> caller")
> 
> Laurent Dufour (3):
>   powerpc/mm: move mmap_sem unlock up from do_sigbus
>   powerpc/mm: handle VM_FAULT_RETRY earlier
>   powerpc/mm: move mmap_sem unlocking in do_page_fault()
> 
>  arch/powerpc/mm/fault.c | 82 ++++++++++++++++++++++++-------------------------
>  1 file changed, 40 insertions(+), 42 deletions(-)
> 

  parent reply	other threads:[~2017-03-02 12:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 16:45 [PATCH 0/3] powerpc/mm: page fault handler cleaning Laurent Dufour
2017-02-14 16:45 ` [PATCH 1/3] powerpc/mm: move mmap_sem unlock up from do_sigbus Laurent Dufour
2017-03-21  8:39   ` Aneesh Kumar K.V
2017-03-21 11:36   ` [1/3] " Michael Ellerman
2017-02-14 16:45 ` [PATCH 2/3] powerpc/mm: handle VM_FAULT_RETRY earlier Laurent Dufour
2017-03-21  9:12   ` Aneesh Kumar K.V
2017-03-21  9:57     ` Laurent Dufour
2017-02-14 16:45 ` [PATCH 3/3] powerpc/mm: move mmap_sem unlocking in do_page_fault() Laurent Dufour
2017-03-21  9:12   ` Aneesh Kumar K.V
2017-03-02 12:30 ` Laurent Dufour [this message]
2017-03-03 12:17   ` [PATCH 0/3] powerpc/mm: page fault handler cleaning Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4693d88-9142-dfd5-4182-9921e67c1c2c@linux.vnet.ibm.com \
    --to=ldufour@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.