From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DF4C433ED for ; Tue, 11 May 2021 03:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70F6D61584 for ; Tue, 11 May 2021 03:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbhEKDOP (ORCPT ); Mon, 10 May 2021 23:14:15 -0400 Received: from mga07.intel.com ([134.134.136.100]:26066 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhEKDOH (ORCPT ); Mon, 10 May 2021 23:14:07 -0400 IronPort-SDR: KkcvMG3ElJBVcXePNnIfJLlIiB3QmYdqp6Uysg1y7FTtFHOz5e6kNNsnHDKbgLEj6mO7XF9EN6 Q0yOgf3A6kTw== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="263273556" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="263273556" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 20:12:58 -0700 IronPort-SDR: stKccw6CyTiwgY6Z4oynDLYVZ9iolDqy5GJI2whakNs9xp75faAiZ3QlNCdDdLhdiWlAPMdVj9 pZkA/PEv8pfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="621641217" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga006.fm.intel.com with ESMTP; 10 May 2021 20:12:52 -0700 Cc: baolu.lu@linux.intel.com, Alex Williamson , Kirti Wankhede , Cornelia Huck , Jonathan Cameron , wanghaibin.wang@huawei.com, jiangkunkun@huawei.com, yuzenghui@huawei.com, lushenming@huawei.com Subject: Re: [RFC PATCH v4 01/13] iommu: Introduce dirty log tracking framework To: Keqian Zhu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Robin Murphy , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Yi Sun , Tian Kevin References: <20210507102211.8836-1-zhukeqian1@huawei.com> <20210507102211.8836-2-zhukeqian1@huawei.com> <18ac787a-179e-71f7-728b-c43feda80a16@huawei.com> <55fda826-9ab6-a3a0-b17e-a4d4879f00bc@linux.intel.com> From: Lu Baolu Message-ID: Date: Tue, 11 May 2021 11:12:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Keqian, On 5/10/21 7:07 PM, Keqian Zhu wrote: >>>> I suppose this interface is to ask the vendor IOMMU driver to check >>>> whether each device/iommu in the domain supports dirty bit tracking. >>>> But what will happen if new devices with different tracking capability >>>> are added afterward? >>> Yep, this is considered in the vfio part. We will query again after attaching or >>> detaching devices from the domain. When the domain becomes capable, we enable >>> dirty log for it. When it becomes not capable, we disable dirty log for it. >> If that's the case, why not putting this logic in the iommu subsystem so >> that it doesn't need to be duplicate in different upper layers? >> >> For example, add something like dirty_page_trackable in the struct of >> iommu_domain and ask the vendor iommu driver to update it once any >> device is added/removed to/from the domain. It's also better to disallow > If we do it, the upper layer still needs to query the capability from domain and switch > dirty log tracking for it. Or do you mean the domain can switch dirty log tracking automatically > when its capability change? If so, I think we're lack of some flexibility. The upper layer > may have it's own policy, such as only enable dirty log tracking when all domains are capable, > and disable dirty log tracking when just one domain is not capable. I may not get you. Assume that dirty_page_trackable is an attribution of an iommu_domain. This attribution might be changed once a new device (with different capability) added or removed. So it should be updated every time a new device is attached or detached. This work could be done by the vendor iommu driver on the path of dev_attach/dev_detach callback. For upper layers, before starting page tracking, they check the dirty_page_trackable attribution of the domain and start it only it's capable. Once the page tracking is switched on the vendor iommu driver (or iommu core) should block further device attach/detach operations until page tracking is stopped. > >> any domain attach/detach once the dirty page tracking is on. > Yep, this can greatly simplify our code logic, but I don't know whether our maintainers > agree that, as they may think that IOMMU dirty logging should not change original domain > behaviors. The maintainer owns the last word, but we need to work out a generic and self-contained API set. Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8827FC433ED for ; Tue, 11 May 2021 03:13:03 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C320D61584 for ; Tue, 11 May 2021 03:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C320D61584 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6E5D240242; Tue, 11 May 2021 03:13:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LnKwPAfo4o7v; Tue, 11 May 2021 03:13:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTP id 63B3640247; Tue, 11 May 2021 03:13:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 26C71C000E; Tue, 11 May 2021 03:13:01 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7F10AC0001 for ; Tue, 11 May 2021 03:12:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5893A60C26 for ; Tue, 11 May 2021 03:12:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gfjEproOV-uW for ; Tue, 11 May 2021 03:12:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by smtp3.osuosl.org (Postfix) with ESMTPS id A7E47607CD for ; Tue, 11 May 2021 03:12:58 +0000 (UTC) IronPort-SDR: 3cyOWrTT0HCcwm+642iRtCpXrz8g6vMGHfg5UYT0AKWNaq2Wx3C1f9Mm1DqRScfdiaDNWTkveq Xw89WeDpbYBA== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="220296997" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="220296997" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 20:12:57 -0700 IronPort-SDR: stKccw6CyTiwgY6Z4oynDLYVZ9iolDqy5GJI2whakNs9xp75faAiZ3QlNCdDdLhdiWlAPMdVj9 pZkA/PEv8pfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="621641217" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga006.fm.intel.com with ESMTP; 10 May 2021 20:12:52 -0700 Subject: Re: [RFC PATCH v4 01/13] iommu: Introduce dirty log tracking framework To: Keqian Zhu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Robin Murphy , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Yi Sun , Tian Kevin References: <20210507102211.8836-1-zhukeqian1@huawei.com> <20210507102211.8836-2-zhukeqian1@huawei.com> <18ac787a-179e-71f7-728b-c43feda80a16@huawei.com> <55fda826-9ab6-a3a0-b17e-a4d4879f00bc@linux.intel.com> From: Lu Baolu Message-ID: Date: Tue, 11 May 2021 11:12:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: jiangkunkun@huawei.com, Cornelia Huck , Kirti Wankhede , lushenming@huawei.com, Alex Williamson , wanghaibin.wang@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Keqian, On 5/10/21 7:07 PM, Keqian Zhu wrote: >>>> I suppose this interface is to ask the vendor IOMMU driver to check >>>> whether each device/iommu in the domain supports dirty bit tracking. >>>> But what will happen if new devices with different tracking capability >>>> are added afterward? >>> Yep, this is considered in the vfio part. We will query again after attaching or >>> detaching devices from the domain. When the domain becomes capable, we enable >>> dirty log for it. When it becomes not capable, we disable dirty log for it. >> If that's the case, why not putting this logic in the iommu subsystem so >> that it doesn't need to be duplicate in different upper layers? >> >> For example, add something like dirty_page_trackable in the struct of >> iommu_domain and ask the vendor iommu driver to update it once any >> device is added/removed to/from the domain. It's also better to disallow > If we do it, the upper layer still needs to query the capability from domain and switch > dirty log tracking for it. Or do you mean the domain can switch dirty log tracking automatically > when its capability change? If so, I think we're lack of some flexibility. The upper layer > may have it's own policy, such as only enable dirty log tracking when all domains are capable, > and disable dirty log tracking when just one domain is not capable. I may not get you. Assume that dirty_page_trackable is an attribution of an iommu_domain. This attribution might be changed once a new device (with different capability) added or removed. So it should be updated every time a new device is attached or detached. This work could be done by the vendor iommu driver on the path of dev_attach/dev_detach callback. For upper layers, before starting page tracking, they check the dirty_page_trackable attribution of the domain and start it only it's capable. Once the page tracking is switched on the vendor iommu driver (or iommu core) should block further device attach/detach operations until page tracking is stopped. > >> any domain attach/detach once the dirty page tracking is on. > Yep, this can greatly simplify our code logic, but I don't know whether our maintainers > agree that, as they may think that IOMMU dirty logging should not change original domain > behaviors. The maintainer owns the last word, but we need to work out a generic and self-contained API set. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44126C433B4 for ; Tue, 11 May 2021 10:17:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EBAB61933 for ; Tue, 11 May 2021 10:17:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EBAB61933 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Cc:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yLQ3ysoKaxwbaBBpZA+Bo2/Xsf3Ql5UKrL9cHlXBTjY=; b=K8EizfOk9in2mtNiBd6PK7SJp KZ+T/nYrlt68kYPKmOIZVmhyPEPsOSupqZI4b00QZvGa/rHUBpX6M8U+hIMhT003uxbBR/3oo/lum o05MtB9Z0x6M1FxHuC2oNCqTVBvq5NQe20DO0Cs9Q217OX2C7Mbxp5hjUZUhMQcpSuIop5ldTRweG 0Jz764QafJcjzxDQvlxlU57svI6i3NfMFEJ6O9hed+xEafp0SoZGAuyjnF22pGmzi/Y/J8ZwYqV/f 35CIBLbLGf3kordOBYU297jbZxlBtC84l2O+d2viRxN+6T4jLE0jULeC3t0EeREeH6ToGD5HWXoDk 4wKssh0TA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgPRO-00GsRi-5k; Tue, 11 May 2021 10:16:38 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgIrX-00GA8f-LQ for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 03:15:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Cc:Sender:Reply-To:Content-ID:Content-Description; bh=T1Zh+KaIVloHUwlMn11aU398M9gcDjwJj8gQ9h+O+2Y=; b=QSsQxwoz5XvjjFjy4QcSONXlEu GbiC+dcSRb6Cx3a0Y/HqOEjozMDbdubOWNaU2HVesSJ1aHXSdIC02VZXdwclWAHwUPe/8LaON9ULQ z8sJediIzoeGYTbgaD7A62VXVj5+I7PT0pXvYoHi9CEjndtK8gFqvzEoERC7pmDUE7Up9JF5KJb8s KxuW7Ttm51w7kYL20hnpsFkLcKo5k5fg1tlFoGJ9dzDH9A2PX/xo+nMkTZ8OQfDZBHoXSKYZvEuyx RjD37LZnmoaF3B1xfpNUeA4dvny3um5R2TWvl7JlKo8n7BI7uRjxwlObnAL1LdKW24c91a8iQ+oUW FUYDrKHA==; Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgIrN-009H53-Sy for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 03:15:03 +0000 IronPort-SDR: FJpqFGBA5wTc4rrYoDYeV3aKCO60VyFUdUtZsuedDaW0xPqgDhRyrafdmn5hz4BeXDVym9RgHA ksys6jMRVFgQ== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="197360005" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="197360005" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 20:12:57 -0700 IronPort-SDR: stKccw6CyTiwgY6Z4oynDLYVZ9iolDqy5GJI2whakNs9xp75faAiZ3QlNCdDdLhdiWlAPMdVj9 pZkA/PEv8pfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="621641217" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga006.fm.intel.com with ESMTP; 10 May 2021 20:12:52 -0700 Cc: baolu.lu@linux.intel.com, Alex Williamson , Kirti Wankhede , Cornelia Huck , Jonathan Cameron , wanghaibin.wang@huawei.com, jiangkunkun@huawei.com, yuzenghui@huawei.com, lushenming@huawei.com Subject: Re: [RFC PATCH v4 01/13] iommu: Introduce dirty log tracking framework To: Keqian Zhu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Robin Murphy , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Yi Sun , Tian Kevin References: <20210507102211.8836-1-zhukeqian1@huawei.com> <20210507102211.8836-2-zhukeqian1@huawei.com> <18ac787a-179e-71f7-728b-c43feda80a16@huawei.com> <55fda826-9ab6-a3a0-b17e-a4d4879f00bc@linux.intel.com> From: Lu Baolu Message-ID: Date: Tue, 11 May 2021 11:12:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_201501_983059_D4E586B2 X-CRM114-Status: GOOD ( 20.48 ) /bin/ln: failed to access 'reaver_cache/texts/20210510_201501_983059_D4E586B2': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_201501_983059_D4E586B2 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Keqian, On 5/10/21 7:07 PM, Keqian Zhu wrote: >>>> I suppose this interface is to ask the vendor IOMMU driver to check >>>> whether each device/iommu in the domain supports dirty bit tracking. >>>> But what will happen if new devices with different tracking capability >>>> are added afterward? >>> Yep, this is considered in the vfio part. We will query again after attaching or >>> detaching devices from the domain. When the domain becomes capable, we enable >>> dirty log for it. When it becomes not capable, we disable dirty log for it. >> If that's the case, why not putting this logic in the iommu subsystem so >> that it doesn't need to be duplicate in different upper layers? >> >> For example, add something like dirty_page_trackable in the struct of >> iommu_domain and ask the vendor iommu driver to update it once any >> device is added/removed to/from the domain. It's also better to disallow > If we do it, the upper layer still needs to query the capability from domain and switch > dirty log tracking for it. Or do you mean the domain can switch dirty log tracking automatically > when its capability change? If so, I think we're lack of some flexibility. The upper layer > may have it's own policy, such as only enable dirty log tracking when all domains are capable, > and disable dirty log tracking when just one domain is not capable. I may not get you. Assume that dirty_page_trackable is an attribution of an iommu_domain. This attribution might be changed once a new device (with different capability) added or removed. So it should be updated every time a new device is attached or detached. This work could be done by the vendor iommu driver on the path of dev_attach/dev_detach callback. For upper layers, before starting page tracking, they check the dirty_page_trackable attribution of the domain and start it only it's capable. Once the page tracking is switched on the vendor iommu driver (or iommu core) should block further device attach/detach operations until page tracking is stopped. > >> any domain attach/detach once the dirty page tracking is on. > Yep, this can greatly simplify our code logic, but I don't know whether our maintainers > agree that, as they may think that IOMMU dirty logging should not change original domain > behaviors. The maintainer owns the last word, but we need to work out a generic and self-contained API set. Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel