All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] netfilter: conntrack: remove the repeated declaration
@ 2021-05-29  6:49 Shaokun Zhang
  2021-05-29 14:12 ` Florian Westphal
  2021-06-02 10:40 ` Pablo Neira Ayuso
  0 siblings, 2 replies; 4+ messages in thread
From: Shaokun Zhang @ 2021-05-29  6:49 UTC (permalink / raw)
  To: netfilter-devel, coreteam
  Cc: Shaokun Zhang, Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal

Variable 'nf_conntrack_net_id' is declared twice, so remove the
repeated declaration.

Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 net/netfilter/nf_conntrack_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index e0befcf8113a..757520725cd4 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -87,8 +87,6 @@ static __read_mostly bool nf_conntrack_locks_all;
 
 static struct conntrack_gc_work conntrack_gc_work;
 
-extern unsigned int nf_conntrack_net_id;
-
 void nf_conntrack_lock(spinlock_t *lock) __acquires(lock)
 {
 	/* 1) Acquire the lock */
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: conntrack: remove the repeated declaration
  2021-05-29  6:49 [PATCH] netfilter: conntrack: remove the repeated declaration Shaokun Zhang
@ 2021-05-29 14:12 ` Florian Westphal
  2021-06-02 10:40 ` Pablo Neira Ayuso
  1 sibling, 0 replies; 4+ messages in thread
From: Florian Westphal @ 2021-05-29 14:12 UTC (permalink / raw)
  To: Shaokun Zhang
  Cc: netfilter-devel, coreteam, Pablo Neira Ayuso, Jozsef Kadlecsik,
	Florian Westphal

Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
> Variable 'nf_conntrack_net_id' is declared twice, so remove the
> repeated declaration.

Reviewed-by: Florian Westphal <fw@strlen.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: conntrack: remove the repeated declaration
  2021-05-29  6:49 [PATCH] netfilter: conntrack: remove the repeated declaration Shaokun Zhang
  2021-05-29 14:12 ` Florian Westphal
@ 2021-06-02 10:40 ` Pablo Neira Ayuso
  2021-06-03  0:35   ` Shaokun Zhang
  1 sibling, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2021-06-02 10:40 UTC (permalink / raw)
  To: Shaokun Zhang
  Cc: netfilter-devel, coreteam, Jozsef Kadlecsik, Florian Westphal

Hi,

On Sat, May 29, 2021 at 02:49:26PM +0800, Shaokun Zhang wrote:
> Variable 'nf_conntrack_net_id' is declared twice, so remove the
> repeated declaration.

Thanks for your patch.

I prefer to fix this in nf-next with this patch I'm proposing:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210602103907.8082-1-pablo@netfilter.org/

> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: Florian Westphal <fw@strlen.de>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  net/netfilter/nf_conntrack_core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> index e0befcf8113a..757520725cd4 100644
> --- a/net/netfilter/nf_conntrack_core.c
> +++ b/net/netfilter/nf_conntrack_core.c
> @@ -87,8 +87,6 @@ static __read_mostly bool nf_conntrack_locks_all;
>  
>  static struct conntrack_gc_work conntrack_gc_work;
>  
> -extern unsigned int nf_conntrack_net_id;
> -
>  void nf_conntrack_lock(spinlock_t *lock) __acquires(lock)
>  {
>  	/* 1) Acquire the lock */
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: conntrack: remove the repeated declaration
  2021-06-02 10:40 ` Pablo Neira Ayuso
@ 2021-06-03  0:35   ` Shaokun Zhang
  0 siblings, 0 replies; 4+ messages in thread
From: Shaokun Zhang @ 2021-06-03  0:35 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: netfilter-devel, coreteam, Jozsef Kadlecsik, Florian Westphal

Hi,

On 2021/6/2 18:40, Pablo Neira Ayuso wrote:
> Hi,
> 
> On Sat, May 29, 2021 at 02:49:26PM +0800, Shaokun Zhang wrote:
>> Variable 'nf_conntrack_net_id' is declared twice, so remove the
>> repeated declaration.
> 
> Thanks for your patch.
> 
> I prefer to fix this in nf-next with this patch I'm proposing:
> 

Look fine to me.

Thanks your reply,
Shaokun

> https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210602103907.8082-1-pablo@netfilter.org/
> 
>> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
>> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
>> Cc: Florian Westphal <fw@strlen.de>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  net/netfilter/nf_conntrack_core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
>> index e0befcf8113a..757520725cd4 100644
>> --- a/net/netfilter/nf_conntrack_core.c
>> +++ b/net/netfilter/nf_conntrack_core.c
>> @@ -87,8 +87,6 @@ static __read_mostly bool nf_conntrack_locks_all;
>>  
>>  static struct conntrack_gc_work conntrack_gc_work;
>>  
>> -extern unsigned int nf_conntrack_net_id;
>> -
>>  void nf_conntrack_lock(spinlock_t *lock) __acquires(lock)
>>  {
>>  	/* 1) Acquire the lock */
>> -- 
>> 2.7.4
>>
> .
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03  0:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29  6:49 [PATCH] netfilter: conntrack: remove the repeated declaration Shaokun Zhang
2021-05-29 14:12 ` Florian Westphal
2021-06-02 10:40 ` Pablo Neira Ayuso
2021-06-03  0:35   ` Shaokun Zhang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.