From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0ADFC4361B for ; Mon, 7 Dec 2020 08:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99E5522ADF for ; Mon, 7 Dec 2020 08:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725832AbgLGISV (ORCPT ); Mon, 7 Dec 2020 03:18:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:42302 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725905AbgLGISV (ORCPT ); Mon, 7 Dec 2020 03:18:21 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2BCEAD71; Mon, 7 Dec 2020 08:17:38 +0000 (UTC) Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Mon, 7 Dec 2020 09:17:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E3lrt3AO1UboYAcLRO95c4R22Ins7taIx" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: multipart/mixed; boundary="OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > Fix a few W=3D1 warnings about unused assignments. > Drop the unused error code. >=20 > v2: > - Subject updated (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Qilong Zhang > Cc: "Alexander A. Klimov" > Cc: Daniel Vetter > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > index 726c190862d4..e6363a420933 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config acore; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > =20 > /* Audio clock regeneration settings */ > acore.n =3D n; > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > index eda29d3032e1..cb63bc0e92ca 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config core_cfg; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > core_cfg.n =3D n; > core_cfg.cts =3D cts; > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9-- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/N5SAFAwAAAAAACgkQlh/E3EQov+Bw rg/+LR5m0fPa5U9oIwT4rwsKunaIejtxjKhv4yTaKVPunhtVb87Jqt+IqwsZ52d5O2enBQb43e3V fZQT55Mrk6m0m7mLG/lhk27hLemh4wSRgVJ0ZEg3YmQzTZZWQdupqbTJE7bcUJdwx8zIUcmzI1po 5trUyBPf46eRTNliM5Vc244dtzFgPgfuLBXZu/dCq8Zzn9Qxh757mW4HjMYMspJoaWNbgD8LvEsN LCU2Nk+1Ew7qY27KDzGOrfZllPIUnDgWqni8Ej5zCTuCMzvZXGV5wcbX9KzzjxV2KRkxByE/rivI 3/bGCRDkU8zda578ct2LHXr+8Fg/aoRxs6j1mxHylRDNHaMYG8ZHuQRY84PdOf/fcboIw3yr2ptH Sirs1DQo+tLuG86Z45W5uZkQQdWWkPmtv7LJDeHIUkMRKpN3OFM7YRVt/SdsB0lcIq306nd/mqk4 F/BfLqrs/KmDFnlpJOXYE0XXziSbK23CG2r/MZ/nUu+wMqa0gl6Ey9ZudSBYRAwZteFJ/nfelbvk vbx/2Mq8qN1WBRF6Rz4/YdTNSTrVg/tK45CFfBZzCiwGxoszbKzeg9/W8l229XJDx2q7B7+vsbqK uJDg97WCP4M4YssswkEdMf4GkaLsdva9ah2EiMkVB6fsOWMzQ7WlTuJ2Qow5yNgaG2ZyvldkV+H0 /to= =vrgS -----END PGP SIGNATURE----- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44309C433FE for ; Mon, 7 Dec 2020 08:19:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7222229C6 for ; Mon, 7 Dec 2020 08:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7222229C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XuQGnnjnAbO6tBjSKi4Rx9JN3Wr9cQhnry/RYMYZwkY=; b=ULAb122/gqGLLJ+p9KIdyLQVj LkzVgWTax8pBSP5yLsEE8y+wQz11cMz9SafOLDTjbLbIKw5khf/LrkA/LVVqH1+dxmTJqJFxu9w/M GqQrhYUyoTD4YNFxcDW390rT3rBHBKXZQUq2rAktcnk6gCUZdrkZ4K2H9ZBHcKZe4a+xA7n9kSKtj Vu+91w07axYOsq4GAl0savHQPt2uEr5tNDpsQBBgI33TbJp1csFseA8OytoHSb+7C1CWt0ISG8er7 weI/c14ZP5azPmYfuXlY6syI2qtGDkzWr2AOwfNjqfCIHF79PLhSaD8sP6/nHp6ngRojiyPmroEpa aghcWfVhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmBiK-0000wt-3H; Mon, 07 Dec 2020 08:17:44 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmBiG-0000vP-4A for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 08:17:41 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2BCEAD71; Mon, 7 Dec 2020 08:17:38 +0000 (UTC) Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Mon, 7 Dec 2020 09:17:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_031740_450178_32027A31 X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Geert Uytterhoeven , Michael Ellerman , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Content-Type: multipart/mixed; boundary="===============2388049874901601317==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2388049874901601317== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E3lrt3AO1UboYAcLRO95c4R22Ins7taIx" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: multipart/mixed; boundary="OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > Fix a few W=3D1 warnings about unused assignments. > Drop the unused error code. >=20 > v2: > - Subject updated (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Qilong Zhang > Cc: "Alexander A. Klimov" > Cc: Daniel Vetter > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > index 726c190862d4..e6363a420933 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config acore; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > =20 > /* Audio clock regeneration settings */ > acore.n =3D n; > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > index eda29d3032e1..cb63bc0e92ca 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config core_cfg; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > core_cfg.n =3D n; > core_cfg.cts =3D cts; > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9-- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/N5SAFAwAAAAAACgkQlh/E3EQov+Bw rg/+LR5m0fPa5U9oIwT4rwsKunaIejtxjKhv4yTaKVPunhtVb87Jqt+IqwsZ52d5O2enBQb43e3V fZQT55Mrk6m0m7mLG/lhk27hLemh4wSRgVJ0ZEg3YmQzTZZWQdupqbTJE7bcUJdwx8zIUcmzI1po 5trUyBPf46eRTNliM5Vc244dtzFgPgfuLBXZu/dCq8Zzn9Qxh757mW4HjMYMspJoaWNbgD8LvEsN LCU2Nk+1Ew7qY27KDzGOrfZllPIUnDgWqni8Ej5zCTuCMzvZXGV5wcbX9KzzjxV2KRkxByE/rivI 3/bGCRDkU8zda578ct2LHXr+8Fg/aoRxs6j1mxHylRDNHaMYG8ZHuQRY84PdOf/fcboIw3yr2ptH Sirs1DQo+tLuG86Z45W5uZkQQdWWkPmtv7LJDeHIUkMRKpN3OFM7YRVt/SdsB0lcIq306nd/mqk4 F/BfLqrs/KmDFnlpJOXYE0XXziSbK23CG2r/MZ/nUu+wMqa0gl6Ey9ZudSBYRAwZteFJ/nfelbvk vbx/2Mq8qN1WBRF6Rz4/YdTNSTrVg/tK45CFfBZzCiwGxoszbKzeg9/W8l229XJDx2q7B7+vsbqK uJDg97WCP4M4YssswkEdMf4GkaLsdva9ah2EiMkVB6fsOWMzQ7WlTuJ2Qow5yNgaG2ZyvldkV+H0 /to= =vrgS -----END PGP SIGNATURE----- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx-- --===============2388049874901601317== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2388049874901601317==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1284AC4361B for ; Mon, 7 Dec 2020 08:17:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF84D22ADF for ; Mon, 7 Dec 2020 08:17:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF84D22ADF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95AA76E584; Mon, 7 Dec 2020 08:17:41 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7726C89E7C for ; Mon, 7 Dec 2020 08:17:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2BCEAD71; Mon, 7 Dec 2020 08:17:38 +0000 (UTC) Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: Date: Mon, 7 Dec 2020 09:17:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Geert Uytterhoeven , Michael Ellerman , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Content-Type: multipart/mixed; boundary="===============1289748604==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1289748604== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E3lrt3AO1UboYAcLRO95c4R22Ins7taIx" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: multipart/mixed; boundary="OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: Subject: Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-4-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-4-sam@ravnborg.org> --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > Fix a few W=3D1 warnings about unused assignments. > Drop the unused error code. >=20 > v2: > - Subject updated (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Sam Ravnborg > Cc: Qilong Zhang > Cc: "Alexander A. Klimov" > Cc: Daniel Vetter > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > index 726c190862d4..e6363a420933 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c > @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config acore; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > =20 > /* Audio clock regeneration settings */ > acore.n =3D n; > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/driver= s/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > index eda29d3032e1..cb63bc0e92ca 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c > @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > struct hdmi_audio_format audio_format; > struct hdmi_audio_dma audio_dma; > struct hdmi_core_audio_config core_cfg; > - int err, n, cts, channel_count; > + int n, cts, channel_count; > unsigned int fs_nr; > bool word_length_16b =3D false; > =20 > @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core,= struct hdmi_wp_data *wp, > return -EINVAL; > } > =20 > - err =3D hdmi_compute_acr(pclk, fs_nr, &n, &cts); > + hdmi_compute_acr(pclk, fs_nr, &n, &cts); > core_cfg.n =3D n; > core_cfg.cts =3D cts; > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --OUWhZbPPdmE84pqiaWXJaw69CHLHuUKK9-- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/N5SAFAwAAAAAACgkQlh/E3EQov+Bw rg/+LR5m0fPa5U9oIwT4rwsKunaIejtxjKhv4yTaKVPunhtVb87Jqt+IqwsZ52d5O2enBQb43e3V fZQT55Mrk6m0m7mLG/lhk27hLemh4wSRgVJ0ZEg3YmQzTZZWQdupqbTJE7bcUJdwx8zIUcmzI1po 5trUyBPf46eRTNliM5Vc244dtzFgPgfuLBXZu/dCq8Zzn9Qxh757mW4HjMYMspJoaWNbgD8LvEsN LCU2Nk+1Ew7qY27KDzGOrfZllPIUnDgWqni8Ej5zCTuCMzvZXGV5wcbX9KzzjxV2KRkxByE/rivI 3/bGCRDkU8zda578ct2LHXr+8Fg/aoRxs6j1mxHylRDNHaMYG8ZHuQRY84PdOf/fcboIw3yr2ptH Sirs1DQo+tLuG86Z45W5uZkQQdWWkPmtv7LJDeHIUkMRKpN3OFM7YRVt/SdsB0lcIq306nd/mqk4 F/BfLqrs/KmDFnlpJOXYE0XXziSbK23CG2r/MZ/nUu+wMqa0gl6Ey9ZudSBYRAwZteFJ/nfelbvk vbx/2Mq8qN1WBRF6Rz4/YdTNSTrVg/tK45CFfBZzCiwGxoszbKzeg9/W8l229XJDx2q7B7+vsbqK uJDg97WCP4M4YssswkEdMf4GkaLsdva9ah2EiMkVB6fsOWMzQ7WlTuJ2Qow5yNgaG2ZyvldkV+H0 /to= =vrgS -----END PGP SIGNATURE----- --E3lrt3AO1UboYAcLRO95c4R22Ins7taIx-- --===============1289748604== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1289748604==--