All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@redhat.com>
To: "Yi Min Zhao" <zyimin@linux.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Ján Tomko" <jtomko@redhat.com>
Cc: borntraeger@de.ibm.com, fiuczy@linux.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined
Date: Fri, 25 May 2018 11:36:50 +0200	[thread overview]
Message-ID: <f497ad72-b7c6-4b59-b346-9a4038531b09@redhat.com> (raw)
In-Reply-To: <1165274f-53fa-ce25-380f-d6509ec083e5@linux.ibm.com>

On 05/25/2018 06:23 AM, Yi Min Zhao wrote:
> 
> 
> 在 2018/5/24 下午9:40, Paolo Bonzini 写道:
>> On 24/05/2018 09:53, Eduardo Otubo wrote:
>>>>>> Thanks! But I have not got response from Paolo.  I have added him to
>>>>>> CC list.
>>>>>>
>>>>>   I'll just wait one more ACK and will send a pull request on the
>>>>> seccomp queue. Thanks for the contribution.
>>>>>
>>>>>
>>>> So... what I should do is wait?
>>>>
>>> Yes, even though I think we're safe to proceed without his explicit ack.
>> The patch is okay; however, as a follow-up, you could consider moving
>> all the CONFIG_SECCOMP code to qemu-seccomp.c.
>>
>> This way, the only #ifdef remains the one around qemu_opts_foreach.
>>
>> Paolo
>>
>>
> Thanks for your comment! Indeed, moving to the single C file is much 
> more clear.
> I will do this after this patch.
> 
> @Otubo, what about next step?
> 
> 
If you're willing to send v3 with the changes Paolo suggested, I can 
wait to send the pull request. No worries.

  reply	other threads:[~2018-05-25  9:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 11:33 [Qemu-devel] [PATCH v2 0/1] Bug: Sandbox: libvirt breakdowns qemu guest Yi Min Zhao
2018-05-15 11:33 ` [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined Yi Min Zhao
2018-05-15 15:25   ` Eric Blake
2018-05-16  1:05     ` Yi Min Zhao
2018-05-17 11:33     ` Yi Min Zhao
2018-05-17 12:41   ` Eduardo Otubo
2018-05-17 14:36     ` Yi Min Zhao
2018-05-18  7:52     ` Ján Tomko
2018-05-18  9:19       ` Eduardo Otubo
2018-05-18 13:07         ` Ján Tomko
2018-05-19  8:20           ` Yi Min Zhao
2018-05-23  7:47             ` Ján Tomko
2018-05-23  9:16               ` Yi Min Zhao
2018-05-23 10:33                 ` Eduardo Otubo
2018-05-23 12:17                   ` Yi Min Zhao
2018-05-24  7:53                     ` Eduardo Otubo
2018-05-24 13:40                       ` Paolo Bonzini
2018-05-25  4:23                         ` Yi Min Zhao
2018-05-25  9:36                           ` Eduardo Otubo [this message]
2018-05-28 12:55                             ` Yi Min Zhao
2018-05-18 12:08       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f497ad72-b7c6-4b59-b346-9a4038531b09@redhat.com \
    --to=otubo@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=fiuczy@linux.ibm.com \
    --cc=jtomko@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zyimin@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.