All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
	"qi.fuli@fujitsu.com" <qi.fuli@fujitsu.com>,
	"Hu, Fenghua" <fenghua.hu@intel.com>,
	"qi.fuli@jp.fujitsu.com" <qi.fuli@jp.fujitsu.com>
Subject: Re: [ndctl PATCH 4/7] daxctl: add basic config parsing support
Date: Wed, 17 Nov 2021 23:17:50 +0000	[thread overview]
Message-ID: <f4a643b9bf5c09844e2c2c541d6fca0ff3c19e55.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4iFJrCCVzV66dNjzP_tF1Soq9UGyT36QdWxm-pWwVjZGg@mail.gmail.com>

On Thu, 2021-09-16 at 15:58 -0700, Dan Williams wrote:
> On Tue, Aug 31, 2021 at 2:05 AM Vishal Verma <vishal.l.verma@intel.com> wrote:
> > 
> > Add support similar to ndctl and libndctl for parsing config files. This
> > allows storing a config file path/list in the daxctl_ctx, and adds APIs
> > for setting and retrieving it.
> > 
> > Cc: QI Fuli <qi.fuli@fujitsu.com>
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> > ---
> >  daxctl/lib/libdaxctl.c   | 37 +++++++++++++++++++++++++++++++++++++
> >  daxctl/libdaxctl.h       |  2 ++
> >  daxctl/Makefile.am       |  1 +
> >  daxctl/lib/Makefile.am   |  4 ++++
> >  daxctl/lib/libdaxctl.sym |  2 ++
> >  5 files changed, 46 insertions(+)
> > 
[snip]
> > 
> > diff --git a/daxctl/Makefile.am b/daxctl/Makefile.am
> > index 9b1313a..a9845a0 100644
> > --- a/daxctl/Makefile.am
> > +++ b/daxctl/Makefile.am
> > @@ -10,6 +10,7 @@ config.h: $(srcdir)/Makefile.am
> >                 "$(daxctl_modprobe_datadir)/$(daxctl_modprobe_data)"' >>$@ && \
> >         echo '#define DAXCTL_MODPROBE_INSTALL \
> >                 "$(sysconfdir)/modprobe.d/$(daxctl_modprobe_data)"' >>$@
> > +       $(AM_V_GEN) echo '#define DAXCTL_CONF_DIR  "$(ndctl_confdir)"' >>$@
> 
> This gets back to my namespace question about collisions between
> daxctl, ndctl, and cxl-cli conf snippets. I think they should each get
> their own directory in /etc, then we don't need to encode any prefixes
> into section names. What do you think?

Yep splitting config directories sounds cleaner - I'll change this.


  reply	other threads:[~2021-11-17 23:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  9:04 [ndctl PATCH 0/7] Policy based reconfiguration for daxctl Vishal Verma
2021-08-31  9:04 ` [ndctl PATCH 1/7] ndctl: Update ndctl.spec.in for 'ndctl.conf' Vishal Verma
2021-09-02 12:15   ` qi.fuli
2021-08-31  9:04 ` [ndctl PATCH 2/7] daxctl: Documentation updates for persistent reconfiguration Vishal Verma
2021-09-16 22:47   ` Dan Williams
2021-11-17 23:02     ` Verma, Vishal L
2021-08-31  9:04 ` [ndctl PATCH 3/7] util/parse-config: refactor filter_conf_files into util/ Vishal Verma
2021-09-02 12:17   ` qi.fuli
2021-09-16 22:54   ` Dan Williams
2021-08-31  9:04 ` [ndctl PATCH 4/7] daxctl: add basic config parsing support Vishal Verma
2021-09-02 12:19   ` qi.fuli
2021-09-16 22:58   ` Dan Williams
2021-11-17 23:17     ` Verma, Vishal L [this message]
2021-08-31  9:04 ` [ndctl PATCH 5/7] util/parse-configs: add a key/value search helper Vishal Verma
2021-09-02 13:12   ` qi.fuli
2021-09-16 23:54   ` Dan Williams
2021-11-17 23:21     ` Verma, Vishal L
2021-08-31  9:04 ` [ndctl PATCH 6/7] daxctl/device.c: add an option for getting params from a config file Vishal Verma
2021-09-17  1:59   ` Dan Williams
2021-11-17 23:45     ` Verma, Vishal L
2021-08-31  9:04 ` [ndctl PATCH 7/7] daxctl: add systemd service and udev rule for auto-onlining Vishal Verma
2021-09-03  0:56   ` qi.fuli
2021-09-17 18:10   ` Dan Williams
2021-11-17 23:29     ` Verma, Vishal L
2021-11-17 23:43       ` Dan Williams
2021-11-18  2:40     ` Verma, Vishal L
2021-11-18  3:40       ` Dan Williams
2021-09-16 22:12 ` [ndctl PATCH 0/7] Policy based reconfiguration for daxctl Dan Williams
2021-11-19 20:57   ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4a643b9bf5c09844e2c2c541d6fca0ff3c19e55.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=fenghua.hu@intel.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=qi.fuli@fujitsu.com \
    --cc=qi.fuli@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.