All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Petter Selasky <hps@selasky.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] QEMU XHCI support (FreeBSD)
Date: Mon, 22 Aug 2016 20:15:51 +0200	[thread overview]
Message-ID: <f4fd0eab-2cdb-0ca4-9ef1-08cf50b356a8@selasky.org> (raw)
In-Reply-To: <90075d89-5c04-d419-9f98-7d9bc70555d3@selasky.org>

Hi,

I'm currently testing QEMUs XHCI support with FreeBSD and found some 
bugs in FreeBSDs XHCI aswell as QEMUs XHCI.

1) QEMU falsely reports a remainder of 8 bytes on TR_SETUP. This patch 
fixes it. Can it be upstreamed?

--- ./work/qemu-2.3.0/hw/usb/hcd-xhci.c.orig	2016-08-22 
16:07:30.877585000 +0200
+++ ./work/qemu-2.3.0/hw/usb/hcd-xhci.c	2016-08-22 16:08:19.240109000 +0200
@@ -1748,6 +1748,11 @@ static void xhci_xfer_report(XHCITransfe
           unsigned int chunk = 0;

           switch (TRB_TYPE(*trb)) {
+        case TR_SETUP:
+            chunk = trb->status & 0x1ffff;
+            if (chunk > 8)
+                chunk = 8;
+            break;
           case TR_DATA:
           case TR_NORMAL:
           case TR_ISOCH:

Please CC me. I'm not subscribed.

--HPS

       reply	other threads:[~2016-08-22 18:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <90075d89-5c04-d419-9f98-7d9bc70555d3@selasky.org>
2016-08-22 18:15 ` Hans Petter Selasky [this message]
2016-08-22 22:03   ` [Qemu-devel] QEMU XHCI support (FreeBSD) Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4fd0eab-2cdb-0ca4-9ef1-08cf50b356a8@selasky.org \
    --to=hps@selasky.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.