From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6460FC433FE for ; Tue, 15 Nov 2022 01:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235954AbiKOBtb (ORCPT ); Mon, 14 Nov 2022 20:49:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbiKOBt3 (ORCPT ); Mon, 14 Nov 2022 20:49:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B1517417 for ; Mon, 14 Nov 2022 17:49:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AAB8614F7 for ; Tue, 15 Nov 2022 01:49:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD5BC433D7; Tue, 15 Nov 2022 01:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668476965; bh=CR2GMStNJM6QvPJt1vn5PtaIR27e0Opd3pfbfK4U4Hs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Fg3t+ZjcpoP7aZeYsmLw0Oh3N3+i5guKgSi3Bn3P+Yy2suvgyffh8Z2Gpd2aHskz8 2aRgn50a74KxWFBlxha7tajflApIVx5GYW9uedqpCmWORDi1cj0oo4+ykWIh5CmqlZ 2aV/oj/Nt5NwbmBup5Oy7Fg5HjsB1jFazVfqnbajoVQ553rV0QSdFATWT/AUVmde2P 3vyFAZnIU4M/SgSpmnC3IAvdIdvYJl9JoYonse18KrOXiMmIRExACQftfUk7CV7KKz 7DO4jO+GfGzPwKsBdt3slmB+xoOpQ+8p0jtlpi5FLvsQ48TO0ips4EGooVtfrkWzqS UqS/gF+LQh0VA== Message-ID: Date: Tue, 15 Nov 2022 09:49:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: fix to enable compress for newly created file if extension matches Content-Language: en-US To: Jaegeuk Kim , Sheng Yong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20221111100830.953733-1-shengyong@oppo.com> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/15 8:20, Jaegeuk Kim wrote: > On 11/14, Jaegeuk Kim wrote: >> If compress_extension is set, and a newly created file matches the >> extension, the file could be marked as compression file. However, >> if inline_data is also enabled, there is no chance to check its >> extension since f2fs_should_compress() always returns false. >> >> This patch moves set_compress_inode(), which do extension check, in >> f2fs_should_compress() to check extensions before setting inline >> data flag. >> >> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode conversion") >> Signed-off-by: Sheng Yong >> Signed-off-by: Jaegeuk Kim >> --- >> fs/f2fs/namei.c | 326 ++++++++++++++++++++++++------------------------ >> 1 file changed, 160 insertions(+), 166 deletions(-) >> >> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c >> index e104409c3a0e..43b721d8e491 100644 >> --- a/fs/f2fs/namei.c >> +++ b/fs/f2fs/namei.c >> @@ -22,8 +22,160 @@ >> #include "acl.h" >> #include >> >> +static inline int is_extension_exist(const unsigned char *s, const char *sub, >> + bool tmp_ext) >> +{ >> + size_t slen = strlen(s); >> + size_t sublen = strlen(sub); >> + int i; >> + >> + if (sublen == 1 && *sub == '*') >> + return 1; >> + >> + /* >> + * filename format of multimedia file should be defined as: >> + * "filename + '.' + extension + (optional: '.' + temp extension)". >> + */ >> + if (slen < sublen + 2) >> + return 0; >> + >> + if (!tmp_ext) { >> + /* file has no temp extension */ >> + if (s[slen - sublen - 1] != '.') >> + return 0; >> + return !strncasecmp(s + slen - sublen, sub, sublen); >> + } >> + >> + for (i = 1; i < slen - sublen; i++) { >> + if (s[i] != '.') >> + continue; >> + if (!strncasecmp(s + i + 1, sub, sublen)) >> + return 1; >> + } >> + >> + return 0; >> +} >> + >> +int f2fs_update_extension_list(struct f2fs_sb_info *sbi, const char *name, >> + bool hot, bool set) >> +{ >> + __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> + int cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> + int hot_count = sbi->raw_super->hot_ext_count; >> + int total_count = cold_count + hot_count; >> + int start, count; >> + int i; >> + >> + if (set) { >> + if (total_count == F2FS_MAX_EXTENSION) >> + return -EINVAL; >> + } else { >> + if (!hot && !cold_count) >> + return -EINVAL; >> + if (hot && !hot_count) >> + return -EINVAL; >> + } >> + >> + if (hot) { >> + start = cold_count; >> + count = total_count; >> + } else { >> + start = 0; >> + count = cold_count; >> + } >> + >> + for (i = start; i < count; i++) { >> + if (strcmp(name, extlist[i])) >> + continue; >> + >> + if (set) >> + return -EINVAL; >> + >> + memcpy(extlist[i], extlist[i + 1], >> + F2FS_EXTENSION_LEN * (total_count - i - 1)); >> + memset(extlist[total_count - 1], 0, F2FS_EXTENSION_LEN); >> + if (hot) >> + sbi->raw_super->hot_ext_count = hot_count - 1; >> + else >> + sbi->raw_super->extension_count = >> + cpu_to_le32(cold_count - 1); >> + return 0; >> + } >> + >> + if (!set) >> + return -EINVAL; >> + >> + if (hot) { >> + memcpy(extlist[count], name, strlen(name)); >> + sbi->raw_super->hot_ext_count = hot_count + 1; >> + } else { >> + char buf[F2FS_MAX_EXTENSION][F2FS_EXTENSION_LEN]; >> + >> + memcpy(buf, &extlist[cold_count], >> + F2FS_EXTENSION_LEN * hot_count); >> + memset(extlist[cold_count], 0, F2FS_EXTENSION_LEN); >> + memcpy(extlist[cold_count], name, strlen(name)); >> + memcpy(&extlist[cold_count + 1], buf, >> + F2FS_EXTENSION_LEN * hot_count); >> + sbi->raw_super->extension_count = cpu_to_le32(cold_count + 1); >> + } >> + return 0; >> +} >> + >> +static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir, >> + struct inode *inode, const unsigned char *name) >> +{ >> + __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> + unsigned char (*noext)[F2FS_EXTENSION_LEN] = >> + F2FS_OPTION(sbi).noextensions; >> + unsigned char (*ext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).extensions; >> + unsigned char ext_cnt = F2FS_OPTION(sbi).compress_ext_cnt; >> + unsigned char noext_cnt = F2FS_OPTION(sbi).nocompress_ext_cnt; >> + int i, cold_count, hot_count; >> + >> + if (!f2fs_sb_has_compression(sbi) || !name) >> + return; >> + if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) >> + return; >> + >> + /* Inherit the compression flag in directory */ >> + if ((F2FS_I(dir)->i_flags & F2FS_COMPR_FL)) { >> + set_compress_context(inode); >> + return; >> + } >> + >> + /* Start to check extension list */ >> + if (!ext_cnt) >> + return; >> + >> + /* Don't compress hot files. */ >> + f2fs_down_read(&sbi->sb_lock); >> + cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> + hot_count = sbi->raw_super->hot_ext_count; >> + for (i = cold_count; i < cold_count + hot_count; i++) >> + if (is_extension_exist(name, extlist[i], false)) >> + break; >> + f2fs_up_read(&sbi->sb_lock); >> + if (i < (cold_count + hot_count)) >> + return; >> + >> + /* Don't compress unallowed extension. */ >> + for (i = 0; i < noext_cnt; i++) >> + if (is_extension_exist(name, noext[i], false)) >> + return; >> + >> + /* Compress wanting extension. */ >> + for (i = 0; i < ext_cnt; i++) { >> + if (is_extension_exist(name, ext[i], false)) { >> + set_compress_context(inode); >> + return; >> + } >> + } >> +} >> + >> static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> - struct inode *dir, umode_t mode) >> + struct inode *dir, umode_t mode, >> + const char *name) >> { >> struct f2fs_sb_info *sbi = F2FS_I_SB(dir); >> nid_t ino; >> @@ -114,12 +266,8 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> if (F2FS_I(inode)->i_flags & F2FS_PROJINHERIT_FL) >> set_inode_flag(inode, FI_PROJ_INHERIT); >> >> - if (f2fs_sb_has_compression(sbi)) { >> - /* Inherit the compression flag in directory */ >> - if ((F2FS_I(dir)->i_flags & F2FS_COMPR_FL) && >> - f2fs_may_compress(inode)) >> - set_compress_context(inode); >> - } >> + /* Check compression first. */ >> + set_compress_new_inode(sbi, dir, inode, name); >> >> /* Should enable inline_data after compression set */ >> if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode)) >> @@ -153,40 +301,6 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> return ERR_PTR(err); >> } >> >> -static inline int is_extension_exist(const unsigned char *s, const char *sub, >> - bool tmp_ext) >> -{ >> - size_t slen = strlen(s); >> - size_t sublen = strlen(sub); >> - int i; >> - >> - if (sublen == 1 && *sub == '*') >> - return 1; >> - >> - /* >> - * filename format of multimedia file should be defined as: >> - * "filename + '.' + extension + (optional: '.' + temp extension)". >> - */ >> - if (slen < sublen + 2) >> - return 0; >> - >> - if (!tmp_ext) { >> - /* file has no temp extension */ >> - if (s[slen - sublen - 1] != '.') >> - return 0; >> - return !strncasecmp(s + slen - sublen, sub, sublen); >> - } >> - >> - for (i = 1; i < slen - sublen; i++) { >> - if (s[i] != '.') >> - continue; >> - if (!strncasecmp(s + i + 1, sub, sublen)) >> - return 1; >> - } >> - >> - return 0; >> -} >> - >> /* >> * Set file's temperature for hot/cold data separation >> */ >> @@ -217,124 +331,6 @@ static inline void set_file_temperature(struct f2fs_sb_info *sbi, struct inode * >> file_set_hot(inode); >> } >> >> -int f2fs_update_extension_list(struct f2fs_sb_info *sbi, const char *name, >> - bool hot, bool set) >> -{ >> - __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> - int cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> - int hot_count = sbi->raw_super->hot_ext_count; >> - int total_count = cold_count + hot_count; >> - int start, count; >> - int i; >> - >> - if (set) { >> - if (total_count == F2FS_MAX_EXTENSION) >> - return -EINVAL; >> - } else { >> - if (!hot && !cold_count) >> - return -EINVAL; >> - if (hot && !hot_count) >> - return -EINVAL; >> - } >> - >> - if (hot) { >> - start = cold_count; >> - count = total_count; >> - } else { >> - start = 0; >> - count = cold_count; >> - } >> - >> - for (i = start; i < count; i++) { >> - if (strcmp(name, extlist[i])) >> - continue; >> - >> - if (set) >> - return -EINVAL; >> - >> - memcpy(extlist[i], extlist[i + 1], >> - F2FS_EXTENSION_LEN * (total_count - i - 1)); >> - memset(extlist[total_count - 1], 0, F2FS_EXTENSION_LEN); >> - if (hot) >> - sbi->raw_super->hot_ext_count = hot_count - 1; >> - else >> - sbi->raw_super->extension_count = >> - cpu_to_le32(cold_count - 1); >> - return 0; >> - } >> - >> - if (!set) >> - return -EINVAL; >> - >> - if (hot) { >> - memcpy(extlist[count], name, strlen(name)); >> - sbi->raw_super->hot_ext_count = hot_count + 1; >> - } else { >> - char buf[F2FS_MAX_EXTENSION][F2FS_EXTENSION_LEN]; >> - >> - memcpy(buf, &extlist[cold_count], >> - F2FS_EXTENSION_LEN * hot_count); >> - memset(extlist[cold_count], 0, F2FS_EXTENSION_LEN); >> - memcpy(extlist[cold_count], name, strlen(name)); >> - memcpy(&extlist[cold_count + 1], buf, >> - F2FS_EXTENSION_LEN * hot_count); >> - sbi->raw_super->extension_count = cpu_to_le32(cold_count + 1); >> - } >> - return 0; >> -} >> - >> -static void set_compress_inode(struct f2fs_sb_info *sbi, struct inode *inode, >> - const unsigned char *name) >> -{ >> - __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> - unsigned char (*noext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).noextensions; >> - unsigned char (*ext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).extensions; >> - unsigned char ext_cnt = F2FS_OPTION(sbi).compress_ext_cnt; >> - unsigned char noext_cnt = F2FS_OPTION(sbi).nocompress_ext_cnt; >> - int i, cold_count, hot_count; >> - >> - if (!f2fs_sb_has_compression(sbi) || >> - F2FS_I(inode)->i_flags & F2FS_NOCOMP_FL || >> - !f2fs_may_compress(inode) || >> - (!ext_cnt && !noext_cnt)) >> - return; >> - >> - f2fs_down_read(&sbi->sb_lock); >> - >> - cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> - hot_count = sbi->raw_super->hot_ext_count; >> - >> - for (i = cold_count; i < cold_count + hot_count; i++) { >> - if (is_extension_exist(name, extlist[i], false)) { >> - f2fs_up_read(&sbi->sb_lock); >> - return; >> - } >> - } >> - >> - f2fs_up_read(&sbi->sb_lock); >> - >> - for (i = 0; i < noext_cnt; i++) { >> - if (is_extension_exist(name, noext[i], false)) { >> - f2fs_disable_compressed_file(inode); >> - return; >> - } >> - } >> - >> - if (is_inode_flag_set(inode, FI_COMPRESSED_FILE)) >> - return; >> - >> - for (i = 0; i < ext_cnt; i++) { >> - if (!is_extension_exist(name, ext[i], false)) >> - continue; >> - >> - /* Do not use inline_data with compression */ >> - stat_dec_inline_inode(inode); >> - clear_inode_flag(inode, FI_INLINE_DATA); >> - set_compress_context(inode); >> - return; >> - } >> -} >> - >> static int f2fs_create(struct user_namespace *mnt_userns, struct inode *dir, >> struct dentry *dentry, umode_t mode, bool excl) >> { >> @@ -352,15 +348,13 @@ static int f2fs_create(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, dentry->d_name.name); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> if (!test_opt(sbi, DISABLE_EXT_IDENTIFY)) >> set_file_temperature(sbi, inode, dentry->d_name.name); >> >> - set_compress_inode(sbi, inode, dentry->d_name.name); >> - >> inode->i_op = &f2fs_file_inode_operations; >> inode->i_fop = &f2fs_file_operations; >> inode->i_mapping->a_ops = &f2fs_dblock_aops; >> @@ -689,7 +683,7 @@ static int f2fs_symlink(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO); >> + inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -760,7 +754,7 @@ static int f2fs_mkdir(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode); >> + inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, NULL); > > - inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, NULL); > + inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, > + dentry->d_name.name); > > Should pass dentry. It looks F2FS_COMPR_FL should be inherited for both directory and regular inode, and the flag should be set/unset due to matched {,no}ext only for regular inode. Thanks, > >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -817,7 +811,7 @@ static int f2fs_mknod(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -856,7 +850,7 @@ static int __f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> -- >> 2.38.1.493.g58b659f92b-goog >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B8CCC4332F for ; Tue, 15 Nov 2022 01:49:35 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oul4w-00030f-4O; Tue, 15 Nov 2022 01:49:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oul4u-00030Z-Sj for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Nov 2022 01:49:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QB6fgXZMQjKvwe3bjcljNXjC3Lt5nmoWLiAAqRdyYHA=; b=jlZy71cjs/yweXHcmjxiG2nRdN dZVcaPspEraFFeImSQDVECvyIEXYLxn4fwzmhnqQeGSeaOWs/mILyqURklDq+EWe49jzI+bBLVoLx xDMml708YxYONmhyOGe4gaNYaxXrVXtcusKxMne/SW2PC0rZTRpHy192myExArFvW/mw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QB6fgXZMQjKvwe3bjcljNXjC3Lt5nmoWLiAAqRdyYHA=; b=OHBwBUgkA0xCW/t8NJNSOeY1t/ cs3ilD+ZUxSb36D4S7TB4zONa255dfCqUKZxknMbYRimwtxYwqmvPq1BRyZn5kI1fWCyMJ7pryFpm HKM1pyMCE1Joeuv7oEaUMefxSnwynOATH54SxcY51ZVt4TA4PDQ2FxaA44olbM5nwnHA=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oul4t-008aYW-RA for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Nov 2022 01:49:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64A2A614BB; Tue, 15 Nov 2022 01:49:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD5BC433D7; Tue, 15 Nov 2022 01:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668476965; bh=CR2GMStNJM6QvPJt1vn5PtaIR27e0Opd3pfbfK4U4Hs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Fg3t+ZjcpoP7aZeYsmLw0Oh3N3+i5guKgSi3Bn3P+Yy2suvgyffh8Z2Gpd2aHskz8 2aRgn50a74KxWFBlxha7tajflApIVx5GYW9uedqpCmWORDi1cj0oo4+ykWIh5CmqlZ 2aV/oj/Nt5NwbmBup5Oy7Fg5HjsB1jFazVfqnbajoVQ553rV0QSdFATWT/AUVmde2P 3vyFAZnIU4M/SgSpmnC3IAvdIdvYJl9JoYonse18KrOXiMmIRExACQftfUk7CV7KKz 7DO4jO+GfGzPwKsBdt3slmB+xoOpQ+8p0jtlpi5FLvsQ48TO0ips4EGooVtfrkWzqS UqS/gF+LQh0VA== Message-ID: Date: Tue, 15 Nov 2022 09:49:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Content-Language: en-US To: Jaegeuk Kim , Sheng Yong References: <20221111100830.953733-1-shengyong@oppo.com> From: Chao Yu In-Reply-To: X-Headers-End: 1oul4t-008aYW-RA Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: fix to enable compress for newly created file if extension matches X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/11/15 8:20, Jaegeuk Kim wrote: > On 11/14, Jaegeuk Kim wrote: >> If compress_extension is set, and a newly created file matches the >> extension, the file could be marked as compression file. However, >> if inline_data is also enabled, there is no chance to check its >> extension since f2fs_should_compress() always returns false. >> >> This patch moves set_compress_inode(), which do extension check, in >> f2fs_should_compress() to check extensions before setting inline >> data flag. >> >> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode conversion") >> Signed-off-by: Sheng Yong >> Signed-off-by: Jaegeuk Kim >> --- >> fs/f2fs/namei.c | 326 ++++++++++++++++++++++++------------------------ >> 1 file changed, 160 insertions(+), 166 deletions(-) >> >> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c >> index e104409c3a0e..43b721d8e491 100644 >> --- a/fs/f2fs/namei.c >> +++ b/fs/f2fs/namei.c >> @@ -22,8 +22,160 @@ >> #include "acl.h" >> #include >> >> +static inline int is_extension_exist(const unsigned char *s, const char *sub, >> + bool tmp_ext) >> +{ >> + size_t slen = strlen(s); >> + size_t sublen = strlen(sub); >> + int i; >> + >> + if (sublen == 1 && *sub == '*') >> + return 1; >> + >> + /* >> + * filename format of multimedia file should be defined as: >> + * "filename + '.' + extension + (optional: '.' + temp extension)". >> + */ >> + if (slen < sublen + 2) >> + return 0; >> + >> + if (!tmp_ext) { >> + /* file has no temp extension */ >> + if (s[slen - sublen - 1] != '.') >> + return 0; >> + return !strncasecmp(s + slen - sublen, sub, sublen); >> + } >> + >> + for (i = 1; i < slen - sublen; i++) { >> + if (s[i] != '.') >> + continue; >> + if (!strncasecmp(s + i + 1, sub, sublen)) >> + return 1; >> + } >> + >> + return 0; >> +} >> + >> +int f2fs_update_extension_list(struct f2fs_sb_info *sbi, const char *name, >> + bool hot, bool set) >> +{ >> + __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> + int cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> + int hot_count = sbi->raw_super->hot_ext_count; >> + int total_count = cold_count + hot_count; >> + int start, count; >> + int i; >> + >> + if (set) { >> + if (total_count == F2FS_MAX_EXTENSION) >> + return -EINVAL; >> + } else { >> + if (!hot && !cold_count) >> + return -EINVAL; >> + if (hot && !hot_count) >> + return -EINVAL; >> + } >> + >> + if (hot) { >> + start = cold_count; >> + count = total_count; >> + } else { >> + start = 0; >> + count = cold_count; >> + } >> + >> + for (i = start; i < count; i++) { >> + if (strcmp(name, extlist[i])) >> + continue; >> + >> + if (set) >> + return -EINVAL; >> + >> + memcpy(extlist[i], extlist[i + 1], >> + F2FS_EXTENSION_LEN * (total_count - i - 1)); >> + memset(extlist[total_count - 1], 0, F2FS_EXTENSION_LEN); >> + if (hot) >> + sbi->raw_super->hot_ext_count = hot_count - 1; >> + else >> + sbi->raw_super->extension_count = >> + cpu_to_le32(cold_count - 1); >> + return 0; >> + } >> + >> + if (!set) >> + return -EINVAL; >> + >> + if (hot) { >> + memcpy(extlist[count], name, strlen(name)); >> + sbi->raw_super->hot_ext_count = hot_count + 1; >> + } else { >> + char buf[F2FS_MAX_EXTENSION][F2FS_EXTENSION_LEN]; >> + >> + memcpy(buf, &extlist[cold_count], >> + F2FS_EXTENSION_LEN * hot_count); >> + memset(extlist[cold_count], 0, F2FS_EXTENSION_LEN); >> + memcpy(extlist[cold_count], name, strlen(name)); >> + memcpy(&extlist[cold_count + 1], buf, >> + F2FS_EXTENSION_LEN * hot_count); >> + sbi->raw_super->extension_count = cpu_to_le32(cold_count + 1); >> + } >> + return 0; >> +} >> + >> +static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir, >> + struct inode *inode, const unsigned char *name) >> +{ >> + __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> + unsigned char (*noext)[F2FS_EXTENSION_LEN] = >> + F2FS_OPTION(sbi).noextensions; >> + unsigned char (*ext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).extensions; >> + unsigned char ext_cnt = F2FS_OPTION(sbi).compress_ext_cnt; >> + unsigned char noext_cnt = F2FS_OPTION(sbi).nocompress_ext_cnt; >> + int i, cold_count, hot_count; >> + >> + if (!f2fs_sb_has_compression(sbi) || !name) >> + return; >> + if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) >> + return; >> + >> + /* Inherit the compression flag in directory */ >> + if ((F2FS_I(dir)->i_flags & F2FS_COMPR_FL)) { >> + set_compress_context(inode); >> + return; >> + } >> + >> + /* Start to check extension list */ >> + if (!ext_cnt) >> + return; >> + >> + /* Don't compress hot files. */ >> + f2fs_down_read(&sbi->sb_lock); >> + cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> + hot_count = sbi->raw_super->hot_ext_count; >> + for (i = cold_count; i < cold_count + hot_count; i++) >> + if (is_extension_exist(name, extlist[i], false)) >> + break; >> + f2fs_up_read(&sbi->sb_lock); >> + if (i < (cold_count + hot_count)) >> + return; >> + >> + /* Don't compress unallowed extension. */ >> + for (i = 0; i < noext_cnt; i++) >> + if (is_extension_exist(name, noext[i], false)) >> + return; >> + >> + /* Compress wanting extension. */ >> + for (i = 0; i < ext_cnt; i++) { >> + if (is_extension_exist(name, ext[i], false)) { >> + set_compress_context(inode); >> + return; >> + } >> + } >> +} >> + >> static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> - struct inode *dir, umode_t mode) >> + struct inode *dir, umode_t mode, >> + const char *name) >> { >> struct f2fs_sb_info *sbi = F2FS_I_SB(dir); >> nid_t ino; >> @@ -114,12 +266,8 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> if (F2FS_I(inode)->i_flags & F2FS_PROJINHERIT_FL) >> set_inode_flag(inode, FI_PROJ_INHERIT); >> >> - if (f2fs_sb_has_compression(sbi)) { >> - /* Inherit the compression flag in directory */ >> - if ((F2FS_I(dir)->i_flags & F2FS_COMPR_FL) && >> - f2fs_may_compress(inode)) >> - set_compress_context(inode); >> - } >> + /* Check compression first. */ >> + set_compress_new_inode(sbi, dir, inode, name); >> >> /* Should enable inline_data after compression set */ >> if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode)) >> @@ -153,40 +301,6 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, >> return ERR_PTR(err); >> } >> >> -static inline int is_extension_exist(const unsigned char *s, const char *sub, >> - bool tmp_ext) >> -{ >> - size_t slen = strlen(s); >> - size_t sublen = strlen(sub); >> - int i; >> - >> - if (sublen == 1 && *sub == '*') >> - return 1; >> - >> - /* >> - * filename format of multimedia file should be defined as: >> - * "filename + '.' + extension + (optional: '.' + temp extension)". >> - */ >> - if (slen < sublen + 2) >> - return 0; >> - >> - if (!tmp_ext) { >> - /* file has no temp extension */ >> - if (s[slen - sublen - 1] != '.') >> - return 0; >> - return !strncasecmp(s + slen - sublen, sub, sublen); >> - } >> - >> - for (i = 1; i < slen - sublen; i++) { >> - if (s[i] != '.') >> - continue; >> - if (!strncasecmp(s + i + 1, sub, sublen)) >> - return 1; >> - } >> - >> - return 0; >> -} >> - >> /* >> * Set file's temperature for hot/cold data separation >> */ >> @@ -217,124 +331,6 @@ static inline void set_file_temperature(struct f2fs_sb_info *sbi, struct inode * >> file_set_hot(inode); >> } >> >> -int f2fs_update_extension_list(struct f2fs_sb_info *sbi, const char *name, >> - bool hot, bool set) >> -{ >> - __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> - int cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> - int hot_count = sbi->raw_super->hot_ext_count; >> - int total_count = cold_count + hot_count; >> - int start, count; >> - int i; >> - >> - if (set) { >> - if (total_count == F2FS_MAX_EXTENSION) >> - return -EINVAL; >> - } else { >> - if (!hot && !cold_count) >> - return -EINVAL; >> - if (hot && !hot_count) >> - return -EINVAL; >> - } >> - >> - if (hot) { >> - start = cold_count; >> - count = total_count; >> - } else { >> - start = 0; >> - count = cold_count; >> - } >> - >> - for (i = start; i < count; i++) { >> - if (strcmp(name, extlist[i])) >> - continue; >> - >> - if (set) >> - return -EINVAL; >> - >> - memcpy(extlist[i], extlist[i + 1], >> - F2FS_EXTENSION_LEN * (total_count - i - 1)); >> - memset(extlist[total_count - 1], 0, F2FS_EXTENSION_LEN); >> - if (hot) >> - sbi->raw_super->hot_ext_count = hot_count - 1; >> - else >> - sbi->raw_super->extension_count = >> - cpu_to_le32(cold_count - 1); >> - return 0; >> - } >> - >> - if (!set) >> - return -EINVAL; >> - >> - if (hot) { >> - memcpy(extlist[count], name, strlen(name)); >> - sbi->raw_super->hot_ext_count = hot_count + 1; >> - } else { >> - char buf[F2FS_MAX_EXTENSION][F2FS_EXTENSION_LEN]; >> - >> - memcpy(buf, &extlist[cold_count], >> - F2FS_EXTENSION_LEN * hot_count); >> - memset(extlist[cold_count], 0, F2FS_EXTENSION_LEN); >> - memcpy(extlist[cold_count], name, strlen(name)); >> - memcpy(&extlist[cold_count + 1], buf, >> - F2FS_EXTENSION_LEN * hot_count); >> - sbi->raw_super->extension_count = cpu_to_le32(cold_count + 1); >> - } >> - return 0; >> -} >> - >> -static void set_compress_inode(struct f2fs_sb_info *sbi, struct inode *inode, >> - const unsigned char *name) >> -{ >> - __u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list; >> - unsigned char (*noext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).noextensions; >> - unsigned char (*ext)[F2FS_EXTENSION_LEN] = F2FS_OPTION(sbi).extensions; >> - unsigned char ext_cnt = F2FS_OPTION(sbi).compress_ext_cnt; >> - unsigned char noext_cnt = F2FS_OPTION(sbi).nocompress_ext_cnt; >> - int i, cold_count, hot_count; >> - >> - if (!f2fs_sb_has_compression(sbi) || >> - F2FS_I(inode)->i_flags & F2FS_NOCOMP_FL || >> - !f2fs_may_compress(inode) || >> - (!ext_cnt && !noext_cnt)) >> - return; >> - >> - f2fs_down_read(&sbi->sb_lock); >> - >> - cold_count = le32_to_cpu(sbi->raw_super->extension_count); >> - hot_count = sbi->raw_super->hot_ext_count; >> - >> - for (i = cold_count; i < cold_count + hot_count; i++) { >> - if (is_extension_exist(name, extlist[i], false)) { >> - f2fs_up_read(&sbi->sb_lock); >> - return; >> - } >> - } >> - >> - f2fs_up_read(&sbi->sb_lock); >> - >> - for (i = 0; i < noext_cnt; i++) { >> - if (is_extension_exist(name, noext[i], false)) { >> - f2fs_disable_compressed_file(inode); >> - return; >> - } >> - } >> - >> - if (is_inode_flag_set(inode, FI_COMPRESSED_FILE)) >> - return; >> - >> - for (i = 0; i < ext_cnt; i++) { >> - if (!is_extension_exist(name, ext[i], false)) >> - continue; >> - >> - /* Do not use inline_data with compression */ >> - stat_dec_inline_inode(inode); >> - clear_inode_flag(inode, FI_INLINE_DATA); >> - set_compress_context(inode); >> - return; >> - } >> -} >> - >> static int f2fs_create(struct user_namespace *mnt_userns, struct inode *dir, >> struct dentry *dentry, umode_t mode, bool excl) >> { >> @@ -352,15 +348,13 @@ static int f2fs_create(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, dentry->d_name.name); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> if (!test_opt(sbi, DISABLE_EXT_IDENTIFY)) >> set_file_temperature(sbi, inode, dentry->d_name.name); >> >> - set_compress_inode(sbi, inode, dentry->d_name.name); >> - >> inode->i_op = &f2fs_file_inode_operations; >> inode->i_fop = &f2fs_file_operations; >> inode->i_mapping->a_ops = &f2fs_dblock_aops; >> @@ -689,7 +683,7 @@ static int f2fs_symlink(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO); >> + inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -760,7 +754,7 @@ static int f2fs_mkdir(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode); >> + inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, NULL); > > - inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, NULL); > + inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, > + dentry->d_name.name); > > Should pass dentry. It looks F2FS_COMPR_FL should be inherited for both directory and regular inode, and the flag should be set/unset due to matched {,no}ext only for regular inode. Thanks, > >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -817,7 +811,7 @@ static int f2fs_mknod(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> @@ -856,7 +850,7 @@ static int __f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir, >> if (err) >> return err; >> >> - inode = f2fs_new_inode(mnt_userns, dir, mode); >> + inode = f2fs_new_inode(mnt_userns, dir, mode, NULL); >> if (IS_ERR(inode)) >> return PTR_ERR(inode); >> >> -- >> 2.38.1.493.g58b659f92b-goog >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel