From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E0FC47089 for ; Thu, 27 May 2021 01:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E10C3613C1 for ; Thu, 27 May 2021 01:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232965AbhE0Boa (ORCPT ); Wed, 26 May 2021 21:44:30 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:43707 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231968AbhE0Bo3 (ORCPT ); Wed, 26 May 2021 21:44:29 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Fr9Yn31VKz9sPf; Thu, 27 May 2021 11:42:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1622079775; bh=ZS8pKZC0rALk5FKsBmqSxc/EGGyl/NL76hCAbd4pK1I=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=K2if7ryyvkECFbijqrSBC1HorlX2a4EFf0OiYKXejMep2456kRglHWDhKjLGO/Lif C0D69pDAXcdaEt0W15tWFhEwohyj+q1QzB52Y1oJEfjBgH6Cw5JZR+vBB02zOpGmzs hLU1GqUgY2+JbAIU2iqMOyQop+8Pot5pt0NmeILVzqvBrYSlj4FmV91eRWogBk6hhp ZLiVlc3drZRE0T+tXtudEINgvV1HZZwIp2Rbg4G6Ovsr5n2xmswHFxs3w2WqO6e6PT i2DAK7+fbIQxKbk/XLTL2C+uRGHUzd/9UxyqjIwWs8iaE/sf6yvqDXNimkP2hBfHXj m1FpKhii4SJQA== Message-ID: Subject: Re: [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. From: Jeremy Kerr To: Steven Lee , Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list Cc: Hongweiz@ami.com, ryan_chen@aspeedtech.com, billy_tsai@aspeedtech.com Date: Thu, 27 May 2021 09:42:51 +0800 In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com> References: <20210526094609.14068-1-steven_lee@aspeedtech.com> <20210526094609.14068-2-steven_lee@aspeedtech.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Steven, > SGPIO bindings should be converted as yaml format. > In addition to the file conversion, a new property max-ngpios is > added in the yaml file as well. > The new property is required by the enhanced sgpio driver for > making the configuration of the max number of gpio pins more > flexible. There are a number of things going on here - you're doing the YAML conversion, introducing the max-gpios property, and changing the compatible value. The first two make sense, but may be better split into separate changes, so that the YAML conversion is a "linear" change. I'm not clear on why you're changing the compatible value though, particularly as you're dropping support for the existing compatible value anyway. How about we keep the old one, and use the default of 128 for cases where max-ngpios is absent? That way, we retain support for the existing device trees. > +  max-ngpios: > +    description: > +      represents the number of actual hardware-supported GPIOs (ie, > +      slots within the clocked serial GPIO data). Since each HW GPIO is both an > +      input and an output, we provide max_ngpios * 2 lines on our gpiochip > +      device. We also use it to define the split between the inputs and > +      outputs; the inputs start at line 0, the outputs start at max_ngpios. Most of this description is better suited to the ngpios property, which controls the number of lines that the gpiochip will expose. Also, minor nit: max_ngpios -> max-ngpios. How about something like: ngpios: description: Number of GPIO lines to expose. Since each HW GPIO is an input and an output, we provide ngpios * 2 lines on our chip device. We also use it to define the split between the inputs and outputs; the inputs start at line 0, the outputs start at ngpios. max-ngpios: description: Represents the number of actual hardware-supported GPIOs (ie, slots within the clocked serial GPIO data), and therefore the maximum value for the ngpios property > +    minimum: 0 > +    maximum: 128 Will this be the case for all (future) hardware? Can we leave this unbound? Cheers, Jeremy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E0CC47089 for ; Thu, 27 May 2021 01:44:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC4A76052B for ; Thu, 27 May 2021 01:44:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC4A76052B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j8CJ+YQnCzL7rhIYigGNQLgVHKsWekweux3+JVXa+04=; b=sRNHJoYKiurmoA M3sFBlKWn9dUW7BYWHdwmk2pJs9Lm2+sB3TSkM7mRMksbYtC98yKncNo8yU5yyf2VD7tJxKbLy4zb K2d8JP7YKJDH878Sc3xgOuGhRBHwefNTNqDllyG2ZDBEuiXJ5QFQ06BG0dxaPqJR5lZo0SoKLlao0 tK72ytEuOwFBpakDrcO5MX2uWvpYt8P8XyTypDS7nLHDZC8iq9rWYcuKfc0yK9y2Y7SS5pX6/5v0E aoDSdxKAWK9dQfliOoWB5PDyZp3Pic240AHE82eqP9tJZW6VS0Rn/Dg7MnjjP/bQVGU1FPuMdZqI3 rUqmc0D4GrszKFFYP/ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm53C-001YYp-5O; Thu, 27 May 2021 01:43:06 +0000 Received: from ozlabs.org ([2401:3900:2:1::2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm538-001YSg-7s for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 01:43:03 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Fr9Yn31VKz9sPf; Thu, 27 May 2021 11:42:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1622079775; bh=ZS8pKZC0rALk5FKsBmqSxc/EGGyl/NL76hCAbd4pK1I=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=K2if7ryyvkECFbijqrSBC1HorlX2a4EFf0OiYKXejMep2456kRglHWDhKjLGO/Lif C0D69pDAXcdaEt0W15tWFhEwohyj+q1QzB52Y1oJEfjBgH6Cw5JZR+vBB02zOpGmzs hLU1GqUgY2+JbAIU2iqMOyQop+8Pot5pt0NmeILVzqvBrYSlj4FmV91eRWogBk6hhp ZLiVlc3drZRE0T+tXtudEINgvV1HZZwIp2Rbg4G6Ovsr5n2xmswHFxs3w2WqO6e6PT i2DAK7+fbIQxKbk/XLTL2C+uRGHUzd/9UxyqjIwWs8iaE/sf6yvqDXNimkP2hBfHXj m1FpKhii4SJQA== Message-ID: Subject: Re: [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. From: Jeremy Kerr To: Steven Lee , Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list Cc: Hongweiz@ami.com, ryan_chen@aspeedtech.com, billy_tsai@aspeedtech.com Date: Thu, 27 May 2021 09:42:51 +0800 In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com> References: <20210526094609.14068-1-steven_lee@aspeedtech.com> <20210526094609.14068-2-steven_lee@aspeedtech.com> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_184302_540407_D16C0F83 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3RldmVuLAoKPiBTR1BJTyBiaW5kaW5ncyBzaG91bGQgYmUgY29udmVydGVkIGFzIHlhbWwg Zm9ybWF0Lgo+IEluIGFkZGl0aW9uIHRvIHRoZSBmaWxlIGNvbnZlcnNpb24sIGEgbmV3IHByb3Bl cnR5IG1heC1uZ3Bpb3MgaXMKPiBhZGRlZCBpbiB0aGUgeWFtbCBmaWxlIGFzIHdlbGwuCj4gVGhl IG5ldyBwcm9wZXJ0eSBpcyByZXF1aXJlZCBieSB0aGUgZW5oYW5jZWQgc2dwaW8gZHJpdmVyIGZv cgo+IG1ha2luZyB0aGUgY29uZmlndXJhdGlvbiBvZiB0aGUgbWF4IG51bWJlciBvZiBncGlvIHBp bnMgbW9yZQo+IGZsZXhpYmxlLgoKVGhlcmUgYXJlIGEgbnVtYmVyIG9mIHRoaW5ncyBnb2luZyBv biBoZXJlIC0geW91J3JlIGRvaW5nIHRoZSBZQU1MCmNvbnZlcnNpb24sIGludHJvZHVjaW5nIHRo ZSBtYXgtZ3Bpb3MgcHJvcGVydHksIGFuZCBjaGFuZ2luZyB0aGUKY29tcGF0aWJsZSB2YWx1ZS4K ClRoZSBmaXJzdCB0d28gbWFrZSBzZW5zZSwgYnV0IG1heSBiZSBiZXR0ZXIgc3BsaXQgaW50byBz ZXBhcmF0ZQpjaGFuZ2VzLCBzbyB0aGF0IHRoZSBZQU1MIGNvbnZlcnNpb24gaXMgYSAibGluZWFy IiBjaGFuZ2UuCgpJJ20gbm90IGNsZWFyIG9uIHdoeSB5b3UncmUgY2hhbmdpbmcgdGhlIGNvbXBh dGlibGUgdmFsdWUgdGhvdWdoLApwYXJ0aWN1bGFybHkgYXMgeW91J3JlIGRyb3BwaW5nIHN1cHBv cnQgZm9yIHRoZSBleGlzdGluZyBjb21wYXRpYmxlCnZhbHVlIGFueXdheS4gSG93IGFib3V0IHdl IGtlZXAgdGhlIG9sZCBvbmUsIGFuZCB1c2UgdGhlIGRlZmF1bHQgb2YgMTI4CmZvciBjYXNlcyB3 aGVyZSBtYXgtbmdwaW9zIGlzIGFic2VudD8gVGhhdCB3YXksIHdlIHJldGFpbiBzdXBwb3J0IGZv cgp0aGUgZXhpc3RpbmcgZGV2aWNlIHRyZWVzLgoKPiArwqAgbWF4LW5ncGlvczoKPiArwqDCoMKg IGRlc2NyaXB0aW9uOgo+ICvCoMKgwqDCoMKgIHJlcHJlc2VudHMgdGhlIG51bWJlciBvZiBhY3R1 YWwgaGFyZHdhcmUtc3VwcG9ydGVkIEdQSU9zIChpZSwKPiArwqDCoMKgwqDCoCBzbG90cyB3aXRo aW4gdGhlIGNsb2NrZWQgc2VyaWFsIEdQSU8gZGF0YSkuIFNpbmNlIGVhY2ggSFcgR1BJTyBpcyBi b3RoIGFuCj4gK8KgwqDCoMKgwqAgaW5wdXQgYW5kIGFuIG91dHB1dCwgd2UgcHJvdmlkZSBtYXhf bmdwaW9zICogMiBsaW5lcyBvbiBvdXIgZ3Bpb2NoaXAKPiArwqDCoMKgwqDCoCBkZXZpY2UuIFdl IGFsc28gdXNlIGl0IHRvIGRlZmluZSB0aGUgc3BsaXQgYmV0d2VlbiB0aGUgaW5wdXRzIGFuZAo+ ICvCoMKgwqDCoMKgIG91dHB1dHM7IHRoZSBpbnB1dHMgc3RhcnQgYXQgbGluZSAwLCB0aGUgb3V0 cHV0cyBzdGFydCBhdCBtYXhfbmdwaW9zLgoKTW9zdCBvZiB0aGlzIGRlc2NyaXB0aW9uIGlzIGJl dHRlciBzdWl0ZWQgdG8gdGhlIG5ncGlvcyBwcm9wZXJ0eSwgd2hpY2gKY29udHJvbHMgdGhlIG51 bWJlciBvZiBsaW5lcyB0aGF0IHRoZSBncGlvY2hpcCB3aWxsIGV4cG9zZS4KCkFsc28sIG1pbm9y IG5pdDogbWF4X25ncGlvcyAtPiBtYXgtbmdwaW9zLgoKSG93IGFib3V0IHNvbWV0aGluZyBsaWtl OgoKICBuZ3Bpb3M6CiAgICBkZXNjcmlwdGlvbjoKICAgICAgTnVtYmVyIG9mIEdQSU8gbGluZXMg dG8gZXhwb3NlLiBTaW5jZSBlYWNoIEhXIEdQSU8gaXMgYW4gaW5wdXQgYW5kIGFuCiAgICAgIG91 dHB1dCwgd2UgcHJvdmlkZSBuZ3Bpb3MgKiAyIGxpbmVzIG9uIG91ciBjaGlwIGRldmljZS4gV2Ug YWxzbyB1c2UgaXQKICAgICAgdG8gZGVmaW5lIHRoZSBzcGxpdCBiZXR3ZWVuIHRoZSBpbnB1dHMg YW5kIG91dHB1dHM7IHRoZSBpbnB1dHMgc3RhcnQgYXQKICAgICAgbGluZSAwLCB0aGUgb3V0cHV0 cyBzdGFydCBhdCBuZ3Bpb3MuCgogIG1heC1uZ3Bpb3M6CiAgICBkZXNjcmlwdGlvbjoKICAgICAg UmVwcmVzZW50cyB0aGUgbnVtYmVyIG9mIGFjdHVhbCBoYXJkd2FyZS1zdXBwb3J0ZWQgR1BJT3Mg KGllLCBzbG90cyB3aXRoaW4KICAgICAgdGhlIGNsb2NrZWQgc2VyaWFsIEdQSU8gZGF0YSksIGFu ZCB0aGVyZWZvcmUgdGhlIG1heGltdW0gdmFsdWUgZm9yCiAgICAgIHRoZSBuZ3Bpb3MgcHJvcGVy dHkKCj4gK8KgwqDCoCBtaW5pbXVtOiAwCj4gK8KgwqDCoCBtYXhpbXVtOiAxMjgKCldpbGwgdGhp cyBiZSB0aGUgY2FzZSBmb3IgYWxsIChmdXR1cmUpIGhhcmR3YXJlPyBDYW4gd2UgbGVhdmUgdGhp cwp1bmJvdW5kPwoKQ2hlZXJzLAoKCkplcmVteQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK