From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: PATCH: setup_vmcs_config: disable TSC scaling on unlike
 processors
Date: Tue, 6 Dec 2016 10:09:45 +0100
Message-ID: <f522b8f6-aea5-2fcd-575f-72272013173e@redhat.com>
References: <CADJev7-PpTvF4Wj+TusLD=4Q6fVMphsY8bovoFBbJ72xqTZq8Q@mail.gmail.com>
 <20161202150632.GA22204@potion>
 <59a3f1a2-5b9e-2ca7-5285-1469fef40f42@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: David Hildenbrand <david@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Don Bowman <db@donbowman.ca>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33377 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752099AbcLFJLC (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 6 Dec 2016 04:11:02 -0500
Received: by mail-wm0-f67.google.com with SMTP id u144so20083793wmu.0
        for <kvm@vger.kernel.org>; Tue, 06 Dec 2016 01:09:54 -0800 (PST)
In-Reply-To: <59a3f1a2-5b9e-2ca7-5285-1469fef40f42@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 06/12/2016 09:49, David Hildenbrand wrote:
>>>
>>> I feel a better solution is to mask off this capability on the one
>>> processor.
>>
>> I like the global toggle better -- it is less code with more uses.
> 
> (not having much insight) what speaks against allowing such features
> only if available on all CPUs symmetrically? I actually prefer having an
> automatism to some magic toggle.

I agree with David.  Just warn and proceed with the minimum common set
of features.

Paolo