From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1779C35257 for ; Wed, 16 Sep 2020 20:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89DEA20770 for ; Wed, 16 Sep 2020 20:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="MLK+e4h+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgIPUsK (ORCPT ); Wed, 16 Sep 2020 16:48:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53414 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbgIPRBO (ORCPT ); Wed, 16 Sep 2020 13:01:14 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08GG69EG186647; Wed, 16 Sep 2020 12:10:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=qM8GgVvqfUwPcqj9nGCvGWGoNwi0Zbhd1BMN07olGOI=; b=MLK+e4h+ske7As7axhaUEHzD6nLaC4NYjBipp/vm0ToomPivLa+dl4DkrySLOD8COPck n+BljFAhNQz5xluWMeD/pVzojhuS54eXt1NgoXg4H1yZxeX5o8CisVih4ITVTb78zT9N mjIFONFIH1Yva0wv6QmPt+hU+WBH9pcI4jBeZUzKt0529Tu3Dl8JKqumi56vIPKT3b/r 53ztkNrbvyDttHgVYmZjWIz0C8M1OyumWfE5b7Mgwmv2x1O/9c4RmefoPeopK3yrd4zt wPzZcfj2fvLh/Hh8Jtf660bcYwQR8hfNiT0+ESGlvjV8okn/7wrs1WRsZWo1KgZAfi6C 3A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 33knps8mvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Sep 2020 12:10:02 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08GG2aqZ168844; Wed, 16 Sep 2020 12:10:02 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 33knps8mum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Sep 2020 12:10:02 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08GFvL0Z026945; Wed, 16 Sep 2020 16:09:59 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06ams.nl.ibm.com with ESMTP id 33k9ge8nsm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Sep 2020 16:09:59 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08GG9uI018415886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Sep 2020 16:09:57 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D878411C050; Wed, 16 Sep 2020 16:09:56 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52AD811C04A; Wed, 16 Sep 2020 16:09:55 +0000 (GMT) Received: from pomme.local (unknown [9.145.183.110]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 16 Sep 2020 16:09:55 +0000 (GMT) Subject: Re: [PATCH v3 1/3] mm: replace memmap_context by meminit_context To: akpm@linux-foundation.org Cc: David Hildenbrand , Greg Kroah-Hartman , Oscar Salvador , mhocko@suse.com, linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200915121541.GD4649@dhcp22.suse.cz> <20200915132624.9723-1-ldufour@linux.ibm.com> <20200916063325.GK142621@kroah.com> <0b3f2eb1-0efa-a491-c509-d16a7e18d8e8@linux.ibm.com> <20200916074047.GA189144@kroah.com> <9e8d38b9-3875-0fd8-5f28-3502f33c2c34@linux.ibm.com> <95005625-b159-0d49-8334-3c6cdbb7f27a@redhat.com> From: Laurent Dufour Message-ID: Date: Wed, 16 Sep 2020 18:09:55 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <95005625-b159-0d49-8334-3c6cdbb7f27a@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-16_10:2020-09-16,2020-09-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=688 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160114 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 16/09/2020 à 09:52, David Hildenbrand a écrit : > On 16.09.20 09:47, Laurent Dufour wrote: >> Le 16/09/2020 à 09:40, Greg Kroah-Hartman a écrit : >>> On Wed, Sep 16, 2020 at 09:29:22AM +0200, Laurent Dufour wrote: >>>> Le 16/09/2020 à 08:33, Greg Kroah-Hartman a écrit : >>>>> On Tue, Sep 15, 2020 at 03:26:24PM +0200, Laurent Dufour wrote: >>>>>> The memmap_context enum is used to detect whether a memory operation is due >>>>>> to a hot-add operation or happening at boot time. >>>>>> >>>>>> Make it general to the hotplug operation and rename it as meminit_context. >>>>>> >>>>>> There is no functional change introduced by this patch >>>>>> >>>>>> Suggested-by: David Hildenbrand >>>>>> Signed-off-by: Laurent Dufour >>>>>> --- >>>>>> arch/ia64/mm/init.c | 6 +++--- >>>>>> include/linux/mm.h | 2 +- >>>>>> include/linux/mmzone.h | 11 ++++++++--- >>>>>> mm/memory_hotplug.c | 2 +- >>>>>> mm/page_alloc.c | 10 +++++----- >>>>>> 5 files changed, 18 insertions(+), 13 deletions(-) >>>>> >>>>> >>>>> >>>>> This is not the correct way to submit patches for inclusion in the >>>>> stable kernel tree. Please read: >>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>>>> for how to do this properly. >>>>> >>>>> >>>> >>>> Hi Greg, >>>> >>>> I'm sorry, I read that document few days ago before sending the series and >>>> again this morning, but I can't figure out what I missed (following option >>>> 1). >>>> >>>> Should the "Cc: stable@vger.kernel.org" tag be on each patch of the series >>>> even if the whole series has been sent to stable ? >>> >>> That should be on any patch you expect to show up in a stable kernel >>> release. >>> >>>> Should the whole series sent again (v4) instead of sending a fix as a reply to ? >>> >>> It's up to the maintainer what they want, but as it is, this patch is >>> not going to end up in stable kernel release (which it looks like is the >>> right thing to do...) >> >> Thanks a lot Greg. >> >> I'll send that single patch again with the Cc: stable tag. > > I think Andrew can add that when sending upstream. Andrew, can you do that? > While a single patch to fix + backport would be nicer, I don't see an > easy (!ugly) way to achieve the same without this cleanup. > > 1. We could rework patch #2 to pass a simple boolean flag, and a > follow-on patch to pass the context. Not sure if that's any better. > > 2. We could rework patch #2 to pass memmap_context first, and modify > patch #1 to also rename this instance. > > Maybe 2. might be reasonable (not sure if worth the trouble). @Greg any > preference? > >> >> I don't think the patch 3 need to be backported, it doesn't fix any issue and >> with the patch 1 and 2 applied, the BUG_ON should no more be triggered easily. > > Agreed. > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Dufour Date: Wed, 16 Sep 2020 16:09:55 +0000 Subject: Re: [PATCH v3 1/3] mm: replace memmap_context by meminit_context Message-Id: List-Id: References: <20200915121541.GD4649@dhcp22.suse.cz> <20200915132624.9723-1-ldufour@linux.ibm.com> <20200916063325.GK142621@kroah.com> <0b3f2eb1-0efa-a491-c509-d16a7e18d8e8@linux.ibm.com> <20200916074047.GA189144@kroah.com> <9e8d38b9-3875-0fd8-5f28-3502f33c2c34@linux.ibm.com> <95005625-b159-0d49-8334-3c6cdbb7f27a@redhat.com> In-Reply-To: <95005625-b159-0d49-8334-3c6cdbb7f27a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: akpm@linux-foundation.org Cc: David Hildenbrand , Greg Kroah-Hartman , Oscar Salvador , mhocko@suse.com, linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Le 16/09/2020 à 09:52, David Hildenbrand a écrit : > On 16.09.20 09:47, Laurent Dufour wrote: >> Le 16/09/2020 à 09:40, Greg Kroah-Hartman a écrit : >>> On Wed, Sep 16, 2020 at 09:29:22AM +0200, Laurent Dufour wrote: >>>> Le 16/09/2020 à 08:33, Greg Kroah-Hartman a écrit : >>>>> On Tue, Sep 15, 2020 at 03:26:24PM +0200, Laurent Dufour wrote: >>>>>> The memmap_context enum is used to detect whether a memory operation is due >>>>>> to a hot-add operation or happening at boot time. >>>>>> >>>>>> Make it general to the hotplug operation and rename it as meminit_context. >>>>>> >>>>>> There is no functional change introduced by this patch >>>>>> >>>>>> Suggested-by: David Hildenbrand >>>>>> Signed-off-by: Laurent Dufour >>>>>> --- >>>>>> arch/ia64/mm/init.c | 6 +++--- >>>>>> include/linux/mm.h | 2 +- >>>>>> include/linux/mmzone.h | 11 ++++++++--- >>>>>> mm/memory_hotplug.c | 2 +- >>>>>> mm/page_alloc.c | 10 +++++----- >>>>>> 5 files changed, 18 insertions(+), 13 deletions(-) >>>>> >>>>> >>>>> >>>>> This is not the correct way to submit patches for inclusion in the >>>>> stable kernel tree. Please read: >>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >>>>> for how to do this properly. >>>>> >>>>> >>>> >>>> Hi Greg, >>>> >>>> I'm sorry, I read that document few days ago before sending the series and >>>> again this morning, but I can't figure out what I missed (following option >>>> 1). >>>> >>>> Should the "Cc: stable@vger.kernel.org" tag be on each patch of the series >>>> even if the whole series has been sent to stable ? >>> >>> That should be on any patch you expect to show up in a stable kernel >>> release. >>> >>>> Should the whole series sent again (v4) instead of sending a fix as a reply to ? >>> >>> It's up to the maintainer what they want, but as it is, this patch is >>> not going to end up in stable kernel release (which it looks like is the >>> right thing to do...) >> >> Thanks a lot Greg. >> >> I'll send that single patch again with the Cc: stable tag. > > I think Andrew can add that when sending upstream. Andrew, can you do that? > While a single patch to fix + backport would be nicer, I don't see an > easy (!ugly) way to achieve the same without this cleanup. > > 1. We could rework patch #2 to pass a simple boolean flag, and a > follow-on patch to pass the context. Not sure if that's any better. > > 2. We could rework patch #2 to pass memmap_context first, and modify > patch #1 to also rename this instance. > > Maybe 2. might be reasonable (not sure if worth the trouble). @Greg any > preference? > >> >> I don't think the patch 3 need to be backported, it doesn't fix any issue and >> with the patch 1 and 2 applied, the BUG_ON should no more be triggered easily. > > Agreed. > >