From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EE2C43219 for ; Thu, 2 May 2019 10:45:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39079208C4 for ; Thu, 2 May 2019 10:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfEBKpI (ORCPT ); Thu, 2 May 2019 06:45:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:38788 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726353AbfEBKpI (ORCPT ); Thu, 2 May 2019 06:45:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4ABD8AEF6; Thu, 2 May 2019 10:45:06 +0000 (UTC) Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier To: Greg Kroah-Hartman Cc: Nishad Kamdar , Manivannan Sadhasivam , Michael Turquette , Stephen Boyd , Joe Perches , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org References: <20190501070707.GA5619@nishad> <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> <20190502070746.GA16247@kroah.com> <315de620-b638-aea4-d8d2-e00f5a493625@suse.de> <20190502103848.GA17256@kroah.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: Date: Thu, 2 May 2019 12:45:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502103848.GA17256@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.05.19 um 12:38 schrieb Greg Kroah-Hartman: > On Thu, May 02, 2019 at 12:25:36PM +0200, Andreas Färber wrote: >> Am 02.05.19 um 09:07 schrieb Greg Kroah-Hartman: >>> On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas Färber wrote: >>>> + linux-actions >>>> >>>> Am 01.05.19 um 09:07 schrieb Nishad Kamdar: >>>>> This patch corrects the SPDX License Identifier style >>>>> in header files related to Clock Drivers for Actions Semi Socs. >>>>> For C header files Documentation/process/license-rules.rst >>>>> mandates C-like comments (opposed to C source files where >>>>> C++ style should be used) >>>> [...] >>>>> drivers/clk/actions/owl-common.h | 2 +- >>>>> drivers/clk/actions/owl-composite.h | 2 +- >>>>> drivers/clk/actions/owl-divider.h | 2 +- >>>>> drivers/clk/actions/owl-factor.h | 2 +- >>>>> drivers/clk/actions/owl-fixed-factor.h | 2 +- >>>>> drivers/clk/actions/owl-gate.h | 2 +- >>>>> drivers/clk/actions/owl-mux.h | 2 +- >>>>> drivers/clk/actions/owl-pll.h | 2 +- >>>>> drivers/clk/actions/owl-reset.h | 2 +- >>>>> 9 files changed, 9 insertions(+), 9 deletions(-) >>>> >>>> Where's the practical benefit of this patch? These are all private >>>> headers used from C files, so they can handle C++ comments just fine, >>>> otherwise we would've seen build failures. >>> >>> Please read Documentation/process/license-rules.rst, the section >>> entitled "Style", for what the documented formats are for SPDX lines, >>> depending on the file type. >> >> That does in no way answer my question! You conveniently dropped my >> paragraph indicating that I understand why we would do that for public >> headers in include/, but none of these private headers here are included >> in .lds files. So there really seems to be no benefit of switching from >> one style to another for in-tree code. > > It should answer the question, it was "decreed" that all header files > use /* */, and all C files use // for their SPDX lines, so we documented > it that way. > > Yes, maybe it doesn't make "sense" in that this really is only needed > for headers that get included into asm files, which is why we had to do > it this way, but it's better to be consistant than to have random > breakages at times. > > It's not an issue of public headers at all, sorry. > > Consistency is good, as we can have automatic tools check these types of > things, which is the only way to reliably handle the format of something > that needs to be in every file in a project with 63,100+ different > files. Okay, if it's about consistency then there will be more cases to fix. What about this one: My interpretation of the documentation has been that I should end the comment after the identifiers: /* SPDX-... */ /* ... */ Some people deviate by doing /* SPDX-... * foo */ So the documentation may need to be extended to clarify that for full consistency, as well as clarify the previous scenario: "If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used." To me that reads very different from what you just said above. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2E4C43219 for ; Thu, 2 May 2019 10:45:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF88E2075E for ; Thu, 2 May 2019 10:45:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a3mGUBhB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF88E2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PDrezqGy4wO+cQ8+ALQwVDkGwXV8Oehq1/jaQz5wyeg=; b=a3mGUBhBrpGdpa toOHHIndEfVX+pwH8EeLDBrI3+rpDosCkIU9WeBYLoAhHp8nq2pWwEdAeDtqOsSm3jw1efveJuuTz jzUIu4F6gYE4O01ZrAiZkHiElE7Ns/MVFSpZ67G5yNxw/a3R25UiCoezidU6ayuQvBUUiSM4PurOR t0YlYrESamWbtP/GnPNeGGCH/AwvXeyiztBXDdHtoAWa8/Oaw/GElCHKay23xzbOr2orfE5BYMRNG HO8tPEw6OgM4JTEmrFMacMNykL3xrYWmfShZc6YPIUH2iGN0e+RIpuIOTsR903iTcugNXb8kzzxTp aK96uRD4YvX7AqEX0dSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM9DN-0003Qb-2O; Thu, 02 May 2019 10:45:21 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM9D9-0002Th-Ux; Thu, 02 May 2019 10:45:17 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4ABD8AEF6; Thu, 2 May 2019 10:45:06 +0000 (UTC) Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier To: Greg Kroah-Hartman References: <20190501070707.GA5619@nishad> <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> <20190502070746.GA16247@kroah.com> <315de620-b638-aea4-d8d2-e00f5a493625@suse.de> <20190502103848.GA17256@kroah.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: Date: Thu, 2 May 2019 12:45:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502103848.GA17256@kroah.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190502_034508_404261_3DF75939 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishad Kamdar , Stephen Boyd , Michael Turquette , Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Joe Perches , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gMDIuMDUuMTkgdW0gMTI6Mzggc2NocmllYiBHcmVnIEtyb2FoLUhhcnRtYW46Cj4gT24gVGh1 LCBNYXkgMDIsIDIwMTkgYXQgMTI6MjU6MzZQTSArMDIwMCwgQW5kcmVhcyBGw6RyYmVyIHdyb3Rl Ogo+PiBBbSAwMi4wNS4xOSB1bSAwOTowNyBzY2hyaWViIEdyZWcgS3JvYWgtSGFydG1hbjoKPj4+ IE9uIFdlZCwgTWF5IDAxLCAyMDE5IGF0IDEwOjIwOjQ0UE0gKzAyMDAsIEFuZHJlYXMgRsOkcmJl ciB3cm90ZToKPj4+PiArIGxpbnV4LWFjdGlvbnMKPj4+Pgo+Pj4+IEFtIDAxLjA1LjE5IHVtIDA5 OjA3IHNjaHJpZWIgTmlzaGFkIEthbWRhcjoKPj4+Pj4gVGhpcyBwYXRjaCBjb3JyZWN0cyB0aGUg U1BEWCBMaWNlbnNlIElkZW50aWZpZXIgc3R5bGUKPj4+Pj4gaW4gaGVhZGVyIGZpbGVzIHJlbGF0 ZWQgdG8gQ2xvY2sgRHJpdmVycyBmb3IgQWN0aW9ucyBTZW1pIFNvY3MuCj4+Pj4+IEZvciBDIGhl YWRlciBmaWxlcyBEb2N1bWVudGF0aW9uL3Byb2Nlc3MvbGljZW5zZS1ydWxlcy5yc3QKPj4+Pj4g bWFuZGF0ZXMgQy1saWtlIGNvbW1lbnRzIChvcHBvc2VkIHRvIEMgc291cmNlIGZpbGVzIHdoZXJl Cj4+Pj4+IEMrKyBzdHlsZSBzaG91bGQgYmUgdXNlZCkKPj4+PiBbLi4uXQo+Pj4+PiAgZHJpdmVy cy9jbGsvYWN0aW9ucy9vd2wtY29tbW9uLmggICAgICAgfCAyICstCj4+Pj4+ICBkcml2ZXJzL2Ns ay9hY3Rpb25zL293bC1jb21wb3NpdGUuaCAgICB8IDIgKy0KPj4+Pj4gIGRyaXZlcnMvY2xrL2Fj dGlvbnMvb3dsLWRpdmlkZXIuaCAgICAgIHwgMiArLQo+Pj4+PiAgZHJpdmVycy9jbGsvYWN0aW9u cy9vd2wtZmFjdG9yLmggICAgICAgfCAyICstCj4+Pj4+ICBkcml2ZXJzL2Nsay9hY3Rpb25zL293 bC1maXhlZC1mYWN0b3IuaCB8IDIgKy0KPj4+Pj4gIGRyaXZlcnMvY2xrL2FjdGlvbnMvb3dsLWdh dGUuaCAgICAgICAgIHwgMiArLQo+Pj4+PiAgZHJpdmVycy9jbGsvYWN0aW9ucy9vd2wtbXV4Lmgg ICAgICAgICAgfCAyICstCj4+Pj4+ICBkcml2ZXJzL2Nsay9hY3Rpb25zL293bC1wbGwuaCAgICAg ICAgICB8IDIgKy0KPj4+Pj4gIGRyaXZlcnMvY2xrL2FjdGlvbnMvb3dsLXJlc2V0LmggICAgICAg IHwgMiArLQo+Pj4+PiAgOSBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDkgZGVsZXRp b25zKC0pCj4+Pj4KPj4+PiBXaGVyZSdzIHRoZSBwcmFjdGljYWwgYmVuZWZpdCBvZiB0aGlzIHBh dGNoPyBUaGVzZSBhcmUgYWxsIHByaXZhdGUKPj4+PiBoZWFkZXJzIHVzZWQgZnJvbSBDIGZpbGVz LCBzbyB0aGV5IGNhbiBoYW5kbGUgQysrIGNvbW1lbnRzIGp1c3QgZmluZSwKPj4+PiBvdGhlcndp c2Ugd2Ugd291bGQndmUgc2VlbiBidWlsZCBmYWlsdXJlcy4KPj4+Cj4+PiBQbGVhc2UgcmVhZCBE b2N1bWVudGF0aW9uL3Byb2Nlc3MvbGljZW5zZS1ydWxlcy5yc3QsIHRoZSBzZWN0aW9uCj4+PiBl bnRpdGxlZCAiU3R5bGUiLCBmb3Igd2hhdCB0aGUgZG9jdW1lbnRlZCBmb3JtYXRzIGFyZSBmb3Ig U1BEWCBsaW5lcywKPj4+IGRlcGVuZGluZyBvbiB0aGUgZmlsZSB0eXBlLgo+Pgo+PiBUaGF0IGRv ZXMgaW4gbm8gd2F5IGFuc3dlciBteSBxdWVzdGlvbiEgWW91IGNvbnZlbmllbnRseSBkcm9wcGVk IG15Cj4+IHBhcmFncmFwaCBpbmRpY2F0aW5nIHRoYXQgSSB1bmRlcnN0YW5kIHdoeSB3ZSB3b3Vs ZCBkbyB0aGF0IGZvciBwdWJsaWMKPj4gaGVhZGVycyBpbiBpbmNsdWRlLywgYnV0IG5vbmUgb2Yg dGhlc2UgcHJpdmF0ZSBoZWFkZXJzIGhlcmUgYXJlIGluY2x1ZGVkCj4+IGluIC5sZHMgZmlsZXMu IFNvIHRoZXJlIHJlYWxseSBzZWVtcyB0byBiZSBubyBiZW5lZml0IG9mIHN3aXRjaGluZyBmcm9t Cj4+IG9uZSBzdHlsZSB0byBhbm90aGVyIGZvciBpbi10cmVlIGNvZGUuCj4gCj4gSXQgc2hvdWxk IGFuc3dlciB0aGUgcXVlc3Rpb24sIGl0IHdhcyAiZGVjcmVlZCIgdGhhdCBhbGwgaGVhZGVyIGZp bGVzCj4gdXNlIC8qICovLCBhbmQgYWxsIEMgZmlsZXMgdXNlIC8vIGZvciB0aGVpciBTUERYIGxp bmVzLCBzbyB3ZSBkb2N1bWVudGVkCj4gaXQgdGhhdCB3YXkuCj4gCj4gWWVzLCBtYXliZSBpdCBk b2Vzbid0IG1ha2UgInNlbnNlIiBpbiB0aGF0IHRoaXMgcmVhbGx5IGlzIG9ubHkgbmVlZGVkCj4g Zm9yIGhlYWRlcnMgdGhhdCBnZXQgaW5jbHVkZWQgaW50byBhc20gZmlsZXMsIHdoaWNoIGlzIHdo eSB3ZSBoYWQgdG8gZG8KPiBpdCB0aGlzIHdheSwgYnV0IGl0J3MgYmV0dGVyIHRvIGJlIGNvbnNp c3RhbnQgdGhhbiB0byBoYXZlIHJhbmRvbQo+IGJyZWFrYWdlcyBhdCB0aW1lcy4KPiAKPiBJdCdz IG5vdCBhbiBpc3N1ZSBvZiBwdWJsaWMgaGVhZGVycyBhdCBhbGwsIHNvcnJ5Lgo+IAo+IENvbnNp c3RlbmN5IGlzIGdvb2QsIGFzIHdlIGNhbiBoYXZlIGF1dG9tYXRpYyB0b29scyBjaGVjayB0aGVz ZSB0eXBlcyBvZgo+IHRoaW5ncywgd2hpY2ggaXMgdGhlIG9ubHkgd2F5IHRvIHJlbGlhYmx5IGhh bmRsZSB0aGUgZm9ybWF0IG9mIHNvbWV0aGluZwo+IHRoYXQgbmVlZHMgdG8gYmUgaW4gZXZlcnkg ZmlsZSBpbiBhIHByb2plY3Qgd2l0aCA2MywxMDArIGRpZmZlcmVudAo+IGZpbGVzLgoKT2theSwg aWYgaXQncyBhYm91dCBjb25zaXN0ZW5jeSB0aGVuIHRoZXJlIHdpbGwgYmUgbW9yZSBjYXNlcyB0 byBmaXguCgpXaGF0IGFib3V0IHRoaXMgb25lOgoKTXkgaW50ZXJwcmV0YXRpb24gb2YgdGhlIGRv Y3VtZW50YXRpb24gaGFzIGJlZW4gdGhhdCBJIHNob3VsZCBlbmQgdGhlCmNvbW1lbnQgYWZ0ZXIg dGhlIGlkZW50aWZpZXJzOgoKLyogU1BEWC0uLi4gKi8KLyogLi4uCiAqLwoKU29tZSBwZW9wbGUg ZGV2aWF0ZSBieSBkb2luZwoKLyogU1BEWC0uLi4KICogZm9vCiAqLwoKU28gdGhlIGRvY3VtZW50 YXRpb24gbWF5IG5lZWQgdG8gYmUgZXh0ZW5kZWQgdG8gY2xhcmlmeSB0aGF0IGZvciBmdWxsCmNv bnNpc3RlbmN5LCBhcyB3ZWxsIGFzIGNsYXJpZnkgdGhlIHByZXZpb3VzIHNjZW5hcmlvOgogICJJ ZiBhIHNwZWNpZmljIHRvb2wgY2Fubm90IGhhbmRsZSB0aGUgc3RhbmRhcmQgY29tbWVudCBzdHls ZSwgdGhlbiB0aGUKICAgYXBwcm9wcmlhdGUgY29tbWVudCBtZWNoYW5pc20gd2hpY2ggdGhlIHRv b2wgYWNjZXB0cyBzaGFsbCBiZSB1c2VkLiIKVG8gbWUgdGhhdCByZWFkcyB2ZXJ5IGRpZmZlcmVu dCBmcm9tIHdoYXQgeW91IGp1c3Qgc2FpZCBhYm92ZS4KClRoYW5rcywKQW5kcmVhcwoKLS0gClNV U0UgTGludXggR21iSCwgTWF4ZmVsZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnLCBHZXJtYW55CkdG OiBGZWxpeCBJbWVuZMO2cmZmZXIsIE1hcnkgSGlnZ2lucywgU3JpIFJhc2lhaApIUkIgMjEyODQg KEFHIE7DvHJuYmVyZykKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK