All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	Niklas Cassel <niklas.cassel@axis.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: add drop transmit status feature
Date: Tue, 11 Apr 2017 16:10:05 +0100	[thread overview]
Message-ID: <f5249fd2-0d68-3cdc-effe-fc0a677ed263@synopsys.com> (raw)
In-Reply-To: <20170411150458.GK27307@lunn.ch>

Hi Andrew,

Às 4:04 PM de 4/11/2017, Andrew Lunn escreveu:
> On Tue, Apr 11, 2017 at 03:44:10PM +0100, Joao Pinto wrote:
>> When the Drop Transmit Status bit is set, the Tx packet status
>> received from the MAC is dropped in the MTL. When this bit is reset,
>> the Tx packet status received from the MAC is forwarded to the
>> application. This feature will cause a performance improvement.
> 
> Hi Joao
> 
> Is there a reason not to turn this on by default?

The only reason is not to cause problems for other people setup by introducing a
new variable. In my setup is set by default.

@Niklas and Thierry: Could you please test this feature in order to see if it
boosts your perfomance? If it works fine in your setup we can follow Andrew idea
to turn it on by default.

> 
>    Andrew
> 

Thanks.

  reply	other threads:[~2017-04-11 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 14:44 [PATCH] net: stmmac: add drop transmit status feature Joao Pinto
2017-04-11 15:04 ` Andrew Lunn
2017-04-11 15:10   ` Joao Pinto [this message]
2017-04-11 18:53 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5249fd2-0d68-3cdc-effe-fc0a677ed263@synopsys.com \
    --to=joao.pinto@synopsys.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.