From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2797CC433F5 for ; Tue, 5 Oct 2021 19:40:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C7D161372 for ; Tue, 5 Oct 2021 19:40:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C7D161372 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXqIy-0002pf-QT for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 15:40:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXqGg-0001In-SJ for qemu-devel@nongnu.org; Tue, 05 Oct 2021 15:38:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXqGa-0006MK-5m for qemu-devel@nongnu.org; Tue, 05 Oct 2021 15:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633462698; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y6Q06zG60cHh6k1SzwElQstJ18anZb4XfsmLDORUjSc=; b=A4jlxKQj9GxflrDocHFSU9pfuvZc7+aMfx1b76AblnBuyyTeDQ0D+quexgpG9CBnuBI4k/ gDbikW9xthwEdgXa9erWKUlC+l8MRvqdiE+/ph29USMrBcTqXejdJ/COjIV6MCaML5Jcm0 +C+rvhMeXqWK0s+I1OUnxoSZIf+TeC0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-hg0Rl9AfP4Cac4U8dLKbaA-1; Tue, 05 Oct 2021 15:38:17 -0400 X-MC-Unique: hg0Rl9AfP4Cac4U8dLKbaA-1 Received: by mail-wr1-f70.google.com with SMTP id n18-20020adff092000000b001609d9081d4so149032wro.18 for ; Tue, 05 Oct 2021 12:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=y6Q06zG60cHh6k1SzwElQstJ18anZb4XfsmLDORUjSc=; b=zgB7HJFaWb+fI+S4v1I43w57Vm8o2g3OpbURgWO0LvNhiB5PwDelBCOLr6zR39pgiO ch7W+1aa+Iu+pKuGvRwzTBRgLlxBNYEyUnk0F3qrr6qO7mItL6lskz23qr1VbNgUF533 iSyvtVlWLE5UFTJTLDeG3Ulcx535u/mtOUM4QAxtkHVIztk6mb/hdvRWrZLjYnOUqhrc aVtmOu9GbH6Mm+YPSFLjcc1bdCFgfW3iiUXpQE5cBQmRSrbXOYrmaB/NV8N6WuYD1by1 lzmOluhFp+5yYHhaGWfZz9ch2MItH8U/QaWyYIpVl10oLeHw4c88FX9PWgZ18SUTk0rA W/pA== X-Gm-Message-State: AOAM531oBRnnfLy29nAxPHt/nDvaGYs94BoL8mGlJ8Eng44HFx8v2BV8 jIExY3TbBG4g1mhsfFVskBc6AhLSipXuDgP1IMZWU51lSEx+MbqKUOk3Xo01WbkuGja/rZWaAX9 NGeN8XW3zv+aCAgQ= X-Received: by 2002:adf:a34b:: with SMTP id d11mr18820476wrb.107.1633462696234; Tue, 05 Oct 2021 12:38:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXwHbT+/yyJujZ2MKAx26L0Br6Ou3PSv6ZWRk7FCt9lC3hXLclCwjm/4vV+L7PGN+glJumwQ== X-Received: by 2002:adf:a34b:: with SMTP id d11mr18820443wrb.107.1633462696003; Tue, 05 Oct 2021 12:38:16 -0700 (PDT) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id k128sm3113799wme.41.2021.10.05.12.38.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:38:15 -0700 (PDT) Subject: Re: [PATCH v4 10/11] tests/acpi: add expected blob for VIOT test on virt machine To: Jean-Philippe Brucker , imammedo@redhat.com References: <20211001173358.863017-1-jean-philippe@linaro.org> <20211001173358.863017-11-jean-philippe@linaro.org> From: Eric Auger Message-ID: Date: Tue, 5 Oct 2021 21:38:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20211001173358.863017-11-jean-philippe@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, ani@anisinha.ca, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Jean, On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote: > The VIOT blob contains the following: > > [000h 0000 4] Signature : "VIOT" [Virtual I/O Translation Table] > [004h 0004 4] Table Length : 00000058 > [008h 0008 1] Revision : 00 > [009h 0009 1] Checksum : 66 > [00Ah 0010 6] Oem ID : "BOCHS " > [010h 0016 8] Oem Table ID : "BXPC " > [018h 0024 4] Oem Revision : 00000001 > [01Ch 0028 4] Asl Compiler ID : "BXPC" > [020h 0032 4] Asl Compiler Revision : 00000001 > > [024h 0036 2] Node count : 0002 > [026h 0038 2] Node offset : 0030 > [028h 0040 8] Reserved : 0000000000000000 > > [030h 0048 1] Type : 03 [VirtIO-PCI IOMMU] > [031h 0049 1] Reserved : 00 > [032h 0050 2] Length : 0010 > > [034h 0052 2] PCI Segment : 0000 > [036h 0054 2] PCI BDF number : 0008 > [038h 0056 8] Reserved : 0000000000000000 > > [040h 0064 1] Type : 01 [PCI Range] > [041h 0065 1] Reserved : 00 > [042h 0066 2] Length : 0018 > > [044h 0068 4] Endpoint start : 00000000 > [048h 0072 2] PCI Segment start : 0000 > [04Ah 0074 2] PCI Segment end : 0000 > [04Ch 0076 2] PCI BDF start : 0000 > [04Eh 0078 2] PCI BDF end : 00FF > [050h 0080 2] Output node : 0030 > [052h 0082 6] Reserved : 000000000000 I noticed the spec does not clearly say the virtio-iommu-pci BDF does not need to be excluded from the PCI range. Shouldn't it be clarified? Besides Reviewed-by: Eric Auger Eric > > Signed-off-by: Jean-Philippe Brucker > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > tests/data/acpi/virt/VIOT | Bin 0 -> 88 bytes > 2 files changed, 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index 29b5b1eabc..fa213e4738 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,4 +1,3 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/virt/VIOT", > "tests/data/acpi/q35/DSDT.viot", > "tests/data/acpi/q35/VIOT.viot", > diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/VIOT > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..921f40d88c28ba2171a4d664e119914335309e7d 100644 > GIT binary patch > literal 88 > zcmWIZ^bd((0D?3pe`k+i1*eDrX9XZ&1PX!JAexE60Hgv8m>C3sGzXN&z`)2L0cSHX > I{D-Rq0Q5fy0RR91 > > literal 0 > HcmV?d00001 >