From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DF2C433E0 for ; Wed, 20 Jan 2021 08:13:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 177C523131 for ; Wed, 20 Jan 2021 08:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 177C523131 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CCA06E14D; Wed, 20 Jan 2021 08:13:44 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC0D86E14D for ; Wed, 20 Jan 2021 08:13:42 +0000 (UTC) IronPort-SDR: mlvaaw6dTSwQxjlnItM/aaaBzXuE2pvhTOMf3oDhMdPZ+a2Jg1ZbN7cT2Mf8NPlVaIgsR58URY +9i5oH+/BHvw== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="166158092" X-IronPort-AV: E=Sophos;i="5.79,360,1602572400"; d="scan'208";a="166158092" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 00:13:41 -0800 IronPort-SDR: CejaFqYtJ9XAhSeXsuxZ/IxgW7oqj81DymdpT/7TrK/QSqyCMobTbSfFY5bC5x0lyQHLCvuSki g2balhLYKbXQ== X-IronPort-AV: E=Sophos;i="5.79,360,1602572400"; d="scan'208";a="384599622" Received: from dgravino-mobl1.ger.corp.intel.com (HELO [10.249.41.166]) ([10.249.41.166]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 00:13:36 -0800 To: Umesh Nerlige Ramappa , intel-gfx@lists.freedesktop.org References: <20210120012111.44184-1-umesh.nerlige.ramappa@intel.com> <20210120012111.44184-2-umesh.nerlige.ramappa@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Wed, 20 Jan 2021 08:13:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210120012111.44184-2-umesh.nerlige.ramappa@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check for all subplatform bits X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 20/01/2021 01:21, Umesh Nerlige Ramappa wrote: > Current code is checking only 2 bits in the subplatform, but actually 3 > bits are allocated for the field. Check all 3 bits. > > Fixes: 805446c8347c9 (drm/i915: Introduce concept of a sub-platform) > Cc: Tvrtko Ursulin > Signed-off-by: Umesh Nerlige Ramappa > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 8376cff5ba86..38eca00c6f09 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1343,7 +1343,7 @@ intel_subplatform(const struct intel_runtime_info *info, enum intel_platform p) > { > const unsigned int pi = __platform_mask_index(info, p); > > - return info->platform_mask[pi] & INTEL_SUBPLATFORM_BITS; > + return info->platform_mask[pi] & ((1 << INTEL_SUBPLATFORM_BITS) - 1); > } > > static __always_inline bool > Yep. Luckily it affected only printout in the welcome message and error capture metadata. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx