From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35438C43332 for ; Wed, 20 Jan 2021 17:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AF42233F6 for ; Wed, 20 Jan 2021 17:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731446AbhATR3m (ORCPT ); Wed, 20 Jan 2021 12:29:42 -0500 Received: from protonic.xs4all.nl ([83.163.252.89]:57018 "EHLO protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732034AbhATOsd (ORCPT ); Wed, 20 Jan 2021 09:48:33 -0500 Received: from fiber.protonic.nl (edge2.prtnl [192.168.1.170]) by sparta.prtnl (Postfix) with ESMTP id 86D9144A022A; Wed, 20 Jan 2021 15:47:23 +0100 (CET) MIME-Version: 1.0 Date: Wed, 20 Jan 2021 15:47:23 +0100 From: robin To: Oleksij Rempel Cc: Mark Rutland , Rob Herring , Sascha Hauer , Shawn Guo , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , David Jander , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node Reply-To: robin@protonic.nl In-Reply-To: <20210120142217.29652-5-o.rempel@pengutronix.de> References: <20210120142217.29652-1-o.rempel@pengutronix.de> <20210120142217.29652-5-o.rempel@pengutronix.de> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: robin@protonic.nl Organization: Protonic Holland Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-20 15:22, Oleksij Rempel wrote: > Add touchscreen support to the Protonic VT7 board. > > Co-Developed-by: Robin van der Gracht > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts > b/arch/arm/boot/dts/imx6dl-prtvt7.dts > index d9cb1e41cc10..63ae2065834c 100644 > --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts > @@ -266,6 +266,26 @@ &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi2>; > status = "okay"; > + > + touchscreen@0 { > + compatible = "ti,tsc2046"; > + reg = <0>; > + pinctrl-0 = <&pinctrl_tsc>; > + pinctrl-names ="default"; > + spi-max-frequency = <100000>; > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>; > + > + touchscreen-inverted-x; > + touchscreen-inverted-y; Please remove both inverted properties since it's not inverted. > + touchscreen-max-pressure = <4095>; > + > + ti,vref-delay-usecs = /bits/ 16 <100>; > + ti,x-plate-ohms = /bits/ 16 <800>; > + ti,y-plate-ohms = /bits/ 16 <300>; > + > + wakeup-source; > + }; > }; > > &i2c1 { Robin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E11BDC433DB for ; Wed, 20 Jan 2021 14:49:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F12623382 for ; Wed, 20 Jan 2021 14:49:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F12623382 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=protonic.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To: Subject:To:From:Date:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GqXYGmW5lgAQ++oEFqoaeTfaSr++JhvvO6RZvRaJv7Q=; b=Dh5YBkAguXR3oy5nQzQchNHUr Q1e2J/bU+gFdUMq4czvCI05VDFAAe+FdqK8A1W7xyDQ1+WiNPVg7dBn6B4QXVGgwoC1Cu3F/miiFQ yOKhOp87gPzXDTnuEyxoPOXIX6RpBYvMyUCYyKVMe7k8ODhaJSr0shcQfMRTv51oqtjhaG67PAk7v CbeEOLryERN9F1zm0beHGCIOg3bh97mty/s5aTkGTBu7If5AqYZWMiwpwbRJsQi1OPMQZ5ws2HcGy CJ1zGNoDEuJQRWChbe2U0artFyCNcu0aA7zQ0ItpF8sTjm5DuyPUCjsKVoisom44xgUZzbiC3nrAF 3OP/X0e8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Elh-0000nM-7R; Wed, 20 Jan 2021 14:47:33 +0000 Received: from protonic.xs4all.nl ([83.163.252.89]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Ele-0000mh-Bn for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 14:47:31 +0000 Received: from fiber.protonic.nl (edge2.prtnl [192.168.1.170]) by sparta.prtnl (Postfix) with ESMTP id 86D9144A022A; Wed, 20 Jan 2021 15:47:23 +0100 (CET) MIME-Version: 1.0 Date: Wed, 20 Jan 2021 15:47:23 +0100 From: robin To: Oleksij Rempel Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node In-Reply-To: <20210120142217.29652-5-o.rempel@pengutronix.de> References: <20210120142217.29652-1-o.rempel@pengutronix.de> <20210120142217.29652-5-o.rempel@pengutronix.de> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: robin@protonic.nl Organization: Protonic Holland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_094730_503690_7A330B83 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: robin@protonic.nl Cc: Mark Rutland , devicetree@vger.kernel.org, Fabio Estevam , Pengutronix Kernel Team , dri-devel@lists.freedesktop.org, David Airlie , Sam Ravnborg , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , NXP Linux Team , Daniel Vetter , David Jander , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-01-20 15:22, Oleksij Rempel wrote: > Add touchscreen support to the Protonic VT7 board. > > Co-Developed-by: Robin van der Gracht > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts > b/arch/arm/boot/dts/imx6dl-prtvt7.dts > index d9cb1e41cc10..63ae2065834c 100644 > --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts > @@ -266,6 +266,26 @@ &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi2>; > status = "okay"; > + > + touchscreen@0 { > + compatible = "ti,tsc2046"; > + reg = <0>; > + pinctrl-0 = <&pinctrl_tsc>; > + pinctrl-names ="default"; > + spi-max-frequency = <100000>; > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>; > + > + touchscreen-inverted-x; > + touchscreen-inverted-y; Please remove both inverted properties since it's not inverted. > + touchscreen-max-pressure = <4095>; > + > + ti,vref-delay-usecs = /bits/ 16 <100>; > + ti,x-plate-ohms = /bits/ 16 <800>; > + ti,y-plate-ohms = /bits/ 16 <300>; > + > + wakeup-source; > + }; > }; > > &i2c1 { Robin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3D0C433E0 for ; Thu, 21 Jan 2021 08:53:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DDED239D3 for ; Thu, 21 Jan 2021 08:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DDED239D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=protonic.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F5606E8E4; Thu, 21 Jan 2021 08:52:35 +0000 (UTC) X-Greylist: delayed 487 seconds by postgrey-1.36 at gabe; Wed, 20 Jan 2021 14:55:32 UTC Received: from protonic.xs4all.nl (protonic.xs4all.nl [83.163.252.89]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B46B6E3B7 for ; Wed, 20 Jan 2021 14:55:32 +0000 (UTC) Received: from fiber.protonic.nl (edge2.prtnl [192.168.1.170]) by sparta.prtnl (Postfix) with ESMTP id 86D9144A022A; Wed, 20 Jan 2021 15:47:23 +0100 (CET) MIME-Version: 1.0 Date: Wed, 20 Jan 2021 15:47:23 +0100 From: robin To: Oleksij Rempel Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node In-Reply-To: <20210120142217.29652-5-o.rempel@pengutronix.de> References: <20210120142217.29652-1-o.rempel@pengutronix.de> <20210120142217.29652-5-o.rempel@pengutronix.de> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: robin@protonic.nl Organization: Protonic Holland X-Mailman-Approved-At: Thu, 21 Jan 2021 08:52:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: robin@protonic.nl Cc: Mark Rutland , devicetree@vger.kernel.org, Pengutronix Kernel Team , dri-devel@lists.freedesktop.org, David Airlie , Sam Ravnborg , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , NXP Linux Team , David Jander , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-01-20 15:22, Oleksij Rempel wrote: > Add touchscreen support to the Protonic VT7 board. > > Co-Developed-by: Robin van der Gracht > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts > b/arch/arm/boot/dts/imx6dl-prtvt7.dts > index d9cb1e41cc10..63ae2065834c 100644 > --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts > @@ -266,6 +266,26 @@ &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi2>; > status = "okay"; > + > + touchscreen@0 { > + compatible = "ti,tsc2046"; > + reg = <0>; > + pinctrl-0 = <&pinctrl_tsc>; > + pinctrl-names ="default"; > + spi-max-frequency = <100000>; > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>; > + > + touchscreen-inverted-x; > + touchscreen-inverted-y; Please remove both inverted properties since it's not inverted. > + touchscreen-max-pressure = <4095>; > + > + ti,vref-delay-usecs = /bits/ 16 <100>; > + ti,x-plate-ohms = /bits/ 16 <800>; > + ti,y-plate-ohms = /bits/ 16 <300>; > + > + wakeup-source; > + }; > }; > > &i2c1 { Robin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel