From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA43C433F5 for ; Wed, 16 Mar 2022 16:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357518AbiCPQbt (ORCPT ); Wed, 16 Mar 2022 12:31:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232850AbiCPQbp (ORCPT ); Wed, 16 Mar 2022 12:31:45 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CD4C6C1EB for ; Wed, 16 Mar 2022 09:30:30 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 851743F4CC for ; Wed, 16 Mar 2022 16:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647448229; bh=x3cueeMXvXK+X1TZQd5gJyCfuHoNPJLUSHzCihz2Bfc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=scB6idR8k257z9c54W/4rc9oyFX90lSdSuqWN0E+JE1eWY6E4ncExJGFXECmlfow4 L/PZ4bnhnyWlRYXu4jJxVgl4y59Mj9O2ygyp247/Qnf2cmxc9SGgKLhECWKVV5R6HR iKdwIIeT8GSJ3sRFihF5cZbZ30d+9mL5kh/fU/TyDWVChBVT+6gb51IkB4HhX6JKIt zihBHpTM/B1qVaGtJtmHlBLh3qO0rUNTY3eepA0Unf7ch6IUxTg6ekDxyoC8rDRe28 pVQORRX8CppGSwENo8gaDKUpuQCOOITWvmxQ9xwzzyah9EkZjVmoaKtUvaqlY07nXu oJgA+al83jkRw== Received: by mail-wm1-f70.google.com with SMTP id j42-20020a05600c1c2a00b00381febe402eso3001985wms.0 for ; Wed, 16 Mar 2022 09:30:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x3cueeMXvXK+X1TZQd5gJyCfuHoNPJLUSHzCihz2Bfc=; b=LBwDnGzBij7Lx/ufTIcSsbi6pHtCQ2vmWKFlwgPhMnnK17Xhwc7/W2ClAidQnVwlo0 6yvHcT2eQr40HcoO+8vwUMHGMcGQopmtqLM5F75biykBYYRebFxQnsU4Bb9S2gtDk9EX 4j9l+k6JMKoiMnLf2jmoYl3TIvqlB8cdTZlOqphPdgWHKKOXpwieh2VVkz8kpVMsZLnA kL5j+xYhsgnMML0T3Iv74goO3Vby4HkgtH9mZRgZlL8NdXEItngExdxc7DIYQRsATqST crNQtQssuRs3Baus1/zBnHpVERhJb2WJxhZhLVYbfeZriRqmXzVP4vAkEegD6YwowNy+ 4Fgg== X-Gm-Message-State: AOAM531bCMaNbxBaCpIwnOlNO3O1Z4xDF0Om83G/2z3meb+q6+UQpKdl FK2sK2q+4tNbPHJSOCt2hoUPC1WW2b98XZD1CawwLB4fmUlsrs4JgLp70kuX1QqkQ6TJKcfvora 8xFbO8vyQ1yYchLZaUGfiIdZFi2LT/EYfykEYw5mRlw== X-Received: by 2002:a05:6000:1ac7:b0:1f1:f9ee:7c57 with SMTP id i7-20020a0560001ac700b001f1f9ee7c57mr609213wry.52.1647448229128; Wed, 16 Mar 2022 09:30:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy05jy/Ex/bhrsQefj8mEouXNE6G1mYHwA8mh3BL4NRW8w8I5ZGM2wc5wk/GkP0oJTD53g8mQ== X-Received: by 2002:a05:6000:1ac7:b0:1f1:f9ee:7c57 with SMTP id i7-20020a0560001ac700b001f1f9ee7c57mr609199wry.52.1647448228922; Wed, 16 Mar 2022 09:30:28 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id r65-20020a1c4444000000b0038c48dd23b9sm3169577wma.5.2022.03.16.09.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 09:30:27 -0700 (PDT) Message-ID: Date: Wed, 16 Mar 2022 17:30:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/3] clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list Content-Language: en-US To: Kuldeep Singh , Marc Zyngier , Mark Rutland , Marc Zyngier , Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20220316095433.20225-1-singh.kuldeep87k@gmail.com> <20220316095433.20225-4-singh.kuldeep87k@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220316095433.20225-4-singh.kuldeep87k@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2022 10:54, Kuldeep Singh wrote: > Few platforms such as Renesas RZ/N1D, Calxeda, Alpine etc. are using > arm,cortex-a15-timer and arm,cortex-a7-timer entries in conjugation with > arm,armv7-timer which are not currently defined in driver file. Add > these entries in arch_timer_of_match list to bring them in use. > This looks wrong (also Marc pointed this out) and rationale is not sufficient. Why do you need these compatibles in the driver? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D8E6C433F5 for ; Wed, 16 Mar 2022 16:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pwfkJFXPvQgeThFbm9qXSiii+eJTPff2yiN1V1vNNg8=; b=BJWEBxCaCrjFMB B6MiDjylfnPjihxUQk0GS1sRBPMxg+vUZbvrfhGtS+fXPELZZ5ufP+AJkQF+D2+pvuN1PklzV9Ex/ sDR7GlbP7Z8fwj9EXV8U4+WFqui9SIpRMxjtWsU8H9vYbLEBPlnMXYSdAnbYMmXbuE8dGUE+er4kt 5cE8GIFBp63Tb3fSeiwgxkVB2vbi/K3bOqhczGUA93mrto3PmM8KEYkmCjmRKWtuMM02zzALfJWzH HcKSpsf1h4DqpCcg1s64XnfK9RvzEHKbc+0hdiK10R6ghYirRdCI/a8rX0Vj0XyM0R6tk/YDHVTOS ckyqZTBtYb+1Lb1QinJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUWXi-00DnTo-LL; Wed, 16 Mar 2022 16:30:34 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUWXe-00DnSe-W6 for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 16:30:32 +0000 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id CF85B3F5F4 for ; Wed, 16 Mar 2022 16:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647448229; bh=x3cueeMXvXK+X1TZQd5gJyCfuHoNPJLUSHzCihz2Bfc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=scB6idR8k257z9c54W/4rc9oyFX90lSdSuqWN0E+JE1eWY6E4ncExJGFXECmlfow4 L/PZ4bnhnyWlRYXu4jJxVgl4y59Mj9O2ygyp247/Qnf2cmxc9SGgKLhECWKVV5R6HR iKdwIIeT8GSJ3sRFihF5cZbZ30d+9mL5kh/fU/TyDWVChBVT+6gb51IkB4HhX6JKIt zihBHpTM/B1qVaGtJtmHlBLh3qO0rUNTY3eepA0Unf7ch6IUxTg6ekDxyoC8rDRe28 pVQORRX8CppGSwENo8gaDKUpuQCOOITWvmxQ9xwzzyah9EkZjVmoaKtUvaqlY07nXu oJgA+al83jkRw== Received: by mail-wm1-f69.google.com with SMTP id i6-20020a05600c354600b0038be262d9d9so1825588wmq.8 for ; Wed, 16 Mar 2022 09:30:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x3cueeMXvXK+X1TZQd5gJyCfuHoNPJLUSHzCihz2Bfc=; b=cHLTKb8Rl7ICcNyGkOo6rmtcVem+PkLqI7vnyp2Me1lu7AJAF+fe52ZuyBIzmuJj2r jovLfWt56p8WcPP38eOnnhaS3hdC3rIGAkPOoQLjt8KMdhOkz6ue48ESNF5MotlY+06G c/cVPxHQtDCuCO10x8ppa7yeqPrdiA5f/rthXEUpEr+2LdnhOWxb/GiByfv8sAd4DO5r SgPh0CPWZXSpcvXp4wk61flGa2Fm1SDOJbMiwbbxfOn+BSprBWVevhnLq58ydWuQ6rSl IX3hPsITnflg3iDU3MaqDCboEoBv6qyll3UHJCyNjngYWYfKOwkPVhKmZLOSQmhxVrLo P7TA== X-Gm-Message-State: AOAM533acXVJ1/aVKxOcUeG83oumuo7kYDAswuTvgye8Z6PRkzLFs6QK 9Xwg9vR4cPWYPXvOTXdgiYmah+iWO73g2uCaPWKMdqvdRtS+4sPbsiIUPbmbvBzd4tJZTChofX/ dJrVTPJ0kmY40QvY82fzgipQyUFUB30kpy6rnoPMVzEOZC722fXfe X-Received: by 2002:a05:6000:1ac7:b0:1f1:f9ee:7c57 with SMTP id i7-20020a0560001ac700b001f1f9ee7c57mr609217wry.52.1647448229130; Wed, 16 Mar 2022 09:30:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy05jy/Ex/bhrsQefj8mEouXNE6G1mYHwA8mh3BL4NRW8w8I5ZGM2wc5wk/GkP0oJTD53g8mQ== X-Received: by 2002:a05:6000:1ac7:b0:1f1:f9ee:7c57 with SMTP id i7-20020a0560001ac700b001f1f9ee7c57mr609199wry.52.1647448228922; Wed, 16 Mar 2022 09:30:28 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id r65-20020a1c4444000000b0038c48dd23b9sm3169577wma.5.2022.03.16.09.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 09:30:27 -0700 (PDT) Message-ID: Date: Wed, 16 Mar 2022 17:30:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/3] clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list Content-Language: en-US To: Kuldeep Singh , Marc Zyngier , Mark Rutland , Marc Zyngier , Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20220316095433.20225-1-singh.kuldeep87k@gmail.com> <20220316095433.20225-4-singh.kuldeep87k@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220316095433.20225-4-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_093031_201639_5837AE38 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/2022 10:54, Kuldeep Singh wrote: > Few platforms such as Renesas RZ/N1D, Calxeda, Alpine etc. are using > arm,cortex-a15-timer and arm,cortex-a7-timer entries in conjugation with > arm,armv7-timer which are not currently defined in driver file. Add > these entries in arch_timer_of_match list to bring them in use. > This looks wrong (also Marc pointed this out) and rationale is not sufficient. Why do you need these compatibles in the driver? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel