From: mawupeng <mawupeng1@huawei.com>
To: <mcgrof@kernel.org>
Cc: <mawupeng1@huawei.com>, <akpm@linux-foundation.org>,
<david@redhat.com>, <npiggin@suse.de>, <ying.huang@intel.com>,
<hannes@cmpxchg.org>, <corbet@lwn.net>, <mgorman@suse.de>,
<keescook@chromium.org>, <yzaikin@google.com>,
<songmuchun@bytedance.com>, <mike.kravetz@oracle.com>,
<osalvador@suse.de>, <surenb@google.com>, <rppt@kernel.org>,
<charante@codeaurora.org>, <jsavitz@redhat.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<lkp@intel.com>
Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor
Date: Wed, 7 Sep 2022 11:29:19 +0800 [thread overview]
Message-ID: <f54bdd79-b78e-470d-7048-8dee0ee39a1f@huawei.com> (raw)
In-Reply-To: <YxeQB2jawNwpOB5y@bombadil.infradead.org>
On 2022/9/7 2:23, Luis Chamberlain wrote:
> On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote:
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 205d605cacc5..d16d06c71e5a 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = {
>> .maxlen = sizeof(watermark_scale_factor),
>> .mode = 0644,
>> .proc_handler = watermark_scale_factor_sysctl_handler,
>> - .extra1 = SYSCTL_ONE,
>> - .extra2 = SYSCTL_THREE_THOUSAND,
>> },
>> {
>> .procname = "percpu_pagelist_high_fraction",
>
> Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while
> at it, you can git log the kernel/sysctl.c for prior moves and for
> the motivations. No need to keep expanding on the existing table.
>
> Luis
Ok.
I will move this sysctl to mm/page_alloc.c next version.
next prev parent reply other threads:[~2022-09-07 3:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 3:28 [PATCH -next v3 0/2] watermark related improvement on zone movable Wupeng Ma
2022-09-05 3:28 ` [PATCH -next v3 1/2] mm: Cap zone movable's min wmark to small value Wupeng Ma
2022-09-05 9:26 ` Mel Gorman
2022-09-06 10:12 ` mawupeng
2022-09-06 12:22 ` Mel Gorman
2022-09-07 8:42 ` mawupeng
2022-09-05 3:28 ` [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor Wupeng Ma
2022-09-05 3:45 ` Matthew Wilcox
2022-09-05 6:39 ` mawupeng
2022-09-06 18:23 ` Luis Chamberlain
2022-09-07 3:29 ` mawupeng [this message]
2022-09-09 21:41 ` Khalid Aziz
2022-09-13 2:09 ` mawupeng
2022-09-14 22:42 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f54bdd79-b78e-470d-7048-8dee0ee39a1f@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jsavitz@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=npiggin@suse.de \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=ying.huang@intel.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.