All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Thomas Huth <thuth@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState
Date: Fri, 3 Mar 2017 15:49:15 +0100	[thread overview]
Message-ID: <f55bb0be-778c-6ded-1564-9b77c4521f52@kaod.org> (raw)
In-Reply-To: <39ad7cac-b29e-b01e-723c-8cbdb1cf3ca9@redhat.com>

On 03/03/2017 03:13 PM, Thomas Huth wrote:
> On 03.03.2017 14:37, Cédric Le Goater wrote:
>> Also use an 'Object *' under the sPAPR machine to hold the RTC
>> object.
> 
> The change from TYPE_SYS_BUS_DEVICE to TYPE_DEVICE is certainly a good
> idea! But what's the advantage of using Object* instead of DeviceState*
> in sPAPRMachineState ?

it makes spapr_rtc_create() a little simpler.  

We could go even further and use a sPAPRRTCState under sPAPRMachineState 
that we  would initialize with object_initialize(). 

C.

  reply	other threads:[~2017-03-03 14:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 13:37 [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState Cédric Le Goater
2017-03-03 14:13 ` Thomas Huth
2017-03-03 14:49   ` Cédric Le Goater [this message]
2017-03-03 16:54     ` Thomas Huth
2017-03-03 17:23       ` Cédric Le Goater
2017-03-05 23:23         ` David Gibson
2017-03-06  7:56           ` Cédric Le Goater
2017-03-06  9:01             ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f55bb0be-778c-6ded-1564-9b77c4521f52@kaod.org \
    --to=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.