Re: [PATCH V3] app/testpmd: fix GENEVE parsing in csum forward mode

["Singh, Aman Deep" <aman.deep.singh@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]


On 2/20/2022 5:39 PM, Raja Zidane wrote:
> The csum FWD mode parses any received packet to set mbuf offloads for the
> transmitting burst, mainly in the checksum/TSO areas.
> In the case of a tunnel header, the csum FWD tries to detect known tunnels
> by the standard definition using the header'sdata and fallback to check the
> packet type in the mbuf to see if the Rx port driver already sign the
> packet as a tunnel.
> In the fallback case, the csum assumes the tunnel is VXLAN and parses the
> tunnel as VXLAN.
> When the GENEVE tunnel was added to the known tunnels in csum, its parsing
> trial was wrongly located after the pkt type detection, causing the csum to
> parse the GENEVE header as VXLAN when the Rx port set the tunnel packet
> type.
>
> Remove the fall back case to VxLan.
> Log error of unrecognized tunnel if no tunnel was parsed successfully.
>
> Fixes: c10a026c3b03 ("app/testpmd: introduce vxlan parsing function in csum fwd engine")
> Cc:stable@dpdk.org
>
> Signed-off-by: Raja Zidane<rzidane@nvidia.com>
> ---
> V2: Log error when an unrecognized tunnel is found (unknown UDP dst port), instead of parsing it as VxLan by default.
> V3: revert unneeded changes (swapping parse_geneve & parse_vxlan).
>   app/test-pmd/csumonly.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)

>
> Acked-by: Aman Singh <aman.deep.singh@intel.com>


<snip>

>   

[-- Attachment #2: Type: text/html, Size: 2359 bytes --]