From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118B1C3DA79 for ; Mon, 26 Dec 2022 12:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229450AbiLZM11 (ORCPT ); Mon, 26 Dec 2022 07:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbiLZM10 (ORCPT ); Mon, 26 Dec 2022 07:27:26 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8BD42AE4 for ; Mon, 26 Dec 2022 04:27:24 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id b3so15799939lfv.2 for ; Mon, 26 Dec 2022 04:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WRgHMYxNzvXV/Rkf0QUcRNHp4+EIuQ1yrJzCHQL2OU8=; b=oJVd9QbWMUr51an5T7995QYHfbMBDEX9eDI8F9Gi4NIozAx86uVZZS2uaQWe4UNuuO +3hLA7cbDspp3W6oN8RL5/mAzsX/96JgPbhdb9i/BZGAKwwyDA4BdyAp+26PnnTTiwyZ g63fEemgt+mJuUDyd5KzEgYwkjY+MJRgOCChr7iSCx6OW+qbJWLfYWDGlkE2wBEuI1OX slN00obwhnXmJMQWD3a8G15hzrkEkYfDVLd6rqfkCyOm8PtSoAUEzBxEM0GZlzg+5Wa7 Vbmw9xgEONBBgk4vrUJCDrOT+gB5+xYh8trSHUIcLnKWCdICxuhesBfpxk6Mnc0tdbv3 ejpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WRgHMYxNzvXV/Rkf0QUcRNHp4+EIuQ1yrJzCHQL2OU8=; b=foNSHk55cPJpKIc4esDkplEchmMHE07sgKsbe6tuBL8g7J7cH1eR7HnMe7W17aWdAW SP3qkwZJJGIaEAw4apZKmuOIkHIbTSo43mC3+5nx0lDbAZl7j9NDnf2W4om0uZ8ng1LD FWmmV/M/w2QrbKUjmbipsSuZD9RDwUjt3rwU1TjP4ZYXtjLoj6t0qWRNzUJfS8Yz9y5q TYk1T8Kik9bgPAsI2351bHghObSF4E5Z3PaGXsldD0J0AgCL7YOKrIChzsJ9kVz+hrUt +CMBKHrH+KE/HEGu7ZWSGJRZJHFxUmCtrZjbrQlI5fIqab8yLb2wte+MWhFYIyQKqjqJ rIyg== X-Gm-Message-State: AFqh2kqW9xLP9WOwUJhMOBQRQi+9TYszEYD21VJ++A5cqXg/WZOkZN+Q xuA0Wx0ITfvQL3oU9ruTTRhPmg== X-Google-Smtp-Source: AMrXdXtnApTf3ReVqgja7dPTOH6W0gQmo/vvCsRj0yba+pfy0FAolACLLh1auSSoksIsIg3CRphVwA== X-Received: by 2002:a05:6512:2828:b0:4b9:f5e5:8fbc with SMTP id cf40-20020a056512282800b004b9f5e58fbcmr6759486lfb.30.1672057643267; Mon, 26 Dec 2022 04:27:23 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b004b55f60c65asm1806452lfs.284.2022.12.26.04.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 04:27:22 -0800 (PST) Message-ID: Date: Mon, 26 Dec 2022 13:27:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 14/14] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Content-Language: en-US To: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-15-quic_wcheng@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221223233200.26089-15-quic_wcheng@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/12/2022 00:32, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 70080d04ddc9..60cd84e6727a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -216,6 +216,19 @@ examples: > sound-dai = <&vamacro 0>; > }; > }; > + > + usb-dai-link { > + link-name = "USB Playback"; > + cpu { > + sound-dai = <&q6afedai USB_RX>; Hmm, that makes me wonder if you really tested the bindings before sending? If yes, where is the USB_RX defined? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E84C3DA79 for ; Mon, 26 Dec 2022 12:28:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 793706033; Mon, 26 Dec 2022 13:27:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 793706033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1672057699; bh=VD3xegORHsJkFHPOWctjaNel4Q3080OdA7ng6upOhFs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=GnhWvvq6x2VaR+LV8vBes7etofCJlo8dbcC7iRpRq0fMqhxxS3aItVnvdziGGEbwX fjKGauu0w2E0yto8rQjJXLtntv5x1BQV03csB6//oRR3gs5ZvwpRzuU3g+i40bTnre +iAcEQep9xqFKdlBbPCKqHLao5QeYeoeaCVAYAjk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 21D7BF8027B; Mon, 26 Dec 2022 13:27:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C81CCF802A0; Mon, 26 Dec 2022 13:27:27 +0100 (CET) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C54DEF80134 for ; Mon, 26 Dec 2022 13:27:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C54DEF80134 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=oJVd9QbW Received: by mail-lf1-x136.google.com with SMTP id g13so15764799lfv.7 for ; Mon, 26 Dec 2022 04:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WRgHMYxNzvXV/Rkf0QUcRNHp4+EIuQ1yrJzCHQL2OU8=; b=oJVd9QbWMUr51an5T7995QYHfbMBDEX9eDI8F9Gi4NIozAx86uVZZS2uaQWe4UNuuO +3hLA7cbDspp3W6oN8RL5/mAzsX/96JgPbhdb9i/BZGAKwwyDA4BdyAp+26PnnTTiwyZ g63fEemgt+mJuUDyd5KzEgYwkjY+MJRgOCChr7iSCx6OW+qbJWLfYWDGlkE2wBEuI1OX slN00obwhnXmJMQWD3a8G15hzrkEkYfDVLd6rqfkCyOm8PtSoAUEzBxEM0GZlzg+5Wa7 Vbmw9xgEONBBgk4vrUJCDrOT+gB5+xYh8trSHUIcLnKWCdICxuhesBfpxk6Mnc0tdbv3 ejpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WRgHMYxNzvXV/Rkf0QUcRNHp4+EIuQ1yrJzCHQL2OU8=; b=xcEFk2fqoCj8v7oxSuPjIKL0hqPS27fFLjeSMT1hsRTML/K/oybenBfm/2ChEzYozl oveYntRq83SQMaRiMYH8VZZ/rspEvpj0oGhJyUy1jmK32zfeK4OWpYnijg2RstTvSneC hqzoDnKBrrZzdF368DIZL7TsyraeovhFcH6pO8a29fsrogIayxJ0Dd/xrsmpUiVf3PNr +KjfOyJeElSY1dpmcvFEkO7U/pW24R0mqifz3ZCw06cOBlymCtS4akQQlowlywOlbGAn Ms6GTxaoFNBXxAyGn3jYI6LY+8maZye7h6d8gG5TYhiWZZAZfZJiSKKYeNXWBtSxXPlI XpyA== X-Gm-Message-State: AFqh2koVHjO1XmoAKHF3K5WDQAyHlkQsGGAkgJzD7qpPnFn2/8Oak4wT sP2wP24FfMSWzvHXdf8C7KW7ZA== X-Google-Smtp-Source: AMrXdXtnApTf3ReVqgja7dPTOH6W0gQmo/vvCsRj0yba+pfy0FAolACLLh1auSSoksIsIg3CRphVwA== X-Received: by 2002:a05:6512:2828:b0:4b9:f5e5:8fbc with SMTP id cf40-20020a056512282800b004b9f5e58fbcmr6759486lfb.30.1672057643267; Mon, 26 Dec 2022 04:27:23 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b004b55f60c65asm1806452lfs.284.2022.12.26.04.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 04:27:22 -0800 (PST) Message-ID: Date: Mon, 26 Dec 2022 13:27:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 14/14] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Content-Language: en-US To: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-15-quic_wcheng@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221223233200.26089-15-quic_wcheng@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 24/12/2022 00:32, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 70080d04ddc9..60cd84e6727a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -216,6 +216,19 @@ examples: > sound-dai = <&vamacro 0>; > }; > }; > + > + usb-dai-link { > + link-name = "USB Playback"; > + cpu { > + sound-dai = <&q6afedai USB_RX>; Hmm, that makes me wonder if you really tested the bindings before sending? If yes, where is the USB_RX defined? Best regards, Krzysztof