From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5 Date: Thu, 19 Jul 2012 04:25:20 -0700 (PDT) Message-ID: References: <1340872367-16206-1-git-send-email-ygardi@codeaurora.org> <1340872367-16206-3-git-send-email-ygardi@codeaurora.org> <87629k9rkc.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:18706 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761Ab2GSLZU (ORCPT ); Thu, 19 Jul 2012 07:25:20 -0400 In-Reply-To: <87629k9rkc.fsf@octavius.laptop.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Chris Ball Cc: Yaniv Gardi , linux-mmc@vger.kernel.org, merez@codeaurora.org, linux-arm-msm@vger.kernel.org, open list On Wed, July 18, 2012 11:46 pm, Chris Ball wrote: > Hi Yaniv, > > On Thu, Jun 28 2012, Yaniv Gardi wrote: >> This feature delete the unmap memory region of the eMMC card, >> by writing to a specific register in the EXT_CSD >> unmap region is the memory region that were previously deleted >> (by erase, trim or discard operation) >> >> Signed-off-by: Yaniv Gardi > > Did you reply to Chuanxiao's review comments yet? He said: > > "So to implement your scenario, how about only add > mmc_blk_issue_sanitize_rq() for REQ_SANITIZE but not touch > mmc_blk_issue_secdiscard_rq()? With your changes in > mmc_blk_issue_secdiscard_rq(), eMMC4.5 device will be failed to operate > secure trim/erase for REQ_SECURE request." > > at: http://thread.gmane.org/gmane.linux.kernel.mmc/14822/focus=14880 > > Thanks, > > - Chris. > -- > Chris Ball > One Laptop Per Child > Secure trim and secure erase were removed from eMMC4.5. Please refer to annex B at B.6 section in eMMC4.5 spec. Therefore, failure upon trying to do secure trim/erase is the expected behavior for eMMC4.5 devices. Thanks, Maya -- Sent by consultant of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120Ab2GSLZZ (ORCPT ); Thu, 19 Jul 2012 07:25:25 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:18706 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761Ab2GSLZU (ORCPT ); Thu, 19 Jul 2012 07:25:20 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6776"; a="209898692" Message-ID: In-Reply-To: <87629k9rkc.fsf@octavius.laptop.org> References: <1340872367-16206-1-git-send-email-ygardi@codeaurora.org> <1340872367-16206-3-git-send-email-ygardi@codeaurora.org> <87629k9rkc.fsf@octavius.laptop.org> Date: Thu, 19 Jul 2012 04:25:20 -0700 (PDT) Subject: Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5 From: merez@codeaurora.org To: "Chris Ball" Cc: "Yaniv Gardi" , linux-mmc@vger.kernel.org, merez@codeaurora.org, linux-arm-msm@vger.kernel.org, "open list" User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, July 18, 2012 11:46 pm, Chris Ball wrote: > Hi Yaniv, > > On Thu, Jun 28 2012, Yaniv Gardi wrote: >> This feature delete the unmap memory region of the eMMC card, >> by writing to a specific register in the EXT_CSD >> unmap region is the memory region that were previously deleted >> (by erase, trim or discard operation) >> >> Signed-off-by: Yaniv Gardi > > Did you reply to Chuanxiao's review comments yet? He said: > > "So to implement your scenario, how about only add > mmc_blk_issue_sanitize_rq() for REQ_SANITIZE but not touch > mmc_blk_issue_secdiscard_rq()? With your changes in > mmc_blk_issue_secdiscard_rq(), eMMC4.5 device will be failed to operate > secure trim/erase for REQ_SECURE request." > > at: http://thread.gmane.org/gmane.linux.kernel.mmc/14822/focus=14880 > > Thanks, > > - Chris. > -- > Chris Ball > One Laptop Per Child > Secure trim and secure erase were removed from eMMC4.5. Please refer to annex B at B.6 section in eMMC4.5 spec. Therefore, failure upon trying to do secure trim/erase is the expected behavior for eMMC4.5 devices. Thanks, Maya -- Sent by consultant of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum