* [PATCH net-next] net: remove comments on struct rtnl_link_stats
@ 2020-09-17 17:51 Jakub Kicinski
2020-09-17 18:19 ` Saeed Mahameed
2020-09-18 0:58 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-09-17 17:51 UTC (permalink / raw)
To: davem; +Cc: netdev, saeedm, Jakub Kicinski
We removed the misleading comments from struct rtnl_link_stats64
when we added proper kdoc. struct rtnl_link_stats has the same
inline comments, so remove them, too.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
include/uapi/linux/if_link.h | 31 +++++++++++++++----------------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index bf4667403cab..c4b23f06f69e 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -7,24 +7,23 @@
/* This struct should be in sync with struct rtnl_link_stats64 */
struct rtnl_link_stats {
- __u32 rx_packets; /* total packets received */
- __u32 tx_packets; /* total packets transmitted */
- __u32 rx_bytes; /* total bytes received */
- __u32 tx_bytes; /* total bytes transmitted */
- __u32 rx_errors; /* bad packets received */
- __u32 tx_errors; /* packet transmit problems */
- __u32 rx_dropped; /* no space in linux buffers */
- __u32 tx_dropped; /* no space available in linux */
- __u32 multicast; /* multicast packets received */
+ __u32 rx_packets;
+ __u32 tx_packets;
+ __u32 rx_bytes;
+ __u32 tx_bytes;
+ __u32 rx_errors;
+ __u32 tx_errors;
+ __u32 rx_dropped;
+ __u32 tx_dropped;
+ __u32 multicast;
__u32 collisions;
-
/* detailed rx_errors: */
__u32 rx_length_errors;
- __u32 rx_over_errors; /* receiver ring buff overflow */
- __u32 rx_crc_errors; /* recved pkt with crc error */
- __u32 rx_frame_errors; /* recv'd frame alignment error */
- __u32 rx_fifo_errors; /* recv'r fifo overrun */
- __u32 rx_missed_errors; /* receiver missed packet */
+ __u32 rx_over_errors;
+ __u32 rx_crc_errors;
+ __u32 rx_frame_errors;
+ __u32 rx_fifo_errors;
+ __u32 rx_missed_errors;
/* detailed tx_errors */
__u32 tx_aborted_errors;
@@ -37,7 +36,7 @@ struct rtnl_link_stats {
__u32 rx_compressed;
__u32 tx_compressed;
- __u32 rx_nohandler; /* dropped, no handler found */
+ __u32 rx_nohandler;
};
/**
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: remove comments on struct rtnl_link_stats
2020-09-17 17:51 [PATCH net-next] net: remove comments on struct rtnl_link_stats Jakub Kicinski
@ 2020-09-17 18:19 ` Saeed Mahameed
2020-09-18 0:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-09-17 18:19 UTC (permalink / raw)
To: Jakub Kicinski, davem; +Cc: netdev
On Thu, 2020-09-17 at 10:51 -0700, Jakub Kicinski wrote:
> We removed the misleading comments from struct rtnl_link_stats64
> when we added proper kdoc. struct rtnl_link_stats has the same
> inline comments, so remove them, too.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Thanks Jakub!
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: remove comments on struct rtnl_link_stats
2020-09-17 17:51 [PATCH net-next] net: remove comments on struct rtnl_link_stats Jakub Kicinski
2020-09-17 18:19 ` Saeed Mahameed
@ 2020-09-18 0:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-18 0:58 UTC (permalink / raw)
To: kuba; +Cc: netdev, saeedm
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 17 Sep 2020 10:51:32 -0700
> We removed the misleading comments from struct rtnl_link_stats64
> when we added proper kdoc. struct rtnl_link_stats has the same
> inline comments, so remove them, too.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 0:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 17:51 [PATCH net-next] net: remove comments on struct rtnl_link_stats Jakub Kicinski
2020-09-17 18:19 ` Saeed Mahameed
2020-09-18 0:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.