All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add BlockBackend->in_flight counter
Date: Fri, 9 Feb 2018 09:20:17 -0600	[thread overview]
Message-ID: <f589d376-8684-2758-509c-3b45c2986dca@redhat.com> (raw)
In-Reply-To: <20180208171807.24267-2-stefanha@redhat.com>

On 02/08/2018 11:18 AM, Stefan Hajnoczi wrote:
> BlockBackend currently relies on BlockDriverState->in_flight to track
> requests for blk_drain().  There is a corner case where
> BlockDriverState->in_flight cannot be used though: blk->root can be NULL
> when there is no medium.  This results in a segfault when the NULL
> pointer is dereferenced.
> 
> Introduce a BlockBackend->in_flight counter for aio requests so it works
> even when blk->root == NULL.
> 
> Based on a patch by Kevin Wolf <kwolf@redhat.com>.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   block.c               |  2 +-
>   block/block-backend.c | 59 +++++++++++++++++++++++++++++++++++++++++++++------
>   2 files changed, 53 insertions(+), 8 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-02-09 15:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08 17:18 [Qemu-devel] [PATCH 0/3] block: fix blk_aio_*() segfault when blk->root == NULL Stefan Hajnoczi
2018-02-08 17:18 ` [Qemu-devel] [PATCH 1/3] block: add BlockBackend->in_flight counter Stefan Hajnoczi
2018-02-09 15:20   ` Eric Blake [this message]
2018-02-09 16:28   ` Paolo Bonzini
2018-02-09 17:23     ` Kevin Wolf
2018-02-09 17:26       ` Paolo Bonzini
2018-02-12 14:08         ` Stefan Hajnoczi
2018-02-08 17:18 ` [Qemu-devel] [PATCH 2/3] block: test blk_aio_flush() with blk->root == NULL Stefan Hajnoczi
2018-02-09 15:23   ` Eric Blake
2018-02-12 14:10     ` Stefan Hajnoczi
2018-02-08 17:18 ` [Qemu-devel] [PATCH 3/3] Revert "IDE: Do not flush empty CDROM drives" Stefan Hajnoczi
2018-02-09 15:27   ` Eric Blake
2018-02-09 15:34 ` [Qemu-devel] [PATCH 0/3] block: fix blk_aio_*() segfault when blk->root == NULL Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f589d376-8684-2758-509c-3b45c2986dca@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.