From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91DD2C43381 for ; Tue, 5 Mar 2019 16:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53AE720842 for ; Tue, 5 Mar 2019 16:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="vigGyfXr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbfCEQsv (ORCPT ); Tue, 5 Mar 2019 11:48:51 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:36856 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726221AbfCEQsu (ORCPT ); Tue, 5 Mar 2019 11:48:50 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x25GidRh168916; Tue, 5 Mar 2019 16:48:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=6EvhzbWQrfnmbiGI1U1Nv5YYkGrm4nPOEzaPQoBhrGY=; b=vigGyfXr2vDpxUQ7RTWR8wwHZcC32NV4YdMyKLDJBhGWwPJ+8+jYf4nDtAz3TFrSlNi/ TQmjiFT+uqLeD0eiOCvwKRFf/LdCZNkaYG1tQISa4TvnYlm+LLT+767VBC7AIHwAHf+L PcdWxG9hEJVSnynyVFZQpCmUNW2NzQBP6F0g9qZk6VJT29U47cOGfEiDFB2byypg3RMw gkGLHImL6PSAu+Ucg4+41HBklkqSZf8fI9uYBSxrv6HP+F+zg8f0UT/quRrYHucc/0vi 85klB8Nx9l3vqW/94mpWrU6hC/LYtg+TKvD1DQfMmPL8tqRf5h1WnQwAdvdEEStGgpxS kQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2qyh8u6kn1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2019 16:48:47 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x25GmkAI021471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Mar 2019 16:48:46 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x25GmjxT026583; Tue, 5 Mar 2019 16:48:45 GMT Received: from [10.159.132.143] (/10.159.132.143) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Mar 2019 08:48:45 -0800 Subject: Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos To: Santosh Shilimkar , netdev@vger.kernel.org, davem@davemloft.net Cc: yanjun.zhu@oracle.com References: <1549325089-16572-1-git-send-email-santosh.shilimkar@oracle.com> <1549325089-16572-6-git-send-email-santosh.shilimkar@oracle.com> <813cd909-b32f-dda7-4fd9-a32428758507@oracle.com> <33c256f3-e28a-6a70-866c-742ae13c8443@oracle.com> From: Gerd Rausch Message-ID: Date: Tue, 5 Mar 2019 08:48:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <33c256f3-e28a-6a70-866c-742ae13c8443@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9186 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903050110 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: > On 3/5/2019 8:33 AM, Gerd Rausch wrote: >> If there's a mechanism that ensures compatibility with older (pre-4.1) versions >> of RDS I am not seeing it. > Thats handled as part of the connection reject handler as part of negotiation. > Evidentally, that mechanism isn't working properly. >> The inconsistency in comment vs. code doesn't help in that regard. >> > Yeah the comment should have been updated. > >> And tests illustrated this incompatibility: >> 2 peers with this patchset can talk to eachother. >> Peers with a mix of post-this-patchset and pre-this-patchset can no longer talk >> to eachother. >> > They can talk to each other as per Yanjun tests. I am happy to hear it worked for him, but is it possible that his tests may have been incomplete? In a unicast e-mail conversation with Yanjun, he acknowledged: "Now I found another hosts and I can reproduce Gerd's bug on the hosts. Now I am working on the hosts to find the root cause." So we have non-working code in David's repository, which I consider not to be a good thing. > He is working on setting it up net-next to see if something got missed out. > Stay tune. Will update about the results. > Can we back this patchset out again until we have working & compatible code? Thanks, Gerd