All of lore.kernel.org
 help / color / mirror / Atom feed
From: German Gomez <german.gomez@arm.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Cc: James Clark <james.clark@arm.com>,
	leo.yan@linaro.org, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/1] perf arm-spe: extend Arm SPE test script with regression testing
Date: Mon, 22 Nov 2021 13:46:45 +0000	[thread overview]
Message-ID: <f5abae0b-acf8-f674-30f1-4b5c1fe6a49e@arm.com> (raw)
In-Reply-To: <20211112162005.11876-2-german.gomez@arm.com>


On 12/11/2021 16:20, German Gomez wrote:
> Extend the test_arm_spe.sh script to test for regressions in the
> decoding flow of Arm SPE samples. In order to support the tests, a set
> of perf.data files has been generated offline and is being hosted under
> tools/perf/tests/shell/test_arm_spe.tgz:
>
> (See perf report --header-only to see the actual commands used)

Looking back at this patch, I don't think it can be applied as is. I
notice that the docs for the --itrace argument aren't up to date (it
says the default is --itrace=ibxwpe but lately it has changed ([1] &
[2]). The value of --itrace should be locked in the test script.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/itrace.txt?id=136057256686de39cc3a07c2e39ef6bc43003ff6#n26
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/auxtrace.c?id=136057256686de39cc3a07c2e39ef6bc43003ff6#n1335

>
>   - test_arm_spe.tgz
>     `- arm_spe_decode_contextidr.data
>     `- arm_spe_decode_contextidr.data.inject
>     `- arm_spe_decode_switch_events.data
>     `- arm_spe_decode_switch_events.data.inject
>
> [...]

  reply	other threads:[~2021-11-22 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 16:20 [PATCH 0/1] perf arm-spe: extend Arm SPE test script with regression testing German Gomez
2021-11-12 16:20 ` [PATCH 1/1] " German Gomez
2021-11-22 13:46   ` German Gomez [this message]
2021-11-23  5:19   ` Leo Yan
2021-11-23 11:41     ` German Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5abae0b-acf8-f674-30f1-4b5c1fe6a49e@arm.com \
    --to=german.gomez@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.