From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45219C2D0A3 for ; Tue, 10 Nov 2020 01:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EACDA2078D for ; Tue, 10 Nov 2020 01:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730284AbgKJByM (ORCPT ); Mon, 9 Nov 2020 20:54:12 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7509 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKJByL (ORCPT ); Mon, 9 Nov 2020 20:54:11 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CVWB14tvvzhjvx; Tue, 10 Nov 2020 09:54:01 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 10 Nov 2020 09:54:08 +0800 Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE To: Eric Biggers CC: Chao Yu , , , References: <20201106065331.76236-1-yuchao0@huawei.com> <20201106180324.GA78548@sol.localdomain> <20201107171635.GA841@sol.localdomain> <63efaa5c-bc19-4b16-653d-840bc6a6d9d1@huawei.com> <20201109181204.GA1232946@gmail.com> From: Chao Yu Message-ID: Date: Tue, 10 Nov 2020 09:54:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201109181204.GA1232946@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/10 2:12, Eric Biggers wrote: > On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote: >>> Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too. >>> >>> In that case a much better approach would be to add __f2fs_ioctl() which is >>> called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and >>> f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl(). >> >> Will this cleanup make sense to you? > > I think it would be better to do it the way I suggested. Updated in v5. Thanks, > > - Eric > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AAEC2D0A3 for ; Tue, 10 Nov 2020 01:54:25 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A621206B2 for ; Tue, 10 Nov 2020 01:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="TOeYnKfq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Tyz8l1QN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A621206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kcIrW-0002z2-TL; Tue, 10 Nov 2020 01:54:22 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcIrV-0002yt-GZ for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Nov 2020 01:54:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dfUIVMqSxEwqx/2r70v/pd6g98fa/lB4pO50c/jvK8=; b=TOeYnKfqjc/SOE5DEydH0LWi92 dKlQWkApbsLKZbUOm62tvQs3/dZJt/Kq2Mm/0rcX31uv+Amp8tbwIMbQLHt8sVDsn5Vd5gcdkQKaV cOjozlhh9oBFHYkfh7VrWtZRzDQgH0X4qsGRUh7FB1q9CMBA8N9TtizW55ITpRAmFfK0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3dfUIVMqSxEwqx/2r70v/pd6g98fa/lB4pO50c/jvK8=; b=Tyz8l1QNRB6Cb+AI1E51HvY+6u 6sSM0gnu2oe2uFjLslFKSqgLFaggvAdB9FGODj4lAZTMfxvospUWpv469I76M4hbo2IoTs3PYsiLs /+NH+bbbiez5/ki0d572JCej+O0Lh6VkD+2nYeKC8e74Y0WmwFlO+2AiEDAfl/accy54=; Received: from szxga05-in.huawei.com ([45.249.212.191]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kcIrQ-00ExXR-O7 for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Nov 2020 01:54:21 +0000 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CVWB14tvvzhjvx; Tue, 10 Nov 2020 09:54:01 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 10 Nov 2020 09:54:08 +0800 To: Eric Biggers References: <20201106065331.76236-1-yuchao0@huawei.com> <20201106180324.GA78548@sol.localdomain> <20201107171635.GA841@sol.localdomain> <63efaa5c-bc19-4b16-653d-840bc6a6d9d1@huawei.com> <20201109181204.GA1232946@gmail.com> From: Chao Yu Message-ID: Date: Tue, 10 Nov 2020 09:54:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201109181204.GA1232946@gmail.com> Content-Language: en-US X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected X-Headers-End: 1kcIrQ-00ExXR-O7 Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/11/10 2:12, Eric Biggers wrote: > On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote: >>> Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too. >>> >>> In that case a much better approach would be to add __f2fs_ioctl() which is >>> called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and >>> f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl(). >> >> Will this cleanup make sense to you? > > I think it would be better to do it the way I suggested. Updated in v5. Thanks, > > - Eric > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel