From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Bernhard Beschow <shentey@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX soughbridge type names
Date: Mon, 30 May 2022 15:19:33 +0200 [thread overview]
Message-ID: <f5cf718e-fc56-c271-5827-dc2d3c86a231@amsat.org> (raw)
In-Reply-To: <CAG4p6K4v8qEUpZKqJ4R6aXXoKWSoBUORySsjt_eJFPzggsZVvg@mail.gmail.com>
On 29/5/22 20:09, Bernhard Beschow wrote:
> On Sun, May 29, 2022 at 11:05 AM Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk <mailto:mark.cave-ayland@ilande.co.uk>>
> wrote:
>
> On 28/05/2022 20:20, Bernhard Beschow wrote:
>
> > TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
> > ones, too.
> >
> > Signed-off-by: Bernhard Beschow <shentey@gmail.com
> <mailto:shentey@gmail.com>>
> > Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk
> <mailto:mark.cave-ayland@ilande.co.uk>>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>>
> > ---
> > hw/isa/piix3.c | 3 ---
> > include/hw/isa/isa.h | 2 --
> > include/hw/southbridge/piix.h | 4 ++++
> > 3 files changed, 4 insertions(+), 5 deletions(-)
> One tiny nit here: there's a typo in the subject line which I missed
> when reviewing v2.
>
> s/soughbridge/southbridge/
>
>
> Ack. Will fix in v3.
Can do. Also, "include/" in subject is not helpful.
next prev parent reply other threads:[~2022-05-30 13:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 19:20 [PATCH v3 0/7] QOM'ify PIIX southbridge creation Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX soughbridge type names Bernhard Beschow
2022-05-29 9:05 ` Mark Cave-Ayland
2022-05-29 18:09 ` Bernhard Beschow
2022-05-30 13:19 ` Philippe Mathieu-Daudé via [this message]
2022-06-01 21:34 ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 2/7] hw/isa/piix4: Use object_initialize_child() for embedded struct Bernhard Beschow
2022-05-30 11:38 ` Philippe Mathieu-Daudé via
2022-06-01 21:36 ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 3/7] hw/isa/piix{3, 4}: Move pci_map_irq_fn's near pci_set_irq_fn's Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 4/7] hw/isa/piix{3, 4}: QOM'ify PCI device creation and wiring Bernhard Beschow
2022-05-30 13:17 ` Philippe Mathieu-Daudé via
2022-05-30 21:00 ` [PATCH v3 4/7] hw/isa/piix{3,4}: " Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 5/7] hw/isa/piix{3, 4}: Factor out ISABus retrieval from create() functions Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 6/7] hw/isa/piix4: QOM'ify PIIX4 PM creation Bernhard Beschow
2022-05-29 9:25 ` Mark Cave-Ayland
2022-05-29 18:05 ` Bernhard Beschow
2022-05-30 19:58 ` Mark Cave-Ayland
2022-06-01 21:39 ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 7/7] hw/isa/piix{3, 4}: Inline and remove create() functions Bernhard Beschow
2022-05-29 9:46 ` [PATCH v3 0/7] QOM'ify PIIX southbridge creation Mark Cave-Ayland
2022-05-29 10:06 ` Mark Cave-Ayland
2022-05-29 13:02 ` Bernhard Beschow
2022-05-30 19:11 ` Mark Cave-Ayland
2022-05-30 19:45 ` Philippe Mathieu-Daudé via
2022-06-04 8:36 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5cf718e-fc56-c271-5827-dc2d3c86a231@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=qemu-trivial@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.