* [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()
@ 2018-03-19 11:58 Bastian Koppelmann
2018-03-20 1:24 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Bastian Koppelmann @ 2018-03-19 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: richard.henderson, peter.maydell, Peer Adelt
if '-w 16' was given as a cmdline args a local copy of insnmask
is set and not the global one.
Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
scripts/decodetree.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 41301c84aa..277f9a9bba 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -972,6 +972,7 @@ def main():
global input_file
global insnwidth
global insntype
+ global insnmask
decode_function = 'decode'
decode_scope = 'static '
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()
2018-03-19 11:58 [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main() Bastian Koppelmann
@ 2018-03-20 1:24 ` Richard Henderson
2018-03-20 4:03 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2018-03-20 1:24 UTC (permalink / raw)
To: Bastian Koppelmann, qemu-devel; +Cc: peter.maydell, Peer Adelt
On 03/19/2018 07:58 PM, Bastian Koppelmann wrote:
> if '-w 16' was given as a cmdline args a local copy of insnmask
> is set and not the global one.
>
> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main()
2018-03-20 1:24 ` Richard Henderson
@ 2018-03-20 4:03 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2018-03-20 4:03 UTC (permalink / raw)
To: Bastian Koppelmann, qemu-devel; +Cc: peter.maydell, Peer Adelt
On 03/20/2018 09:24 AM, Richard Henderson wrote:
> On 03/19/2018 07:58 PM, Bastian Koppelmann wrote:
>> if '-w 16' was given as a cmdline args a local copy of insnmask
>> is set and not the global one.
>>
>> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
>> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
I've applied this locally. I'll wait until development opens to send a pull
for this, given than there are no in-tree users of this script for the release.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-20 4:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 11:58 [Qemu-devel] [PATCH] scripts/decodetree: Fix insnmask not marked as global in main() Bastian Koppelmann
2018-03-20 1:24 ` Richard Henderson
2018-03-20 4:03 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.