All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Tobin C. Harding" <tobin@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] docs: Use correct list markup character
Date: Thu, 7 Mar 2019 19:40:14 -0800	[thread overview]
Message-ID: <f5d4469a-ab32-46cb-c1e9-16712043465b@infradead.org> (raw)
In-Reply-To: <20190307211153.28400-7-tobin@kernel.org>

On 3/7/19 1:11 PM, Tobin C. Harding wrote:
> Sphinx uses a star not a hyphen for lists.
> 
> Use correct list markup character.
> 
> Signed-off-by: Tobin C. Harding <tobin@kernel.org>

Hi Tobin,

The blank line insertions are all that is needed.
And I have already sent a patch for that.

Also, a list can begin with any of:
"A text block which begins with a "*", "+", "-", "•", "‣", or "⁃", followed by whitespace, is a bullet list item (a.k.a. "unordered" list item)."

from http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#bullet-lists


> ---
>  Documentation/driver-api/gpio/board.rst |  5 +++--
>  Documentation/laptops/lg-laptop.rst     | 12 ++++++------
>  2 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/driver-api/gpio/board.rst b/Documentation/driver-api/gpio/board.rst
> index a0f294e2e250..a5d5c22ab610 100644
> --- a/Documentation/driver-api/gpio/board.rst
> +++ b/Documentation/driver-api/gpio/board.rst
> @@ -204,8 +204,9 @@ between a caller and a respective .get/set_multiple() callback of a GPIO chip.
>  
>  In order to qualify for fast bitmap processing, the array must meet the
>  following requirements:
> -- pin hardware number of array member 0 must also be 0,
> -- pin hardware numbers of consecutive array members which belong to the same
> +
> +* pin hardware number of array member 0 must also be 0.
> +* pin hardware numbers of consecutive array members which belong to the same
>    chip as member 0 does must also match their array indexes.
>  
>  Otherwise fast bitmap processing path is not used in order to avoid consecutive
> diff --git a/Documentation/laptops/lg-laptop.rst b/Documentation/laptops/lg-laptop.rst
> index e486fe7ddc35..d9e560dfd045 100644
> --- a/Documentation/laptops/lg-laptop.rst
> +++ b/Documentation/laptops/lg-laptop.rst
> @@ -9,12 +9,12 @@ Hotkeys
>  -------
>  
>  The following FN keys are ignored by the kernel without this driver:
> -- FN-F1 (LG control panel)   - Generates F15
> -- FN-F5 (Touchpad toggle)    - Generates F13
> -- FN-F6 (Airplane mode)      - Generates RFKILL
> -- FN-F8 (Keyboard backlight) - Generates F16.
> -  This key also changes keyboard backlight mode.
> -- FN-F9 (Reader mode)        - Generates F14
> +
> +* FN-F1 (LG control panel)   - Generates F15
> +* FN-F5 (Touchpad toggle)    - Generates F13
> +* FN-F6 (Airplane mode)      - Generates RFKILL
> +* FN-F8 (Keyboard backlight) - Generates F16 (This key also changes keyboard backlight mode)
> +* FN-F9 (Reader mode)        - Generates F14
>  
>  The rest of the FN key work without a need for a special driver.
>  
> 


-- 
~Randy

  reply	other threads:[~2019-03-08  3:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 21:11 [PATCH 0/9] docs: Fix various build warnings/errors Tobin C. Harding
2019-03-07 21:11 ` [PATCH 1/9] docs: Fix spelling mistake Tobin C. Harding
2019-03-07 21:11 ` [PATCH 2/9] docs: Add colon clearing sphinx warning Tobin C. Harding
2019-03-07 21:11 ` [PATCH 3/9] docs: Remove unnecessary reference link title Tobin C. Harding
2019-03-07 21:11 ` [PATCH 4/9] docs: Use reference to link to rst file Tobin C. Harding
2019-03-07 21:11 ` [PATCH 5/9] docs: Replace backtick with apostrophe Tobin C. Harding
2019-03-08  3:35   ` Randy Dunlap
2019-03-07 21:11 ` [PATCH 6/9] docs: Use correct list markup character Tobin C. Harding
2019-03-08  3:40   ` Randy Dunlap [this message]
2019-03-08  4:58     ` Tobin C. Harding
2019-03-07 21:11 ` [PATCH 7/9] docs: Remove unknown 'hint' directive Tobin C. Harding
2019-03-08  3:51   ` Randy Dunlap
2019-03-08  8:27     ` Markus Heiser
2019-03-08 16:04       ` Randy Dunlap
2019-03-08 16:35         ` Randy Dunlap
2019-03-07 21:11 ` [PATCH 8/9] docs: Fix Title underline too short warning Tobin C. Harding
2019-03-08  3:42   ` Randy Dunlap
2019-03-08  4:57     ` Tobin C. Harding
2019-03-07 21:11 ` [PATCH 9/9] docs: Add blank line after SPDX licence identifier Tobin C. Harding
2019-03-08  3:43   ` Randy Dunlap
2019-03-08  8:40 ` [PATCH 0/9] docs: Fix various build warnings/errors Markus Heiser
2019-03-08 20:16   ` Tobin C. Harding
2019-03-09  9:20     ` Markus Heiser
2019-03-25 16:33 ` Jonathan Corbet
2019-03-25 21:59   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5d4469a-ab32-46cb-c1e9-16712043465b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tobin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.