From: John Hubbard <jhubbard@nvidia.com>
To: Souptick Joarder <jrdr.linux@gmail.com>, <takedakn@nttdata.co.jp>,
<penguin-kernel@I-love.SAKURA.ne.jp>, <jmorris@namei.org>,
<serge@hallyn.com>
Cc: <linux-security-module@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tomoyo: Fixed typo in documentation
Date: Sat, 7 Nov 2020 00:57:19 -0800 [thread overview]
Message-ID: <f5ed0413-315c-d5d0-e33f-c2b247a28da2@nvidia.com> (raw)
In-Reply-To: <1604737451-19082-2-git-send-email-jrdr.linux@gmail.com>
On 11/7/20 12:24 AM, Souptick Joarder wrote:
> Fixed typo s/Poiner/Pointer
>
> Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> ---
> security/tomoyo/domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
> index bd748be..7b2babe 100644
> --- a/security/tomoyo/domain.c
> +++ b/security/tomoyo/domain.c
> @@ -891,7 +891,7 @@ int tomoyo_find_next_domain(struct linux_binprm *bprm)
> *
> * @bprm: Pointer to "struct linux_binprm".
> * @pos: Location to dump.
> - * @dump: Poiner to "struct tomoyo_page_dump".
> + * @dump: Pointer to "struct tomoyo_page_dump".
Not worth a separate patch, especially since the original comment is merely
copying the C sources, and as such, does not add any value.
I'd either a) craft a new documentation line that adds some value, or b) just
merge this patch into the previous one, and make a note in the commit
description to the effect that you've included a trivial typo fix as long
as you're there.
thanks,
--
John Hubbard
NVIDIA
> *
> * Returns true on success, false otherwise.
> */
>
next prev parent reply other threads:[~2020-11-07 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 8:24 [PATCH 1/2] tomoyo: Convert get_user_pages*() to pin_user_pages*() Souptick Joarder
2020-11-07 8:24 ` [PATCH 2/2] tomoyo: Fixed typo in documentation Souptick Joarder
2020-11-07 8:57 ` John Hubbard [this message]
2020-11-09 3:41 ` Souptick Joarder
2020-11-09 4:17 ` John Hubbard
2020-11-09 4:45 ` Tetsuo Handa
2020-11-10 3:08 ` James Morris
2020-11-07 9:04 ` [PATCH 1/2] tomoyo: Convert get_user_pages*() to pin_user_pages*() John Hubbard
2020-11-07 19:17 ` John Hubbard
2020-11-08 1:13 ` Tetsuo Handa
2020-11-08 2:17 ` John Hubbard
2020-11-08 4:12 ` Tetsuo Handa
2020-11-08 5:00 ` John Hubbard
2020-11-09 3:38 ` Souptick Joarder
2020-11-09 3:36 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ed0413-315c-d5d0-e33f-c2b247a28da2@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=jmorris@namei.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=serge@hallyn.com \
--cc=takedakn@nttdata.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.