Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[Greg KH]

On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> Fix a bug in the resource walking code.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/hv/vmbus_drv.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Is this for 3.14-final or 3.15?

I ask this every time, someday you will let me know ahead of time...

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, February 20, 2014 3:06 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> resources
> 
> On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in the resource walking code.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/vmbus_drv.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Is this for 3.14-final or 3.15?
> 
> I ask this every time, someday you will let me know ahead of time...

I am sorry Greg. This is for 3.14-final.

Regards,

K. Y

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[K. Y. Srinivasan]

Fix a bug in the resource walking code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@ static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
 	switch (res->type) {
 	case ACPI_RESOURCE_TYPE_IRQ:
 		irq = res->data.irq.interrupts[0];
+		break;
 
 	case ACPI_RESOURCE_TYPE_ADDRESS64:
 		hyperv_mmio_start = res->data.address64.minimum;
 		hyperv_mmio_size = res->data.address64.address_length;
+		break;
 	}
 
 	return AE_OK;
-- 
1.7.4.1

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, February 20, 2014 3:47 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> resources
> 
> On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in the resource walking code.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/vmbus_drv.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Fails to apply to my char-misc-next branch (if you want it in
> 3.14-final, that's where it belongs...):
> 	checking file drivers/hv/vmbus_drv.c
> 	Hunk #1 FAILED at 899.
> 	1 out of 1 hunk FAILED

I will rebase it send it to you shortly.

Thanks,

K. Y

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[Greg KH]

On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> Fix a bug in the resource walking code.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/hv/vmbus_drv.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Fails to apply to my char-misc-next branch (if you want it in
3.14-final, that's where it belongs...):
	checking file drivers/hv/vmbus_drv.c
	Hunk #1 FAILED at 899.
	1 out of 1 hunk FAILED

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, February 20, 2014 3:47 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> resources
> 
> On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in the resource walking code.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/vmbus_drv.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Fails to apply to my char-misc-next branch (if you want it in
> 3.14-final, that's where it belongs...):
> 	checking file drivers/hv/vmbus_drv.c
> 	Hunk #1 FAILED at 899.
> 	1 out of 1 hunk FAILED

Greg,

This patch is based on this commit:

commit 90f3453585479d5beb75058da46eb573ced0e6ac

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I just got your char-misc-next branch and it does not have the needed commit.

Regards,

K. Y

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[KY Srinivasan]

> -----Original Message-----
> From: driverdev-devel-bounces@linuxdriverproject.org [mailto:driverdev-devel-
> bounces@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Thursday, February 20, 2014 4:19 PM
> To: Greg KH
> Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> resources
> 
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday, February 20, 2014 3:47 PM
> > To: KY Srinivasan
> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> > resources
> >
> > On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > > Fix a bug in the resource walking code.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > >  drivers/hv/vmbus_drv.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Fails to apply to my char-misc-next branch (if you want it in
> > 3.14-final, that's where it belongs...):
> > 	checking file drivers/hv/vmbus_drv.c
> > 	Hunk #1 FAILED at 899.
> > 	1 out of 1 hunk FAILED
> 
> Greg,
> 
> This patch is based on this commit:
> 
> commit 90f3453585479d5beb75058da46eb573ced0e6ac
> 
>     Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I just got your char-misc-next branch and it does not have the needed commit.

Greg,

The commit referenced above was checked into your char-misc.git tree on the 7th of Feb.
Can you check in this patch to the same tree. I could resend this patch.

Regards,

K. Y
> 
> Regards,
> 
> K. Y
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[Greg KH]

On Fri, Feb 21, 2014 at 12:19:22AM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday, February 20, 2014 3:47 PM
> > To: KY Srinivasan
> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> > resources
> > 
> > On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > > Fix a bug in the resource walking code.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > >  drivers/hv/vmbus_drv.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > Fails to apply to my char-misc-next branch (if you want it in
> > 3.14-final, that's where it belongs...):
> > 	checking file drivers/hv/vmbus_drv.c
> > 	Hunk #1 FAILED at 899.
> > 	1 out of 1 hunk FAILED
> 
> Greg,
> 
> This patch is based on this commit:
> 
> commit 90f3453585479d5beb75058da46eb573ced0e6ac
> 
>     Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I just got your char-misc-next branch and it does not have the needed commit.

Then I guess this isn't 3.14-final material, right?

Please resend it when you have determined which branch it should go
into, it's out of my queue now.

greg k-h

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, February 20, 2014 6:21 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified
> resources
> 
> On Fri, Feb 21, 2014 at 12:19:22AM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > Sent: Thursday, February 20, 2014 3:47 PM
> > > To: KY Srinivasan
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org
> > > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI
> specified
> > > resources
> > >
> > > On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote:
> > > > Fix a bug in the resource walking code.
> > > >
> > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > ---
> > > >  drivers/hv/vmbus_drv.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > Fails to apply to my char-misc-next branch (if you want it in
> > > 3.14-final, that's where it belongs...):
> > > 	checking file drivers/hv/vmbus_drv.c
> > > 	Hunk #1 FAILED at 899.
> > > 	1 out of 1 hunk FAILED
> >
> > Greg,
> >
> > This patch is based on this commit:
> >
> > commit 90f3453585479d5beb75058da46eb573ced0e6ac
> >
> >     Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > I just got your char-misc-next branch and it does not have the needed commit.
> 
> Then I guess this isn't 3.14-final material, right?
> 
> Please resend it when you have determined which branch it should go
> into, it's out of my queue now.

Thanks Greg, I will resend the patch. Please apply it to char-misc.git tree.

Regards,

K. Y

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

[K. Y. Srinivasan]

Fix a bug in the resource walking code. This patch depends on
commit number: 90f3453585479d5beb75058da46eb573ced0e6ac

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@ static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
 	switch (res->type) {
 	case ACPI_RESOURCE_TYPE_IRQ:
 		irq = res->data.irq.interrupts[0];
+		break;
 
 	case ACPI_RESOURCE_TYPE_ADDRESS64:
 		hyperv_mmio_start = res->data.address64.minimum;
 		hyperv_mmio_size = res->data.address64.address_length;
+		break;
 	}
 
 	return AE_OK;
-- 
1.7.4.1